Re: [PATCH net v6] failover: allow name change on IFF_UP slave interfaces

2019-04-07 Thread Stephen Hemminger
On Fri, 5 Apr 2019 18:01:43 -0400 "Michael S. Tsirkin" wrote: > > > > This notifier is not really necessary, there already is a CHANGENAME > > that gets sent. > > NETDEV_CHANGE is used in other cases to mean that the state (flags) > > have changed. > > The point is some existing scripts might

Re: [PATCH net v6] failover: allow name change on IFF_UP slave interfaces

2019-04-06 Thread Samudrala, Sridhar
On 4/6/2019 12:21 AM, si-wei liu wrote: Stephen are you happy with this approach? I think it is the best solution for what you want to do. Since you're asking specifically, I tried what you suggested below. Did you test with some things like Free Range Routing, Although there might be

Re: [PATCH net v6] failover: allow name change on IFF_UP slave interfaces

2019-04-05 Thread Michael S. Tsirkin
On Fri, Apr 05, 2019 at 02:47:01PM -0700, Stephen Hemminger wrote: > On Wed, 3 Apr 2019 00:52:47 -0400 > Si-Wei Liu wrote: > > > > > + if (unlikely(dev->flags & IFF_UP)) { > > + struct netdev_notifier_change_info change_info = { > > + .info.dev = dev, > > +

Re: [PATCH net v6] failover: allow name change on IFF_UP slave interfaces

2019-04-05 Thread Stephen Hemminger
On Fri, 5 Apr 2019 17:28:55 -0400 "Michael S. Tsirkin" wrote: > On Wed, Apr 03, 2019 at 12:52:47AM -0400, Si-Wei Liu wrote: > > When a netdev appears through hot plug then gets enslaved by a failover > > master that is already up and running, the slave will be opened > > right away after getting

Re: [PATCH net v6] failover: allow name change on IFF_UP slave interfaces

2019-04-05 Thread Stephen Hemminger
On Wed, 3 Apr 2019 00:52:47 -0400 Si-Wei Liu wrote: > > + if (unlikely(dev->flags & IFF_UP)) { > + struct netdev_notifier_change_info change_info = { > + .info.dev = dev, > + }; > + > + call_netdevice_notifiers_info(NETDEV_CHANGE, > +

Re: [PATCH net v6] failover: allow name change on IFF_UP slave interfaces

2019-04-05 Thread Michael S. Tsirkin
On Wed, Apr 03, 2019 at 12:52:47AM -0400, Si-Wei Liu wrote: > When a netdev appears through hot plug then gets enslaved by a failover > master that is already up and running, the slave will be opened > right away after getting enslaved. Today there's a race that userspace > (udev) may fail to renam