Re: [PATCH v14] i2c: virtio: add a virtio i2c frontend driver

2021-09-07 Thread Jie Deng
On 2021/9/6 12:43, Viresh Kumar wrote: Let's let the dust settle on them then, then resubmit? It doesn't break anything for now since we don't have much users and we know zero length transfers don't work. I will submit the necessary changes once spec is finalized. Agree. The currently merg

Re: [PATCH v14] i2c: virtio: add a virtio i2c frontend driver

2021-09-05 Thread Viresh Kumar
On 04-09-21, 16:01, Michael S. Tsirkin wrote: > Same as with qemu bits, I am confused as to what is the status > of proposed spec changes and whether the driver will work > with them. This is already merged as well. The current version simply fails to transmit the messages in case the length of a

Re: [PATCH v14] i2c: virtio: add a virtio i2c frontend driver

2021-09-04 Thread Michael S. Tsirkin
On Fri, Jul 09, 2021 at 10:25:30AM +0800, Jie Deng wrote: > Add an I2C bus driver for virtio para-virtualization. > > The controller can be emulated by the backend driver in > any device model software by following the virtio protocol. > > The device specification can be found on > https://lists.

Re: [PATCH v14] i2c: virtio: add a virtio i2c frontend driver

2021-07-22 Thread Viresh Kumar
On 23-07-21, 10:21, Jie Deng wrote: > I think we can add an i2c_adapter_quirks for this moment. Support for > I2C_FUNC_SMBUS_QUICK > can be added incrementally if needed. +1. We just need to get this merged :) > I will play this role. I see Viresh also spend a lot of time on this driver. > > S

Re: [PATCH v14] i2c: virtio: add a virtio i2c frontend driver

2021-07-22 Thread Jie Deng
On 2021/7/22 23:35, Wolfram Sang wrote: Hi, so only minor stuff left from my side. @@ -21,6 +21,17 @@ config I2C_ALI1535 This driver can also be built as a module. If so, the module will be called i2c-ali1535. +config I2C_VIRTIO + tristate "Virtio I2C Adapter" +

Re: [PATCH v14] i2c: virtio: add a virtio i2c frontend driver

2021-07-21 Thread Viresh Kumar
On 22-07-21, 08:06, Greg KH wrote: > No new features are allowed for 5.14, you know this. It's but fixes > only now. I was trying to be (overly) optimistic here since this was a fairly independent driver which won't break anything else, and had been pending on the list since many months now. But

Re: [PATCH v14] i2c: virtio: add a virtio i2c frontend driver

2021-07-21 Thread Greg KH
On Thu, Jul 22, 2021 at 10:44:33AM +0530, Viresh Kumar wrote: > On 09-07-21, 10:25, Jie Deng wrote: > > Add an I2C bus driver for virtio para-virtualization. > > > > The controller can be emulated by the backend driver in > > any device model software by following the virtio protocol. > > > > The

Re: [PATCH v14] i2c: virtio: add a virtio i2c frontend driver

2021-07-21 Thread Viresh Kumar
On 09-07-21, 10:25, Jie Deng wrote: > Add an I2C bus driver for virtio para-virtualization. > > The controller can be emulated by the backend driver in > any device model software by following the virtio protocol. > > The device specification can be found on > https://lists.oasis-open.org/archive

Re: [PATCH v14] i2c: virtio: add a virtio i2c frontend driver

2021-07-14 Thread Jie Deng
On 2021/7/13 23:38, Michael S. Tsirkin wrote: I think we should tweak this such that we add multiple buffers but only make them visible to host after all add commands were successful. With split this is possible by deffering avail idx update, with packed by deferring update of the avail bit in

Re: [PATCH v14] i2c: virtio: add a virtio i2c frontend driver

2021-07-13 Thread Viresh Kumar
On 13-07-21, 11:38, Michael S. Tsirkin wrote: > I think we should tweak this such that we add multiple buffers but > only make them visible to host after all add commands were successful. > With split this is possible by deffering avail idx update, > with packed by deferring update of the avail bit

Re: [PATCH v14] i2c: virtio: add a virtio i2c frontend driver

2021-07-13 Thread Michael S. Tsirkin
On Fri, Jul 09, 2021 at 10:25:30AM +0800, Jie Deng wrote: > Add an I2C bus driver for virtio para-virtualization. > > The controller can be emulated by the backend driver in > any device model software by following the virtio protocol. > > The device specification can be found on > https://lists.

Re: [PATCH v14] i2c: virtio: add a virtio i2c frontend driver

2021-07-13 Thread Michael S. Tsirkin
On Fri, Jul 09, 2021 at 09:14:07AM +0530, Viresh Kumar wrote: > On 09-07-21, 10:25, Jie Deng wrote: > > Add an I2C bus driver for virtio para-virtualization. > > > > The controller can be emulated by the backend driver in > > any device model software by following the virtio protocol. > > > > The

Re: [PATCH v14] i2c: virtio: add a virtio i2c frontend driver

2021-07-08 Thread Viresh Kumar
On 09-07-21, 10:25, Jie Deng wrote: > Add an I2C bus driver for virtio para-virtualization. > > The controller can be emulated by the backend driver in > any device model software by following the virtio protocol. > > The device specification can be found on > https://lists.oasis-open.org/archive

[PATCH v14] i2c: virtio: add a virtio i2c frontend driver

2021-07-08 Thread Jie Deng
Add an I2C bus driver for virtio para-virtualization. The controller can be emulated by the backend driver in any device model software by following the virtio protocol. The device specification can be found on https://lists.oasis-open.org/archives/virtio-comment/202101/msg8.html. By followi