Re: [PATCH v2] virtio-net: free bufs correctly on invalid packet length

2013-12-06 Thread Rusty Russell
Michael Dalton writes: > When a packet with invalid length arrives, ensure that the packet > is freed correctly if mergeable packet buffers and big packets > (GUEST_TSO4) are both enabled. > > Signed-off-by: Michael Dalton Acked-by: Rusty Russell Thanks! > --- > drivers/net/virtio_net.c | 6

Re: [PATCH v2] virtio-net: free bufs correctly on invalid packet length

2013-12-06 Thread Michael Dalton
Hi David, This patch fixes a bug introduced by 2613af0ed18a ("virtio_net: migrate mergeable rx buffers to page frag allocators"). The bug is present in both net-next and net. Thanks Best, Mike On Fri, Dec 6, 2013 at 1:32 PM, David Miller wrote: > From: Michael Dalton > Date: Thu, 5 Dec 2013

Re: [PATCH v2] virtio-net: free bufs correctly on invalid packet length

2013-12-06 Thread David Miller
From: Michael Dalton Date: Thu, 5 Dec 2013 13:14:05 -0800 > When a packet with invalid length arrives, ensure that the packet > is freed correctly if mergeable packet buffers and big packets > (GUEST_TSO4) are both enabled. > > Signed-off-by: Michael Dalton Applied, is this needed for -stable

Re: [PATCH v2] virtio-net: free bufs correctly on invalid packet length

2013-12-06 Thread Andrew Vagin
On Thu, Dec 05, 2013 at 01:14:05PM -0800, Michael Dalton wrote: > When a packet with invalid length arrives, ensure that the packet > is freed correctly if mergeable packet buffers and big packets > (GUEST_TSO4) are both enabled. > > Signed-off-by: Michael Dalton Acked-by: Andrew Vagin > --- >

Re: [PATCH v2] virtio-net: free bufs correctly on invalid packet length

2013-12-05 Thread Jason Wang
On 12/06/2013 05:14 AM, Michael Dalton wrote: > When a packet with invalid length arrives, ensure that the packet > is freed correctly if mergeable packet buffers and big packets > (GUEST_TSO4) are both enabled. > > Signed-off-by: Michael Dalton > --- > drivers/net/virtio_net.c | 6 +++--- > 1 fi

Re: [PATCH v2] virtio-net: free bufs correctly on invalid packet length

2013-12-05 Thread Michael Dalton
Hi, A quick note on this patch: I have confirmed that without this patch a kernel crash occurs if we force a 'packet too short' error sufficiently many times. This patch eliminates the kernel crash. Since this crash would be triggered by a hypervisor bug, I made a small change not reflected in th

[PATCH v2] virtio-net: free bufs correctly on invalid packet length

2013-12-05 Thread Michael Dalton
When a packet with invalid length arrives, ensure that the packet is freed correctly if mergeable packet buffers and big packets (GUEST_TSO4) are both enabled. Signed-off-by: Michael Dalton --- drivers/net/virtio_net.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dri