Re: [PATCH v2 1/1] virtio_net: notify MAC address change on device initialization

2023-01-27 Thread Michael S. Tsirkin
On Fri, Jan 27, 2023 at 01:28:01PM +0100, Laurent Vivier wrote: > On 1/27/23 12:08, Michael S. Tsirkin wrote: > > On Tue, Jan 24, 2023 at 12:04:24PM +0100, Laurent Vivier wrote: > > > On 1/24/23 11:15, Michael S. Tsirkin wrote: > > > > On Mon, Jan 23, 2023 at 01:00:22PM +0100, Laurent Vivier wrote:

Re: [PATCH v2 1/1] virtio_net: notify MAC address change on device initialization

2023-01-27 Thread Laurent Vivier
On 1/27/23 12:08, Michael S. Tsirkin wrote: On Tue, Jan 24, 2023 at 12:04:24PM +0100, Laurent Vivier wrote: On 1/24/23 11:15, Michael S. Tsirkin wrote: On Mon, Jan 23, 2023 at 01:00:22PM +0100, Laurent Vivier wrote: In virtnet_probe(), if the device doesn't provide a MAC address the driver ass

Re: [PATCH v2 1/1] virtio_net: notify MAC address change on device initialization

2023-01-27 Thread Michael S. Tsirkin
On Tue, Jan 24, 2023 at 12:04:24PM +0100, Laurent Vivier wrote: > On 1/24/23 11:15, Michael S. Tsirkin wrote: > > On Mon, Jan 23, 2023 at 01:00:22PM +0100, Laurent Vivier wrote: > > > In virtnet_probe(), if the device doesn't provide a MAC address the > > > driver assigns a random one. > > > As we

Re: [PATCH v2 1/1] virtio_net: notify MAC address change on device initialization

2023-01-24 Thread Laurent Vivier
On 1/24/23 11:15, Michael S. Tsirkin wrote: On Mon, Jan 23, 2023 at 01:00:22PM +0100, Laurent Vivier wrote: In virtnet_probe(), if the device doesn't provide a MAC address the driver assigns a random one. As we modify the MAC address we need to notify the device to allow it to update all the rel

Re: [PATCH v2 1/1] virtio_net: notify MAC address change on device initialization

2023-01-24 Thread Michael S. Tsirkin
On Mon, Jan 23, 2023 at 01:00:22PM +0100, Laurent Vivier wrote: > In virtnet_probe(), if the device doesn't provide a MAC address the > driver assigns a random one. > As we modify the MAC address we need to notify the device to allow it > to update all the related information. > > The problem can

[PATCH v2 1/1] virtio_net: notify MAC address change on device initialization

2023-01-23 Thread Laurent Vivier
In virtnet_probe(), if the device doesn't provide a MAC address the driver assigns a random one. As we modify the MAC address we need to notify the device to allow it to update all the related information. The problem can be seen with vDPA and mlx5_vdpa driver as it doesn't assign a MAC address by