Re: [PATCH v2 2/3] vhost: support PACKED when setting-getting vring_base

2023-06-05 Thread Stefano Garzarella
On Fri, Jun 02, 2023 at 07:36:26AM -0400, Michael S. Tsirkin wrote: On Thu, May 18, 2023 at 09:34:25AM +0200, Stefano Garzarella wrote: I think we should do one of these things, though: - mask VIRTIO_F_RING_PACKED in the stable kernels when VHOST_GET_FEAETURES is called - backport this patch on

Re: [PATCH v2 2/3] vhost: support PACKED when setting-getting vring_base

2023-06-02 Thread Michael S. Tsirkin
On Thu, May 18, 2023 at 09:34:25AM +0200, Stefano Garzarella wrote: > I think we should do one of these things, though: > - mask VIRTIO_F_RING_PACKED in the stable kernels when > VHOST_GET_FEAETURES is called > - backport this patch on all stable kernels that support vhost-vdpa > > Maybe the last

Re: [PATCH v2 2/3] vhost: support PACKED when setting-getting vring_base

2023-05-18 Thread Michael S. Tsirkin
On Thu, May 18, 2023 at 04:59:17PM +0800, Jason Wang wrote: > On Thu, May 18, 2023 at 4:38 PM Michael S. Tsirkin wrote: > > > > On Thu, May 18, 2023 at 03:52:10PM +0800, Jason Wang wrote: > > > On Thu, May 18, 2023 at 3:34 PM Stefano Garzarella > > > wrote: > > > > > > > > On Thu, May 18, 2023 a

Re: [PATCH v2 2/3] vhost: support PACKED when setting-getting vring_base

2023-05-18 Thread Jason Wang
On Thu, May 18, 2023 at 4:38 PM Michael S. Tsirkin wrote: > > On Thu, May 18, 2023 at 03:52:10PM +0800, Jason Wang wrote: > > On Thu, May 18, 2023 at 3:34 PM Stefano Garzarella > > wrote: > > > > > > On Thu, May 18, 2023 at 7:24 AM Jason Wang wrote: > > > > > > > > On Wed, May 17, 2023 at 3:00 

Re: [PATCH v2 2/3] vhost: support PACKED when setting-getting vring_base

2023-05-18 Thread Michael S. Tsirkin
On Thu, May 18, 2023 at 03:52:10PM +0800, Jason Wang wrote: > On Thu, May 18, 2023 at 3:34 PM Stefano Garzarella > wrote: > > > > On Thu, May 18, 2023 at 7:24 AM Jason Wang wrote: > > > > > > On Wed, May 17, 2023 at 3:00 PM Stefano Garzarella > > > wrote: > > > > > > > > On Wed, May 17, 2023 a

Re: [PATCH v2 2/3] vhost: support PACKED when setting-getting vring_base

2023-05-18 Thread Jason Wang
On Thu, May 18, 2023 at 3:34 PM Stefano Garzarella wrote: > > On Thu, May 18, 2023 at 7:24 AM Jason Wang wrote: > > > > On Wed, May 17, 2023 at 3:00 PM Stefano Garzarella > > wrote: > > > > > > On Wed, May 17, 2023 at 7:26 AM Jason Wang wrote: > > > > > > > > On Wed, May 17, 2023 at 2:26 AM Sh

Re: [PATCH v2 2/3] vhost: support PACKED when setting-getting vring_base

2023-05-18 Thread Stefano Garzarella
On Thu, May 18, 2023 at 7:24 AM Jason Wang wrote: > > On Wed, May 17, 2023 at 3:00 PM Stefano Garzarella > wrote: > > > > On Wed, May 17, 2023 at 7:26 AM Jason Wang wrote: > > > > > > On Wed, May 17, 2023 at 2:26 AM Shannon Nelson > > > wrote: > > > > > > > > On 5/16/23 12:49 AM, Stefano Garz

Re: [PATCH v2 2/3] vhost: support PACKED when setting-getting vring_base

2023-05-17 Thread Jason Wang
On Wed, May 17, 2023 at 3:00 PM Stefano Garzarella wrote: > > On Wed, May 17, 2023 at 7:26 AM Jason Wang wrote: > > > > On Wed, May 17, 2023 at 2:26 AM Shannon Nelson > > wrote: > > > > > > On 5/16/23 12:49 AM, Stefano Garzarella wrote: > > > > On Mon, May 15, 2023 at 01:41:12PM -0700, Shannon

Re: [PATCH v2 2/3] vhost: support PACKED when setting-getting vring_base

2023-05-17 Thread Stefano Garzarella
On Wed, May 17, 2023 at 7:26 AM Jason Wang wrote: > > On Wed, May 17, 2023 at 2:26 AM Shannon Nelson wrote: > > > > On 5/16/23 12:49 AM, Stefano Garzarella wrote: > > > On Mon, May 15, 2023 at 01:41:12PM -0700, Shannon Nelson wrote: > > >> On 5/9/23 1:46 AM, Stefano Garzarella wrote: > > >>> On M

Re: [PATCH v2 2/3] vhost: support PACKED when setting-getting vring_base

2023-05-16 Thread Jason Wang
On Wed, May 17, 2023 at 2:26 AM Shannon Nelson wrote: > > On 5/16/23 12:49 AM, Stefano Garzarella wrote: > > On Mon, May 15, 2023 at 01:41:12PM -0700, Shannon Nelson wrote: > >> On 5/9/23 1:46 AM, Stefano Garzarella wrote: > >>> On Mon, Apr 24, 2023 at 03:50:30PM -0700, Shannon Nelson via > >>> Vi

Re: [PATCH v2 2/3] vhost: support PACKED when setting-getting vring_base

2023-05-16 Thread Shannon Nelson via Virtualization
On 5/16/23 12:49 AM, Stefano Garzarella wrote: On Mon, May 15, 2023 at 01:41:12PM -0700, Shannon Nelson wrote: On 5/9/23 1:46 AM, Stefano Garzarella wrote: On Mon, Apr 24, 2023 at 03:50:30PM -0700, Shannon Nelson via Virtualization wrote: Use the right structs for PACKED or split vqs when sett

Re: [PATCH v2 2/3] vhost: support PACKED when setting-getting vring_base

2023-05-16 Thread Stefano Garzarella
On Mon, May 15, 2023 at 01:41:12PM -0700, Shannon Nelson wrote: On 5/9/23 1:46 AM, Stefano Garzarella wrote: On Mon, Apr 24, 2023 at 03:50:30PM -0700, Shannon Nelson via Virtualization wrote: Use the right structs for PACKED or split vqs when setting and getting the vring base. Signed-off-by:

Re: [PATCH v2 2/3] vhost: support PACKED when setting-getting vring_base

2023-05-15 Thread Shannon Nelson via Virtualization
On 5/9/23 1:46 AM, Stefano Garzarella wrote: On Mon, Apr 24, 2023 at 03:50:30PM -0700, Shannon Nelson via Virtualization wrote: Use the right structs for PACKED or split vqs when setting and getting the vring base. Signed-off-by: Shannon Nelson --- drivers/vhost/vhost.c | 18 +-

Re: [PATCH v2 2/3] vhost: support PACKED when setting-getting vring_base

2023-05-09 Thread Stefano Garzarella
On Mon, Apr 24, 2023 at 03:50:30PM -0700, Shannon Nelson via Virtualization wrote: Use the right structs for PACKED or split vqs when setting and getting the vring base. Signed-off-by: Shannon Nelson --- drivers/vhost/vhost.c | 18 +- drivers/vhost/vhost.h | 8 ++-- 2 files

Re: [PATCH v2 2/3] vhost: support PACKED when setting-getting vring_base

2023-04-24 Thread Jason Wang
On Tue, Apr 25, 2023 at 6:50 AM Shannon Nelson wrote: > > Use the right structs for PACKED or split vqs when setting and > getting the vring base. > > Signed-off-by: Shannon Nelson Acked-by: Jason Wang Thanks > --- > drivers/vhost/vhost.c | 18 +- > drivers/vhost/vhost.h | 8

[PATCH v2 2/3] vhost: support PACKED when setting-getting vring_base

2023-04-24 Thread Shannon Nelson via Virtualization
Use the right structs for PACKED or split vqs when setting and getting the vring base. Signed-off-by: Shannon Nelson --- drivers/vhost/vhost.c | 18 +- drivers/vhost/vhost.h | 8 ++-- 2 files changed, 19 insertions(+), 7 deletions(-) diff --git a/drivers/vhost/vhost.c b/dri