Re: [virtio-dev] Re: [PATCH v25 2/2] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-02-01 Thread Michael S. Tsirkin
On Thu, Feb 01, 2018 at 05:43:22PM +0800, Wei Wang wrote: > 3) Hints means the pages are quite likely to be free pages (no guarantee). > If the pages given to host are going to be freed, then we really couldn't > call them hints, they are true free pages. Ballooning needs true free pages, > while

Re: [virtio-dev] Re: [PATCH v25 2/2] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-02-01 Thread Wei Wang
On 01/31/2018 07:44 AM, Michael S. Tsirkin wrote: On Fri, Jan 26, 2018 at 11:31:19AM +0800, Wei Wang wrote: On 01/26/2018 10:42 AM, Michael S. Tsirkin wrote: On Fri, Jan 26, 2018 at 09:40:44AM +0800, Wei Wang wrote: On 01/25/2018 09:49 PM, Michael S. Tsirkin wrote: On Thu, Jan 25, 2018 at

Re: [virtio-dev] Re: [PATCH v25 2/2] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-01-30 Thread Michael S. Tsirkin
On Fri, Jan 26, 2018 at 11:31:19AM +0800, Wei Wang wrote: > On 01/26/2018 10:42 AM, Michael S. Tsirkin wrote: > > On Fri, Jan 26, 2018 at 09:40:44AM +0800, Wei Wang wrote: > > > On 01/25/2018 09:49 PM, Michael S. Tsirkin wrote: > > > > On Thu, Jan 25, 2018 at 05:14:06PM +0800, Wei Wang wrote: > >

Re: [virtio-dev] Re: [PATCH v25 2/2] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-01-26 Thread Tetsuo Handa
On 2018/01/26 12:31, Wei Wang wrote: > On 01/26/2018 10:42 AM, Michael S. Tsirkin wrote: >> On Fri, Jan 26, 2018 at 09:40:44AM +0800, Wei Wang wrote: >>> On 01/25/2018 09:49 PM, Michael S. Tsirkin wrote: On Thu, Jan 25, 2018 at 05:14:06PM +0800, Wei Wang wrote: > >>> The controversy is

Re: [virtio-dev] Re: [PATCH v25 2/2] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-01-25 Thread Wei Wang
On 01/26/2018 10:42 AM, Michael S. Tsirkin wrote: On Fri, Jan 26, 2018 at 09:40:44AM +0800, Wei Wang wrote: On 01/25/2018 09:49 PM, Michael S. Tsirkin wrote: On Thu, Jan 25, 2018 at 05:14:06PM +0800, Wei Wang wrote: The controversy is that the free list is not static once the lock is

Re: [virtio-dev] Re: [PATCH v25 2/2] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-01-25 Thread Michael S. Tsirkin
On Fri, Jan 26, 2018 at 09:40:44AM +0800, Wei Wang wrote: > On 01/25/2018 09:49 PM, Michael S. Tsirkin wrote: > > On Thu, Jan 25, 2018 at 05:14:06PM +0800, Wei Wang wrote: > > > + > > > +static void report_free_page_func(struct work_struct *work) > > > +{ > > > + struct virtio_balloon *vb; > > > +

Re: [PATCH v25 2/2] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-01-25 Thread Michael S. Tsirkin
On Thu, Jan 25, 2018 at 05:14:06PM +0800, Wei Wang wrote: > Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_HINT feature indicates the > support of reporting hints of guest free pages to host via virtio-balloon. > > Host requests the guest to report free pages by sending a new cmd > id to the guest

[PATCH v25 2/2] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-01-25 Thread Wei Wang
Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_HINT feature indicates the support of reporting hints of guest free pages to host via virtio-balloon. Host requests the guest to report free pages by sending a new cmd id to the guest via the free_page_report_cmd_id configuration register. When the