Re: [PATCH v3 0/5] Add a vhost RPMsg API

2020-06-08 Thread Michael S. Tsirkin
On Mon, Jun 08, 2020 at 01:16:38PM +0200, Guennadi Liakhovetski wrote: > On Mon, Jun 08, 2020 at 12:15:26PM +0200, Guennadi Liakhovetski wrote: > > On Mon, Jun 08, 2020 at 05:19:06AM -0400, Michael S. Tsirkin wrote: > > > On Mon, Jun 08, 2020 at 11:11:00AM +0200, Guennadi Liakhovetski wrote: > > >

Re: [PATCH v3 0/5] Add a vhost RPMsg API

2020-06-08 Thread Michael S. Tsirkin
On Mon, Jun 08, 2020 at 12:15:27PM +0200, Guennadi Liakhovetski wrote: > On Mon, Jun 08, 2020 at 05:19:06AM -0400, Michael S. Tsirkin wrote: > > On Mon, Jun 08, 2020 at 11:11:00AM +0200, Guennadi Liakhovetski wrote: > > > Update: I looked through VirtIO 1.0 and 1.1 specs, data format their, > > >

Re: [PATCH v3 0/5] Add a vhost RPMsg API

2020-06-08 Thread Guennadi Liakhovetski
On Mon, Jun 08, 2020 at 12:15:26PM +0200, Guennadi Liakhovetski wrote: > On Mon, Jun 08, 2020 at 05:19:06AM -0400, Michael S. Tsirkin wrote: > > On Mon, Jun 08, 2020 at 11:11:00AM +0200, Guennadi Liakhovetski wrote: > > > Update: I looked through VirtIO 1.0 and 1.1 specs, data format their, > > >

Re: [PATCH v3 0/5] Add a vhost RPMsg API

2020-06-08 Thread Guennadi Liakhovetski
On Mon, Jun 08, 2020 at 05:19:06AM -0400, Michael S. Tsirkin wrote: > On Mon, Jun 08, 2020 at 11:11:00AM +0200, Guennadi Liakhovetski wrote: > > Update: I looked through VirtIO 1.0 and 1.1 specs, data format their, > > including byte order, is defined on a per-device type basis. RPMsg is > > inde

Re: [PATCH v3 0/5] Add a vhost RPMsg API

2020-06-08 Thread Michael S. Tsirkin
On Mon, Jun 08, 2020 at 11:11:00AM +0200, Guennadi Liakhovetski wrote: > Update: I looked through VirtIO 1.0 and 1.1 specs, data format their, > including byte order, is defined on a per-device type basis. RPMsg is > indeed included in the spec as device type 7, but that's the only > mention of

Re: [PATCH v3 0/5] Add a vhost RPMsg API

2020-06-08 Thread Guennadi Liakhovetski
Update: I looked through VirtIO 1.0 and 1.1 specs, data format their, including byte order, is defined on a per-device type basis. RPMsg is indeed included in the spec as device type 7, but that's the only mention of it in both versions. It seems RPMsg over VirtIO isn't standardised yet. Also i

Re: [PATCH v3 0/5] Add a vhost RPMsg API

2020-06-08 Thread Michael S. Tsirkin
On Mon, Jun 08, 2020 at 09:37:15AM +0200, Guennadi Liakhovetski wrote: > Hi Michael, > > On Fri, Jun 05, 2020 at 08:34:35AM +0200, Guennadi Liakhovetski wrote: > > > > On Thu, Jun 04, 2020 at 03:23:37PM -0400, Michael S. Tsirkin wrote: > > [snip] > > > > Another it's out of line with 1.0 spec p

Re: [PATCH v3 0/5] Add a vhost RPMsg API

2020-06-08 Thread Guennadi Liakhovetski
Hi Michael, On Fri, Jun 05, 2020 at 08:34:35AM +0200, Guennadi Liakhovetski wrote: > > On Thu, Jun 04, 2020 at 03:23:37PM -0400, Michael S. Tsirkin wrote: [snip] > > Another it's out of line with 1.0 spec passing guest > > endian data around. Won't work if host and guest > > endian-ness do not

Re: [PATCH v3 0/5] Add a vhost RPMsg API

2020-06-04 Thread Guennadi Liakhovetski
Hi Michael, Thanks for your review. On Thu, Jun 04, 2020 at 03:23:37PM -0400, Michael S. Tsirkin wrote: > On Wed, May 27, 2020 at 08:05:36PM +0200, Guennadi Liakhovetski wrote: > > v3: > > - address several checkpatch warnings > > - address comments from Mathieu Poirier > > > > v2: > > - update

Re: [PATCH v3 0/5] Add a vhost RPMsg API

2020-06-04 Thread Michael S. Tsirkin
On Wed, May 27, 2020 at 08:05:36PM +0200, Guennadi Liakhovetski wrote: > v3: > - address several checkpatch warnings > - address comments from Mathieu Poirier > > v2: > - update patch #5 with a correct vhost_dev_init() prototype > - drop patch #6 - it depends on a different patch, that is currentl

Re: [PATCH v3 0/5] Add a vhost RPMsg API

2020-05-29 Thread Jason Wang
On 2020/5/29 下午2:50, Guennadi Liakhovetski wrote: Hi Jason, On Fri, May 29, 2020 at 02:01:53PM +0800, Jason Wang wrote: On 2020/5/28 上午2:05, Guennadi Liakhovetski wrote: v3: - address several checkpatch warnings - address comments from Mathieu Poirier v2: - update patch #5 with a correct vho

Re: [PATCH v3 0/5] Add a vhost RPMsg API

2020-05-28 Thread Guennadi Liakhovetski
Hi Jason, On Fri, May 29, 2020 at 02:01:53PM +0800, Jason Wang wrote: > > On 2020/5/28 上午2:05, Guennadi Liakhovetski wrote: > > v3: > > - address several checkpatch warnings > > - address comments from Mathieu Poirier > > > > v2: > > - update patch #5 with a correct vhost_dev_init() prototype >

Re: [PATCH v3 0/5] Add a vhost RPMsg API

2020-05-28 Thread Jason Wang
On 2020/5/28 上午2:05, Guennadi Liakhovetski wrote: v3: - address several checkpatch warnings - address comments from Mathieu Poirier v2: - update patch #5 with a correct vhost_dev_init() prototype - drop patch #6 - it depends on a different patch, that is currently an RFC - address comments f

[PATCH v3 0/5] Add a vhost RPMsg API

2020-05-27 Thread Guennadi Liakhovetski
v3: - address several checkpatch warnings - address comments from Mathieu Poirier v2: - update patch #5 with a correct vhost_dev_init() prototype - drop patch #6 - it depends on a different patch, that is currently an RFC - address comments from Pierre-Louis Bossart: * remove "default n" from