Re: [PATCH v3 10/16] zsmalloc: factor page chain functionality out

2016-04-19 Thread Minchan Kim
On Mon, Apr 18, 2016 at 09:33:05AM +0900, Sergey Senozhatsky wrote: > Hello, > > On (03/30/16 16:12), Minchan Kim wrote: > > @@ -1421,7 +1434,6 @@ static unsigned long obj_malloc(struct size_class > > *class, > > unsigned long m_offset; > > void *vaddr; > > > > - handle |= OBJ_ALLOCAT

Re: [PATCH v3 10/16] zsmalloc: factor page chain functionality out

2016-04-17 Thread Sergey Senozhatsky
Hello, On (03/30/16 16:12), Minchan Kim wrote: > @@ -1421,7 +1434,6 @@ static unsigned long obj_malloc(struct size_class > *class, > unsigned long m_offset; > void *vaddr; > > - handle |= OBJ_ALLOCATED_TAG; a nitpick, why did you replace this ALLOCATED_TAG assignment with 2 'ha

[PATCH v3 10/16] zsmalloc: factor page chain functionality out

2016-03-30 Thread Minchan Kim
For migration, we need to create sub-page chain of zspage dynamically so this patch factors it out from alloc_zspage. As a minor refactoring, it makes OBJ_ALLOCATED_TAG assign more clear in obj_malloc(it could be another patch but it's trivial so I want to put together in this patch). Signed-off-