Re: [PATCH v3 2/3] virtio-net: Introduce RSS receive steering feature

2020-03-02 Thread Michael S. Tsirkin
On Mon, Mar 02, 2020 at 12:58:34PM +0200, Yuri Benditovich wrote: > All the classes of commands are defined without indentation. > All the commands are defined with indentation of 1 space. > Only the last one (VIRTIO_NET_CTRL_GUEST_OFFLOADS_SET at the end of > the file) does not have an

Re: [PATCH v3 2/3] virtio-net: Introduce RSS receive steering feature

2020-03-02 Thread Yuri Benditovich
All the classes of commands are defined without indentation. All the commands are defined with indentation of 1 space. Only the last one (VIRTIO_NET_CTRL_GUEST_OFFLOADS_SET at the end of the file) does not have an indentation. On Mon, Mar 2, 2020 at 12:54 PM Michael S. Tsirkin wrote: > > On Mon,

Re: [PATCH v3 2/3] virtio-net: Introduce RSS receive steering feature

2020-03-02 Thread Michael S. Tsirkin
On Mon, Mar 02, 2020 at 10:53:14AM +0200, Yuri Benditovich wrote: > On Sun, Mar 1, 2020 at 9:58 PM Michael S. Tsirkin wrote: > > > > On Sun, Mar 01, 2020 at 04:33:01PM +0200, Yuri Benditovich wrote: > > > RSS (Receive-side scaling) defines hash calculation > > > rules and decision on receive

Re: [PATCH v3 2/3] virtio-net: Introduce RSS receive steering feature

2020-03-02 Thread Yuri Benditovich
On Sun, Mar 1, 2020 at 9:58 PM Michael S. Tsirkin wrote: > > On Sun, Mar 01, 2020 at 04:33:01PM +0200, Yuri Benditovich wrote: > > RSS (Receive-side scaling) defines hash calculation > > rules and decision on receive virtqueue according to > > the calculated hash, provided mask to apply and > >

Re: [PATCH v3 2/3] virtio-net: Introduce RSS receive steering feature

2020-03-01 Thread Michael S. Tsirkin
On Sun, Mar 01, 2020 at 04:33:01PM +0200, Yuri Benditovich wrote: > RSS (Receive-side scaling) defines hash calculation > rules and decision on receive virtqueue according to > the calculated hash, provided mask to apply and > provided indirection table containing indices of > receive virqueues.

[PATCH v3 2/3] virtio-net: Introduce RSS receive steering feature

2020-03-01 Thread Yuri Benditovich
RSS (Receive-side scaling) defines hash calculation rules and decision on receive virtqueue according to the calculated hash, provided mask to apply and provided indirection table containing indices of receive virqueues. The driver sends the control command to enable multiqueue and provide