Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-08-03 Thread Rafael Aquini
On Mon, Jul 23, 2012 at 11:33:32AM +0900, Minchan Kim wrote: Look at memory-hotplug, offline_page calls has_unmovable_pages, scan_lru_pages and do_migrate_range which calls isolate_lru_page. They consider only LRU pages to migratable ones. As promised, I looked into those bits. Yes, they

Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-08-01 Thread Rik van Riel
On 07/22/2012 10:33 PM, Minchan Kim wrote: IMHO, better approach is that after we can get complete free pageblocks by compaction or reclaim, move balloon pages into that pageblocks and make that blocks to unmovable. It can prevent fragmentation and it makes current or future code don't need to

Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-08-01 Thread Rik van Riel
On 07/23/2012 02:19 PM, Rafael Aquini wrote: In a glance, I believe this whole dance you're suggesting might just be too much of an overcomplication, and the best approach would be simply teaching the hotplug bits about the ballooned corner case just like it's being done to

Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-07-23 Thread Rafael Aquini
On Mon, Jul 23, 2012 at 11:33:32AM +0900, Minchan Kim wrote: Hi Rafael, On Fri, Jul 20, 2012 at 04:48:59PM -0300, Rafael Aquini wrote: Howdy Minchan, Once again, thanks for raising such valuable feedback over here. On Wed, Jul 18, 2012 at 02:48:24PM +0900, Minchan Kim wrote:

Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-07-23 Thread Minchan Kim
On Mon, Jul 23, 2012 at 11:33:32AM +0900, Minchan Kim wrote: Hi Rafael, On Fri, Jul 20, 2012 at 04:48:59PM -0300, Rafael Aquini wrote: Howdy Minchan, Once again, thanks for raising such valuable feedback over here. On Wed, Jul 18, 2012 at 02:48:24PM +0900, Minchan Kim wrote:

Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-07-20 Thread Rafael Aquini
Howdy Minchan, Once again, thanks for raising such valuable feedback over here. On Wed, Jul 18, 2012 at 02:48:24PM +0900, Minchan Kim wrote: +/* __isolate_lru_page() counterpart for a ballooned page */ +static bool isolate_balloon_page(struct page *page) +{ + if

Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-07-18 Thread Minchan Kim
Hi Rafael, On Tue, Jul 17, 2012 at 01:50:41PM -0300, Rafael Aquini wrote: This patch introduces the helper functions as well as the necessary changes to teach compaction and migration bits how to cope with pages which are part of a guest memory balloon, in order to make them movable by memory

Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-07-18 Thread Andrew Morton
On Tue, 17 Jul 2012 13:50:41 -0300 Rafael Aquini aqu...@redhat.com wrote: This patch introduces the helper functions as well as the necessary changes to teach compaction and migration bits how to cope with pages which are part of a guest memory balloon, in order to make them movable by memory

Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-07-18 Thread Rafael Aquini
Howdy Andrew, Thanks for taking the time to go through this work and provide me with such good feedback. On Wed, Jul 18, 2012 at 03:46:05PM -0700, Andrew Morton wrote: On Tue, 17 Jul 2012 13:50:41 -0300 Rafael Aquini aqu...@redhat.com wrote: This patch introduces the helper functions as

Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-07-18 Thread Andrew Morton
On Wed, 18 Jul 2012 20:07:07 -0300 Rafael Aquini aqu...@redhat.com wrote: +} +#else +static inline bool is_balloon_page(struct page *page) { return false; } +static inline bool isolate_balloon_page(struct page *page) { return false; } +static inline bool

Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-07-18 Thread Rafael Aquini
On Wed, Jul 18, 2012 at 04:12:39PM -0700, Andrew Morton wrote: On Wed, 18 Jul 2012 20:07:07 -0300 Rafael Aquini aqu...@redhat.com wrote: +} +#else +static inline bool is_balloon_page(struct page *page) { return false; } +static inline bool

Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-07-18 Thread Andrew Morton
On Wed, 18 Jul 2012 22:00:48 -0300 Rafael Aquini aqu...@redhat.com wrote: So the function needs a better name - one which communicates that it is a balloon page *for the purposes of processing by the compaction code*. Making the function private to compaction.c would help with that, if

[PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-07-17 Thread Rafael Aquini
This patch introduces the helper functions as well as the necessary changes to teach compaction and migration bits how to cope with pages which are part of a guest memory balloon, in order to make them movable by memory compaction procedures. Signed-off-by: Rafael Aquini aqu...@redhat.com ---