Re: [PATCH v4 11/12] drm/virtio: switch from ttm to gem shmem helpers

2019-06-30 Thread Chia-I Wu
On Fri, Jun 28, 2019 at 3:49 AM Gerd Hoffmann wrote: > > > > static inline struct virtio_gpu_object* > > > virtio_gpu_object_ref(struct virtio_gpu_object *bo) > > > The last users of these two helpers are removed with this patch. We > > can remove them. > > patch 12/12 does that. I meant virtio

Re: [PATCH v4 11/12] drm/virtio: switch from ttm to gem shmem helpers

2019-06-28 Thread Gerd Hoffmann
> > static inline struct virtio_gpu_object* > > virtio_gpu_object_ref(struct virtio_gpu_object *bo) > The last users of these two helpers are removed with this patch. We > can remove them. patch 12/12 does that. > > + bo = gem_to_virtio_gpu_obj(&shmem_obj->base); > > + bo->base.ba

Re: [PATCH v4 11/12] drm/virtio: switch from ttm to gem shmem helpers

2019-06-26 Thread Chia-I Wu
. On Wed, Jun 19, 2019 at 11:08 PM Gerd Hoffmann wrote: > > virtio-gpu basically needs a sg_table for the bo, to tell the host where > the backing pages for the object are. So the gem shmem helpers are a > perfect fit. Some drm_gem_object_funcs need thin wrappers to update the > host state, but

[PATCH v4 11/12] drm/virtio: switch from ttm to gem shmem helpers

2019-06-19 Thread Gerd Hoffmann
virtio-gpu basically needs a sg_table for the bo, to tell the host where the backing pages for the object are. So the gem shmem helpers are a perfect fit. Some drm_gem_object_funcs need thin wrappers to update the host state, but otherwise the helpers handle everything just fine. Once the fencin