Re: RFC [PATCH v4 2/7] Enable balloon drivers to report inflated memory

2022-10-14 Thread David Hildenbrand
Other problem is that there are drivers that do not use adjust_managed_page_count(). Which ones? Do we care? VMWare and Virtio balloon drivers. I recently proposed to unify them and the objection was that it would break existing users - which is valid so we must care i guess. I'm confused,

Re: RFC [PATCH v4 2/7] Enable balloon drivers to report inflated memory

2022-10-14 Thread David Hildenbrand
On 14.10.22 14:50, Alexander Atanasov wrote: Hello, On 11.10.22 12:23, David Hildenbrand wrote: Sounds to me that all you want is some notifier to be called from adjust_managed_page_count(). What am I missing? Notifier will act as an accumulator to report size of change and it will make thing

Re: RFC [PATCH v4 2/7] Enable balloon drivers to report inflated memory

2022-10-11 Thread David Hildenbrand
Sounds to me that all you want is some notifier to be called from adjust_managed_page_count(). What am I missing? Notifier will act as an accumulator to report size of change and it will make things easier for the drivers and users wrt locking. Notifier is similar to the memory hotplug notifier

Re: RFC [PATCH v4 2/7] Enable balloon drivers to report inflated memory

2022-10-10 Thread Nadav Amit
On Oct 10, 2022, at 12:24 AM, Alexander Atanasov wrote: > Hello, > > On 10.10.22 9:18, Nadav Amit wrote: >> On Oct 7, 2022, at 3:58 AM, Alexander Atanasov >> wrote: >>> So all balloon drivers give large amount of RAM on boot , then inflate the >>> balloon. But this places have already been i

Re: RFC [PATCH v4 2/7] Enable balloon drivers to report inflated memory

2022-10-09 Thread Nadav Amit
On Oct 7, 2022, at 3:58 AM, Alexander Atanasov wrote: > On 7.10.22 0:07, Nadav Amit wrote: I was looking through the series and I did not see actual users of the notifier. Usually, it is not great to build an API without users. >>> >>> >>> You are right. I hope to get some feed

Re: [PATCH v4 2/7] Enable balloon drivers to report inflated memory

2022-10-06 Thread Nadav Amit
On Oct 6, 2022, at 12:34 AM, Alexander Atanasov wrote: > Hello, > > > On 5.10.22 20:25, Nadav Amit wrote: >> On Oct 5, 2022, at 2:01 AM, Alexander Atanasov >> wrote: >>> Add counters to be updated by the balloon drivers. >>> Create balloon notifier to propagate changes. >> I missed the other

Re: [PATCH v4 2/7] Enable balloon drivers to report inflated memory

2022-10-05 Thread Nadav Amit
On Oct 5, 2022, at 2:01 AM, Alexander Atanasov wrote: > Add counters to be updated by the balloon drivers. > Create balloon notifier to propagate changes. I missed the other patches before (including this one). Sorry, but next time, please cc me. I was looking through the series and I did not