Re: [PATCH v5 3/6] libnvdimm: add dax_dev sync flag

2019-04-11 Thread Pankaj Gupta
Hi Dan, Thank you for the review. > > > > This patch adds 'DAXDEV_SYNC' flag which is set > > for nd_region doing synchronous flush. This later > > is used to disable MAP_SYNC functionality for > > ext4 & xfs filesystem for devices don't support > > synchronous flush. > > > > Signed-off-by: Pan

Re: [PATCH v5 3/6] libnvdimm: add dax_dev sync flag

2019-04-11 Thread Dan Williams
On Tue, Apr 9, 2019 at 9:10 PM Pankaj Gupta wrote: > > This patch adds 'DAXDEV_SYNC' flag which is set > for nd_region doing synchronous flush. This later > is used to disable MAP_SYNC functionality for > ext4 & xfs filesystem for devices don't support > synchronous flush. > > Signed-off-by: Panka

Re: [PATCH v5 3/6] libnvdimm: add dax_dev sync flag

2019-04-10 Thread Pankaj Gupta
> > On Wed 10-04-19 09:38:23, Pankaj Gupta wrote: > > @@ -64,6 +65,10 @@ static inline bool dax_write_cache_enabled(struct > > dax_device *dax_dev) > > { > > return false; > > } > > +static inline bool dax_synchronous(struct dax_device *dax_dev) > > +{ > > + return true; > > +} > > Is t

Re: [PATCH v5 3/6] libnvdimm: add dax_dev sync flag

2019-04-10 Thread Jan Kara
On Wed 10-04-19 09:38:23, Pankaj Gupta wrote: > @@ -64,6 +65,10 @@ static inline bool dax_write_cache_enabled(struct > dax_device *dax_dev) > { > return false; > } > +static inline bool dax_synchronous(struct dax_device *dax_dev) > +{ > + return true; > +} Is there a need to define da

[PATCH v5 3/6] libnvdimm: add dax_dev sync flag

2019-04-09 Thread Pankaj Gupta
This patch adds 'DAXDEV_SYNC' flag which is set for nd_region doing synchronous flush. This later is used to disable MAP_SYNC functionality for ext4 & xfs filesystem for devices don't support synchronous flush. Signed-off-by: Pankaj Gupta --- drivers/dax/bus.c| 2 +- drivers/dax/sup