Re: [PATCH v6] virtio: add VIRTIO_F_NOTIFICATION_DATA feature support

2023-04-13 Thread Alvaro Karsz
> Hmm. So it seems we need to first apply yours then this patch, > is that right? Or the other way around? What is the right way to make it not > break bisect? > Do you mind including this patch with yours in a patchset > in the correct order? Ok, I'll create a patchset. Thanks,

Re: [PATCH v6] virtio: add VIRTIO_F_NOTIFICATION_DATA feature support

2023-04-07 Thread Alvaro Karsz
> > This function is used by virtio_vdpa as well > > (drivers/virtio/virtio_vdpa.c:virtio_vdpa_finalize_features). > > A vDPA device can offer this feature and it will be accepted, even though > > VIRTIO_F_NOTIFICATION_DATA is not a thing for the vDPA transport at the > > moment. > > > > I

Re: [PATCH v6] virtio: add VIRTIO_F_NOTIFICATION_DATA feature support

2023-04-04 Thread Michael S. Tsirkin
On Sun, Apr 02, 2023 at 08:17:49AM +, Alvaro Karsz wrote: > Hi Viktor, > > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > > index 4c3bb0ddeb9b..f9c6604352b4 100644 > > --- a/drivers/virtio/virtio_ring.c > > +++ b/drivers/virtio/virtio_ring.c > > @@ -2752,6

Re: [PATCH v6] virtio: add VIRTIO_F_NOTIFICATION_DATA feature support

2023-04-02 Thread Alvaro Karsz
Hi Viktor, > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > index 4c3bb0ddeb9b..f9c6604352b4 100644 > --- a/drivers/virtio/virtio_ring.c > +++ b/drivers/virtio/virtio_ring.c > @@ -2752,6 +2752,23 @@ void vring_del_virtqueue(struct virtqueue *_vq) > } >

Re: [PATCH v6] virtio: add VIRTIO_F_NOTIFICATION_DATA feature support

2023-03-29 Thread Xuan Zhuo
On Thu, 30 Mar 2023 01:49:23 +0300, Viktor Prutyanov wrote: > On Fri, Mar 24, 2023 at 10:50 PM Viktor Prutyanov wrote: > > > > According to VirtIO spec v1.2, VIRTIO_F_NOTIFICATION_DATA feature > > indicates that the driver passes extra data along with the queue > > notifications. > > > > In a