Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-08-09 Thread Xuan Zhuo
On Thu, 10 Aug 2023 02:39:47 -0400, "Michael S. Tsirkin" wrote: > On Thu, Aug 10, 2023 at 09:56:54AM +0800, Xuan Zhuo wrote: > > > > Ping!! > > > > Could we push this to the next linux version? > > > > Thanks. > > You sent v12, so not this one for sure. > v12 triggered kbuild warnings, you need t

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-08-09 Thread Michael S. Tsirkin
On Thu, Aug 10, 2023 at 02:37:20PM +0800, Jason Wang wrote: > On Thu, Aug 10, 2023 at 9:59 AM Xuan Zhuo wrote: > > > > > > Ping!! > > > > Could we push this to the next linux version? > > How about implementing the wrappers along with virtqueue_dma_dev() to > see if Christoph is happy? > > Thank

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-08-09 Thread Michael S. Tsirkin
On Thu, Aug 10, 2023 at 09:56:54AM +0800, Xuan Zhuo wrote: > > Ping!! > > Could we push this to the next linux version? > > Thanks. You sent v12, so not this one for sure. v12 triggered kbuild warnings, you need to fix them and repost. Note that I'm on vacation from monday, so if you want this

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-08-09 Thread Jason Wang
On Thu, Aug 10, 2023 at 9:59 AM Xuan Zhuo wrote: > > > Ping!! > > Could we push this to the next linux version? How about implementing the wrappers along with virtqueue_dma_dev() to see if Christoph is happy? Thanks > > Thanks. > ___ Virtualization m

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-08-09 Thread Xuan Zhuo
Ping!! Could we push this to the next linux version? Thanks. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-08-07 Thread Xuan Zhuo
On Tue, 8 Aug 2023 11:59:04 +0800, Jason Wang wrote: > On Tue, Aug 8, 2023 at 11:57 AM Xuan Zhuo wrote: > > > > On Tue, 8 Aug 2023 11:49:08 +0800, Jason Wang wrote: > > > On Tue, Aug 8, 2023 at 11:12 AM Xuan Zhuo > > > wrote: > > > > > > > > On Tue, 8 Aug 2023 11:08:09 +0800, Jason Wang > >

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-08-07 Thread Jason Wang
On Tue, Aug 8, 2023 at 11:57 AM Xuan Zhuo wrote: > > On Tue, 8 Aug 2023 11:49:08 +0800, Jason Wang wrote: > > On Tue, Aug 8, 2023 at 11:12 AM Xuan Zhuo > > wrote: > > > > > > On Tue, 8 Aug 2023 11:08:09 +0800, Jason Wang wrote: > > > > On Tue, Aug 8, 2023 at 10:52 AM Xuan Zhuo > > > > wrote:

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-08-07 Thread Xuan Zhuo
On Tue, 8 Aug 2023 11:49:08 +0800, Jason Wang wrote: > On Tue, Aug 8, 2023 at 11:12 AM Xuan Zhuo wrote: > > > > On Tue, 8 Aug 2023 11:08:09 +0800, Jason Wang wrote: > > > On Tue, Aug 8, 2023 at 10:52 AM Xuan Zhuo > > > wrote: > > > > > > > > On Tue, 8 Aug 2023 10:26:04 +0800, Jason Wang > >

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-08-07 Thread Jason Wang
On Tue, Aug 8, 2023 at 11:12 AM Xuan Zhuo wrote: > > On Tue, 8 Aug 2023 11:08:09 +0800, Jason Wang wrote: > > On Tue, Aug 8, 2023 at 10:52 AM Xuan Zhuo > > wrote: > > > > > > On Tue, 8 Aug 2023 10:26:04 +0800, Jason Wang wrote: > > > > On Mon, Aug 7, 2023 at 2:15 PM Xuan Zhuo > > > > wrote:

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-08-07 Thread Xuan Zhuo
On Tue, 8 Aug 2023 11:08:09 +0800, Jason Wang wrote: > On Tue, Aug 8, 2023 at 10:52 AM Xuan Zhuo wrote: > > > > On Tue, 8 Aug 2023 10:26:04 +0800, Jason Wang wrote: > > > On Mon, Aug 7, 2023 at 2:15 PM Xuan Zhuo > > > wrote: > > > > > > > > On Wed, 2 Aug 2023 09:49:31 +0800, Xuan Zhuo > > > >

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-08-07 Thread Jason Wang
On Tue, Aug 8, 2023 at 10:52 AM Xuan Zhuo wrote: > > On Tue, 8 Aug 2023 10:26:04 +0800, Jason Wang wrote: > > On Mon, Aug 7, 2023 at 2:15 PM Xuan Zhuo wrote: > > > > > > On Wed, 2 Aug 2023 09:49:31 +0800, Xuan Zhuo > > > wrote: > > > > On Tue, 1 Aug 2023 12:17:47 -0400, "Michael S. Tsirkin" >

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-08-07 Thread Xuan Zhuo
On Tue, 8 Aug 2023 10:26:04 +0800, Jason Wang wrote: > On Mon, Aug 7, 2023 at 2:15 PM Xuan Zhuo wrote: > > > > On Wed, 2 Aug 2023 09:49:31 +0800, Xuan Zhuo > > wrote: > > > On Tue, 1 Aug 2023 12:17:47 -0400, "Michael S. Tsirkin" > > > wrote: > > > > On Fri, Jul 28, 2023 at 02:02:33PM +0800, X

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-08-07 Thread Jason Wang
On Mon, Aug 7, 2023 at 2:15 PM Xuan Zhuo wrote: > > On Wed, 2 Aug 2023 09:49:31 +0800, Xuan Zhuo > wrote: > > On Tue, 1 Aug 2023 12:17:47 -0400, "Michael S. Tsirkin" > > wrote: > > > On Fri, Jul 28, 2023 at 02:02:33PM +0800, Xuan Zhuo wrote: > > > > On Tue, 25 Jul 2023 19:07:23 +0800, Xuan Zhu

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-08-06 Thread Xuan Zhuo
On Wed, 2 Aug 2023 09:49:31 +0800, Xuan Zhuo wrote: > On Tue, 1 Aug 2023 12:17:47 -0400, "Michael S. Tsirkin" > wrote: > > On Fri, Jul 28, 2023 at 02:02:33PM +0800, Xuan Zhuo wrote: > > > On Tue, 25 Jul 2023 19:07:23 +0800, Xuan Zhuo > > > wrote: > > > > On Tue, 25 Jul 2023 03:34:34 -0400, "Mi

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-08-01 Thread Xuan Zhuo
On Tue, 1 Aug 2023 12:17:47 -0400, "Michael S. Tsirkin" wrote: > On Fri, Jul 28, 2023 at 02:02:33PM +0800, Xuan Zhuo wrote: > > On Tue, 25 Jul 2023 19:07:23 +0800, Xuan Zhuo > > wrote: > > > On Tue, 25 Jul 2023 03:34:34 -0400, "Michael S. Tsirkin" > > > wrote: > > > > On Tue, Jul 25, 2023 at 1

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-08-01 Thread Xuan Zhuo
On Tue, 1 Aug 2023 08:45:10 -0700, Jakub Kicinski wrote: > On Tue, 1 Aug 2023 10:57:30 +0800 Xuan Zhuo wrote: > > > You have this working and benchmarked or this is just and idea? > > > > This is not just an idea. I said that has been used on large scale. > > > > This is the library for the APP to

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-08-01 Thread Michael S. Tsirkin
On Fri, Jul 28, 2023 at 02:02:33PM +0800, Xuan Zhuo wrote: > On Tue, 25 Jul 2023 19:07:23 +0800, Xuan Zhuo > wrote: > > On Tue, 25 Jul 2023 03:34:34 -0400, "Michael S. Tsirkin" > > wrote: > > > On Tue, Jul 25, 2023 at 10:13:48AM +0800, Xuan Zhuo wrote: > > > > On Mon, 24 Jul 2023 09:43:42 -0700

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-07-31 Thread Xuan Zhuo
On Mon, 31 Jul 2023 19:36:06 -0700, Jakub Kicinski wrote: > On Tue, 1 Aug 2023 10:03:44 +0800 Xuan Zhuo wrote: > > > Virtio is either a SW > > > construct or offloaded to very capable HW, so either way cost of > > > creating an extra instance for DPDK or whatever else is very low. > > > > The extr

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-07-31 Thread Xuan Zhuo
On Mon, 31 Jul 2023 08:46:51 -0700, Jakub Kicinski wrote: > On Mon, 31 Jul 2023 09:23:29 +0800 Jason Wang wrote: > > > I'd step back and ask you why do you want to use AF_XDP with virtio. > > > Instead of bifurcating one virtio instance into different queues why > > > not create a separate virtio

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-07-30 Thread Xuan Zhuo
On Fri, 28 Jul 2023 08:03:05 -0700, Jakub Kicinski wrote: > On Fri, 28 Jul 2023 14:02:33 +0800 Xuan Zhuo wrote: > > Hi guys, this topic is stuck again. How should I proceed with this work? > > > > Let me briefly summarize: > > 1. The problem with adding virtio_dma_{map, sync} api is that, for AF_X

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-07-30 Thread Jason Wang
On Fri, Jul 28, 2023 at 11:03 PM Jakub Kicinski wrote: > > On Fri, 28 Jul 2023 14:02:33 +0800 Xuan Zhuo wrote: > > Hi guys, this topic is stuck again. How should I proceed with this work? > > > > Let me briefly summarize: > > 1. The problem with adding virtio_dma_{map, sync} api is that, for AF_XD

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-07-27 Thread Xuan Zhuo
On Tue, 25 Jul 2023 19:07:23 +0800, Xuan Zhuo wrote: > On Tue, 25 Jul 2023 03:34:34 -0400, "Michael S. Tsirkin" > wrote: > > On Tue, Jul 25, 2023 at 10:13:48AM +0800, Xuan Zhuo wrote: > > > On Mon, 24 Jul 2023 09:43:42 -0700, Christoph Hellwig > > > wrote: > > > > On Thu, Jul 20, 2023 at 01:2

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-07-25 Thread Xuan Zhuo
On Tue, 25 Jul 2023 03:34:34 -0400, "Michael S. Tsirkin" wrote: > On Tue, Jul 25, 2023 at 10:13:48AM +0800, Xuan Zhuo wrote: > > On Mon, 24 Jul 2023 09:43:42 -0700, Christoph Hellwig > > wrote: > > > On Thu, Jul 20, 2023 at 01:21:07PM -0400, Michael S. Tsirkin wrote: > > > > Well I think we can

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-07-25 Thread Michael S. Tsirkin
On Tue, Jul 25, 2023 at 10:13:48AM +0800, Xuan Zhuo wrote: > On Mon, 24 Jul 2023 09:43:42 -0700, Christoph Hellwig > wrote: > > On Thu, Jul 20, 2023 at 01:21:07PM -0400, Michael S. Tsirkin wrote: > > > Well I think we can add wrappers like virtio_dma_sync and so on. > > > There are NOP for non-dm

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-07-24 Thread Xuan Zhuo
On Mon, 24 Jul 2023 09:43:42 -0700, Christoph Hellwig wrote: > On Thu, Jul 20, 2023 at 01:21:07PM -0400, Michael S. Tsirkin wrote: > > Well I think we can add wrappers like virtio_dma_sync and so on. > > There are NOP for non-dma so passing the dma device is harmless. > > Yes, please. I am not

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-07-24 Thread Michael S. Tsirkin
On Thu, Jul 20, 2023 at 03:34:01PM +0800, Xuan Zhuo wrote: > On Wed, 19 Jul 2023 23:57:51 -0700, Christoph Hellwig > wrote: > > On Thu, Jul 20, 2023 at 02:45:14PM +0800, Xuan Zhuo wrote: > > > virtqueue_dma_dev() return the device that working with the DMA APIs. > > > Then that can be used like

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-07-24 Thread Christoph Hellwig
On Thu, Jul 20, 2023 at 01:21:07PM -0400, Michael S. Tsirkin wrote: > Well I think we can add wrappers like virtio_dma_sync and so on. > There are NOP for non-dma so passing the dma device is harmless. Yes, please. ___ Virtualization mailing list Virtual

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-07-20 Thread Michael S. Tsirkin
On Wed, Jul 19, 2023 at 11:22:42PM -0700, Christoph Hellwig wrote: > On Thu, Jul 13, 2023 at 10:51:59AM -0400, Michael S. Tsirkin wrote: > > On Thu, Jul 13, 2023 at 04:15:16AM -0700, Christoph Hellwig wrote: > > > On Mon, Jul 10, 2023 at 11:42:32AM +0800, Xuan Zhuo wrote: > > > > Added virtqueue_dm

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-07-20 Thread Xuan Zhuo
On Wed, 19 Jul 2023 23:57:51 -0700, Christoph Hellwig wrote: > On Thu, Jul 20, 2023 at 02:45:14PM +0800, Xuan Zhuo wrote: > > virtqueue_dma_dev() return the device that working with the DMA APIs. > > Then that can be used like other devices. So what is the problem. > > > > I always think the c

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-07-19 Thread Christoph Hellwig
On Thu, Jul 20, 2023 at 02:45:14PM +0800, Xuan Zhuo wrote: > virtqueue_dma_dev() return the device that working with the DMA APIs. > Then that can be used like other devices. So what is the problem. > > I always think the code path without the DMA APIs is the trouble for you. Because we now ha

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-07-19 Thread Christoph Hellwig
On Thu, Jul 13, 2023 at 10:51:59AM -0400, Michael S. Tsirkin wrote: > On Thu, Jul 13, 2023 at 04:15:16AM -0700, Christoph Hellwig wrote: > > On Mon, Jul 10, 2023 at 11:42:32AM +0800, Xuan Zhuo wrote: > > > Added virtqueue_dma_dev() to get DMA device for virtio. Then the > > > caller can do dma oper

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-07-19 Thread Xuan Zhuo
On Wed, 19 Jul 2023 23:22:42 -0700, Christoph Hellwig wrote: > On Thu, Jul 13, 2023 at 10:51:59AM -0400, Michael S. Tsirkin wrote: > > On Thu, Jul 13, 2023 at 04:15:16AM -0700, Christoph Hellwig wrote: > > > On Mon, Jul 10, 2023 at 11:42:32AM +0800, Xuan Zhuo wrote: > > > > Added virtqueue_dma_de

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-07-13 Thread Michael S. Tsirkin
On Thu, Jul 13, 2023 at 04:15:16AM -0700, Christoph Hellwig wrote: > On Mon, Jul 10, 2023 at 11:42:32AM +0800, Xuan Zhuo wrote: > > Added virtqueue_dma_dev() to get DMA device for virtio. Then the > > caller can do dma operation in advance. The purpose is to keep memory > > mapped across multiple a

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-07-13 Thread Christoph Hellwig
On Mon, Jul 10, 2023 at 11:42:32AM +0800, Xuan Zhuo wrote: > Added virtqueue_dma_dev() to get DMA device for virtio. Then the > caller can do dma operation in advance. The purpose is to keep memory > mapped across multiple add/get buf operations. This is just poking holes into the abstraction.. _

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-07-12 Thread Jason Wang
On Mon, Jul 10, 2023 at 11:42 AM Xuan Zhuo wrote: > > Added virtqueue_dma_dev() to get DMA device for virtio. Then the > caller can do dma operation in advance. The purpose is to keep memory > mapped across multiple add/get buf operations. > > Signed-off-by: Xuan Zhuo Acked-by: Jason Wang Than

[PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-07-09 Thread Xuan Zhuo
Added virtqueue_dma_dev() to get DMA device for virtio. Then the caller can do dma operation in advance. The purpose is to keep memory mapped across multiple add/get buf operations. Signed-off-by: Xuan Zhuo --- drivers/virtio/virtio_ring.c | 17 + include/linux/virtio.h |