From: "Michael S. Tsirkin"
Date: Thu, 1 Nov 2012 18:16:11 +0200
> Do you think it's over-engineering, or a good idea?
Engineer what you need, not what you might need.
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lis
On Thu, Nov 01, 2012 at 11:50:24AM -0400, David Miller wrote:
> From: "Michael S. Tsirkin"
> Date: Wed, 31 Oct 2012 12:31:06 +0200
>
> > -void vhost_zerocopy_callback(struct ubuf_info *ubuf)
> > +void vhost_zerocopy_callback(struct ubuf_info *ubuf, int zerocopy_status)
>
> If you're only reporti
From: "Michael S. Tsirkin"
Date: Wed, 31 Oct 2012 12:31:06 +0200
> -void vhost_zerocopy_callback(struct ubuf_info *ubuf)
> +void vhost_zerocopy_callback(struct ubuf_info *ubuf, int zerocopy_status)
If you're only reporting true/false values, even just for now,
please use 'bool' for this.
___
Even if skb is marked for zero copy, net core might still decide
to copy it later which is somewhat slower than a copy in user context:
besides copying the data we need to pin/unpin the pages.
Add a parameter reporting such cases through zero copy callback:
if this happens a lot, device can take t