Re: Wrappers for vringh (was Re: [PATCHv2 vringh 1/3] remoteproc: Add support for vringh (Host vrings))

2013-03-02 Thread Ohad Ben-Cohen
On Thu, Feb 28, 2013 at 5:19 AM, Rusty Russell wrote: >> diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h >> index 29b9104..ca257d8 100644 >> --- a/include/linux/virtio_config.h >> +++ b/include/linux/virtio_config.h >> @@ -53,0 +54,8 @@ >> + * @find_vrh: find the host vr

Re: Wrappers for vringh (was Re: [PATCHv2 vringh 1/3] remoteproc: Add support for vringh (Host vrings))

2013-02-27 Thread Rusty Russell
Sjur Brændeland writes: > On Fri, Feb 22, 2013 at 1:42 AM, Rusty Russell wrote: >> Ohad Ben-Cohen writes: >>> On Thu, Feb 21, 2013 at 8:37 AM, Rusty Russell >>> wrote: >>> What do you think about creating some virtio-level wrappers for the >>> vringh handlers? >>> >>> I don't think we're going

Wrappers for vringh (was Re: [PATCHv2 vringh 1/3] remoteproc: Add support for vringh (Host vrings))

2013-02-27 Thread Sjur Brændeland
On Fri, Feb 22, 2013 at 1:42 AM, Rusty Russell wrote: > Ohad Ben-Cohen writes: >> On Thu, Feb 21, 2013 at 8:37 AM, Rusty Russell wrote: >> What do you think about creating some virtio-level wrappers for the >> vringh handlers? >> >> I don't think we're going to stop with caif as the only vringh

Re: [PATCHv2 vringh 1/3] remoteproc: Add support for vringh (Host vrings)

2013-02-25 Thread Rusty Russell
Ohad Ben-Cohen writes: > On Thu, Feb 21, 2013 at 8:37 AM, Rusty Russell wrote: >> Hmm... I clearly jumped the gun, assuming consensus was already reached. >> I have put these patches *back* into pending-rebases, and they will not >> be merged this merge window. > > Thanks. > > What do you think a

Re: [PATCHv2 vringh 1/3] remoteproc: Add support for vringh (Host vrings)

2013-02-23 Thread Ohad Ben-Cohen
On Thu, Feb 21, 2013 at 9:36 PM, Sjur Brændeland wrote: > OK, We did carefully consider using the normal vrings, but concluded it was > not doable. I'll try to give you some of the background that I can > recall from top of my head. > (I can dig out more if you're still not convinced :) > > The mo

Re: [PATCHv2 vringh 1/3] remoteproc: Add support for vringh (Host vrings)

2013-02-21 Thread Sjur Brændeland
Hi Ohad, On Thu, Feb 21, 2013 at 6:55 PM, Ohad Ben-Cohen wrote: > On Thu, Feb 21, 2013 at 7:28 PM, Sjur Brændeland wrote: >> The motivation for using vringh was to avoid copying buffers >> when sending data from the modem to the host. > > I may be missing something here, but why do you need vrin

Re: [PATCHv2 vringh 1/3] remoteproc: Add support for vringh (Host vrings)

2013-02-21 Thread Ohad Ben-Cohen
Hi Sjur, On Thu, Feb 21, 2013 at 7:28 PM, Sjur Brændeland wrote: > The motivation for using vringh was to avoid copying buffers > when sending data from the modem to the host. I may be missing something here, but why do you need vringh for that? With rpmsg (which uses two regular vrings) both e

Re: [PATCHv2 vringh 1/3] remoteproc: Add support for vringh (Host vrings)

2013-02-21 Thread Sjur Brændeland
Hi Ohad, > I was wondering - can you please explain your motivation for using > vringh in caif ? > > We have internally discussed supporting multiple remote processors > talking to each other using rpmsg, and in that scenario using vringh > can considerably simplifies the solution (no need to deci

Re: [PATCHv2 vringh 1/3] remoteproc: Add support for vringh (Host vrings)

2013-02-21 Thread Ohad Ben-Cohen
On Thu, Feb 21, 2013 at 8:37 AM, Rusty Russell wrote: > Hmm... I clearly jumped the gun, assuming consensus was already reached. > I have put these patches *back* into pending-rebases, and they will not > be merged this merge window. Thanks. What do you think about creating some virtio-level wra

Re: [PATCHv2 vringh 1/3] remoteproc: Add support for vringh (Host vrings)

2013-02-21 Thread Ohad Ben-Cohen
On Thu, Feb 21, 2013 at 1:01 AM, Sjur Brændeland wrote: > [Sjur:] >>> How do you see the in-kernel API for this? I would like to see >>> something similar to my previous patches, where we extend >>> the virtqueue API. E.g. something like this: >>> struct virtqueue *vring_new_virtqueueh(...)... > >

Re: [PATCHv2 vringh 1/3] remoteproc: Add support for vringh (Host vrings)

2013-02-20 Thread Rusty Russell
Ohad Ben-Cohen writes: > Hi Sjur, > > On Tue, Feb 12, 2013 at 1:49 PM, wrote: >> From: Sjur Brændeland >> >> Add functions for creating, deleting and kicking host-side virtio rings. >> >> The host ring is not integrated with virtiqueues and cannot be managed >> through virtio-config. > > Is tha

Re: [PATCHv2 vringh 1/3] remoteproc: Add support for vringh (Host vrings)

2013-02-20 Thread Sjur Brændeland
On Wed, Feb 20, 2013 at 5:05 PM, Ohad Ben-Cohen wrote: > Hi Sjur, > > On Tue, Feb 12, 2013 at 1:49 PM, wrote: >> From: Sjur Brændeland >> >> Add functions for creating, deleting and kicking host-side virtio rings. >> >> The host ring is not integrated with virtiqueues and cannot be managed >> t

Re: [PATCHv2 vringh 1/3] remoteproc: Add support for vringh (Host vrings)

2013-02-20 Thread Ohad Ben-Cohen
Hi Sjur, On Tue, Feb 12, 2013 at 1:49 PM, wrote: > From: Sjur Brændeland > > Add functions for creating, deleting and kicking host-side virtio rings. > > The host ring is not integrated with virtiqueues and cannot be managed > through virtio-config. Is that an inherent design/issue of vringh o

[PATCHv2 vringh 1/3] remoteproc: Add support for vringh (Host vrings)

2013-02-12 Thread sjur . brandeland
From: Sjur Brændeland Add functions for creating, deleting and kicking host-side virtio rings. The host ring is not integrated with virtiqueues and cannot be managed through virtio-config. Remoteproc must export functions for handling the host-side virtio rings. The functions rproc_virtio_get_v