Re: [RFC][PATCH] virtio balloon: kill tell-host-first logic

2011-04-18 Thread Rusty Russell
On Thu, 14 Apr 2011 13:30:05 -0700, Dave Hansen d...@linux.vnet.ibm.com wrote: Here's a new commit message: Applied, thanks. Rusty. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org

Re: [RFC][PATCH] virtio balloon: kill tell-host-first logic

2011-04-15 Thread Amit Shah
On (Thu) 14 Apr 2011 [13:28:17], Dave Hansen wrote: On Tue, 2011-04-12 at 22:13 +0530, Amit Shah wrote: On (Tue) 12 Apr 2011 [09:22:32], Dave Hansen wrote: On Tue, 2011-04-12 at 11:13 +0530, Amit Shah wrote: Sure, the only contention was on the commit message, where you stated modern

Re: [RFC][PATCH] virtio balloon: kill tell-host-first logic

2011-04-15 Thread Rusty Russell
On Tue, 12 Apr 2011 09:22:32 -0700, Dave Hansen d...@linux.vnet.ibm.com wrote: On Tue, 2011-04-12 at 11:13 +0530, Amit Shah wrote: Sure, the only contention was on the commit message, where you stated modern qemus set this... qemu doesn't, and it should. Care to do a patch for that? If

Re: [RFC][PATCH] virtio balloon: kill tell-host-first logic

2011-04-14 Thread Dave Hansen
On Tue, 2011-04-12 at 22:13 +0530, Amit Shah wrote: On (Tue) 12 Apr 2011 [09:22:32], Dave Hansen wrote: On Tue, 2011-04-12 at 11:13 +0530, Amit Shah wrote: Sure, the only contention was on the commit message, where you stated modern qemus set this... qemu doesn't, and it should. Care to

Re: [RFC][PATCH] virtio balloon: kill tell-host-first logic

2011-04-14 Thread Dave Hansen
On Thu, 2011-04-14 at 21:07 +0930, Rusty Russell wrote: On Tue, 12 Apr 2011 09:22:32 -0700, Dave Hansen d...@linux.vnet.ibm.com wrote: On Tue, 2011-04-12 at 11:13 +0530, Amit Shah wrote: Sure, the only contention was on the commit message, where you stated modern qemus set this... qemu

Re: [RFC][PATCH] virtio balloon: kill tell-host-first logic

2011-04-12 Thread Dave Hansen
On Tue, 2011-04-12 at 11:13 +0530, Amit Shah wrote: Sure, the only contention was on the commit message, where you stated modern qemus set this... qemu doesn't, and it should. Care to do a patch for that? If Rusty hasn't pushed the commit out anywhere, we can still amend the commit.

Re: [RFC][PATCH] virtio balloon: kill tell-host-first logic

2011-04-12 Thread Amit Shah
On (Tue) 12 Apr 2011 [09:22:32], Dave Hansen wrote: On Tue, 2011-04-12 at 11:13 +0530, Amit Shah wrote: Sure, the only contention was on the commit message, where you stated modern qemus set this... qemu doesn't, and it should. Care to do a patch for that? If Rusty hasn't pushed the

Re: [RFC][PATCH] virtio balloon: kill tell-host-first logic

2011-04-11 Thread Michael S. Tsirkin
On Thu, Apr 07, 2011 at 10:43:25AM -0700, Dave Hansen wrote: The virtio balloon driver has a VIRTIO_BALLOON_F_MUST_TELL_HOST feature bit. Whenever the bit is set, we must always tell the host before we free pages back to the allocator. Without this we might free a page (and have another

Re: [RFC][PATCH] virtio balloon: kill tell-host-first logic

2011-04-11 Thread Dave Hansen
On Mon, 2011-04-11 at 14:01 +0300, Michael S. Tsirkin wrote: On Thu, Apr 07, 2011 at 10:43:25AM -0700, Dave Hansen wrote: The virtio balloon driver has a VIRTIO_BALLOON_F_MUST_TELL_HOST feature bit. Whenever the bit is set, we must always tell the host before we free pages back to the

Re: [RFC][PATCH] virtio balloon: kill tell-host-first logic

2011-04-11 Thread Amit Shah
On (Mon) 11 Apr 2011 [15:11:11], Dave Hansen wrote: On Mon, 2011-04-11 at 14:01 +0300, Michael S. Tsirkin wrote: On Thu, Apr 07, 2011 at 10:43:25AM -0700, Dave Hansen wrote: The virtio balloon driver has a VIRTIO_BALLOON_F_MUST_TELL_HOST feature bit. Whenever the bit is set, we must

Re: [RFC][PATCH] virtio balloon: kill tell-host-first logic

2011-04-09 Thread Rusty Russell
On Thu, 07 Apr 2011 10:43:25 -0700, Dave Hansen d...@linux.vnet.ibm.com wrote: The virtio balloon driver has a VIRTIO_BALLOON_F_MUST_TELL_HOST feature bit. Whenever the bit is set, we must always tell the host before we free pages back to the allocator. Without this we might free a page

[RFC][PATCH] virtio balloon: kill tell-host-first logic

2011-04-07 Thread Dave Hansen
The virtio balloon driver has a VIRTIO_BALLOON_F_MUST_TELL_HOST feature bit. Whenever the bit is set, we must always tell the host before we free pages back to the allocator. Without this we might free a page (and have another user touch it) while the hypervisor is unprepared for it. But, if