Re: [RFC PATCH] virtio-net: use NETIF_F_GRO_HW instead of NETIF_F_LRO

2021-08-12 Thread Jason Wang
在 2021/8/12 下午12:50, Michael S. Tsirkin 写道: On Thu, Aug 12, 2021 at 11:23:04AM +0800, Jason Wang wrote: 在 2021/8/12 上午6:17, Jakub Kicinski 写道: On Wed, 11 Aug 2021 16:16:23 +0800 Jason Wang wrote: Try to fix this by using NETIF_F_GRO_HW instead so we're not guaranteed to be re-segmented as

Re: [RFC PATCH] virtio-net: use NETIF_F_GRO_HW instead of NETIF_F_LRO

2021-08-11 Thread Michael S. Tsirkin
On Wed, Aug 11, 2021 at 08:20:03PM -0500, ivan wrote: > On Wed, Aug 11, 2021 at 3:16 AM Jason Wang wrote: > > > > Commit a02e8964eaf92 ("virtio-net: ethtool configurable LRO") tries to > > advertise LRO on behalf of the guest offloading features and allow the > > administrator to enable and

Re: [RFC PATCH] virtio-net: use NETIF_F_GRO_HW instead of NETIF_F_LRO

2021-08-11 Thread Michael S. Tsirkin
On Thu, Aug 12, 2021 at 11:23:04AM +0800, Jason Wang wrote: > > 在 2021/8/12 上午6:17, Jakub Kicinski 写道: > > On Wed, 11 Aug 2021 16:16:23 +0800 Jason Wang wrote: > > > Try to fix this by using NETIF_F_GRO_HW instead so we're not > > > guaranteed to be re-segmented as original. > > This sentence may

Re: [RFC PATCH] virtio-net: use NETIF_F_GRO_HW instead of NETIF_F_LRO

2021-08-11 Thread Jason Wang
在 2021/8/12 上午6:17, Jakub Kicinski 写道: On Wed, 11 Aug 2021 16:16:23 +0800 Jason Wang wrote: Try to fix this by using NETIF_F_GRO_HW instead so we're not guaranteed to be re-segmented as original. This sentence may need rephrasing. Right, actually, I meant: Try to fix this by using

[RFC PATCH] virtio-net: use NETIF_F_GRO_HW instead of NETIF_F_LRO

2021-08-11 Thread Jason Wang
Commit a02e8964eaf92 ("virtio-net: ethtool configurable LRO") tries to advertise LRO on behalf of the guest offloading features and allow the administrator to enable and disable those features via ethtool. This may lead several issues: - For the device that doesn't support control guest