Re: [RFC PATCH 1/5] uapi/linux/if_tun.h: Added new ioctl for tun/tap.

2022-02-23 Thread Jason Wang
On Wed, Feb 23, 2022 at 9:31 PM Yuri Benditovich wrote: > > Hi Jason, > We agree that the same can be done also using the old way, i.e. try to > set specific offload - if failed, probably it is not supported. > We think this is a little not scalable and we suggest adding the ioctl > that will

Re: [RFC PATCH 1/5] uapi/linux/if_tun.h: Added new ioctl for tun/tap.

2022-02-23 Thread Yuri Benditovich
Hi Jason, We agree that the same can be done also using the old way, i.e. try to set specific offload - if failed, probably it is not supported. We think this is a little not scalable and we suggest adding the ioctl that will allow us to query allo the supported features in a single call. We think

Re: [RFC PATCH 1/5] uapi/linux/if_tun.h: Added new ioctl for tun/tap.

2022-02-22 Thread Jason Wang
On Tue, Feb 22, 2022 at 9:28 PM Andrew Melnichenko wrote: > > Hi all, > > On Wed, Feb 9, 2022 at 6:26 AM Jason Wang wrote: > > > > > > 在 2022/1/25 下午4:46, Andrew Melnychenko 写道: > > > Added TUNGETSUPPORTEDOFFLOADS that should allow > > > to get bits of supported offloads. > > > > > > So we don't

Re: [RFC PATCH 1/5] uapi/linux/if_tun.h: Added new ioctl for tun/tap.

2022-02-22 Thread Andrew Melnichenko
Hi all, On Wed, Feb 9, 2022 at 6:26 AM Jason Wang wrote: > > > 在 2022/1/25 下午4:46, Andrew Melnychenko 写道: > > Added TUNGETSUPPORTEDOFFLOADS that should allow > > to get bits of supported offloads. > > > So we don't use dedicated ioctls in the past, instead, we just probing > by checking the

Re: [RFC PATCH 1/5] uapi/linux/if_tun.h: Added new ioctl for tun/tap.

2022-02-08 Thread Jason Wang
在 2022/1/25 下午4:46, Andrew Melnychenko 写道: Added TUNGETSUPPORTEDOFFLOADS that should allow to get bits of supported offloads. So we don't use dedicated ioctls in the past, instead, we just probing by checking the return value of TUNSETOFFLOADS. E.g qemu has the following codes: int

[RFC PATCH 1/5] uapi/linux/if_tun.h: Added new ioctl for tun/tap.

2022-01-25 Thread Andrew Melnychenko
Added TUNGETSUPPORTEDOFFLOADS that should allow to get bits of supported offloads. Added 2 additional offlloads for USO(IPv4 & IPv6). Separate offloads are required for Windows VM guests, g.e. Windows may set USO rx only for IPv4. Signed-off-by: Andrew Melnychenko ---