Re: [kvm-devel] [RFC/PATCH 14/15] guest: detect when running on kvm

2008-03-20 Thread Christoph Hellwig
On Thu, Mar 20, 2008 at 05:25:26PM +0100, Carsten Otte wrote: > @@ -143,6 +143,10 @@ static noinline __init void detect_machi > /* Running on a P/390 ? */ > if (cpuinfo->cpu_id.machine == 0x7490) > machine_flags |= 4; > + > + /* Running under KVM ? */ > + if (cpuin

Re: [kvm-devel] [RFC/PATCH 14/15] guest: detect when running on kvm

2008-03-20 Thread Christoph Hellwig
On Thu, Mar 20, 2008 at 09:37:19PM +0100, Carsten Otte wrote: > Christoph Hellwig wrote: >> On Thu, Mar 20, 2008 at 05:25:26PM +0100, Carsten Otte wrote: >>> @@ -143,6 +143,10 @@ static noinline __init void detect_machi >>> /* Running on a P/390 ? */ >>> if (cpuinfo->cpu_id.machine == 0x749

Re: [kvm-devel] [RFC/PATCH 14/15] guest: detect when running on kvm

2008-03-20 Thread Carsten Otte
Christoph Hellwig wrote: > On Thu, Mar 20, 2008 at 05:25:26PM +0100, Carsten Otte wrote: >> @@ -143,6 +143,10 @@ static noinline __init void detect_machi >> /* Running on a P/390 ? */ >> if (cpuinfo->cpu_id.machine == 0x7490) >> machine_flags |= 4; >> + >> +/* Running und

Re: [kvm-devel] [RFC/PATCH 14/15] guest: detect when running on kvm

2008-03-20 Thread Carsten Otte
Christoph Hellwig wrote: > On Thu, Mar 20, 2008 at 09:37:19PM +0100, Carsten Otte wrote: >> Christoph Hellwig wrote: >>> On Thu, Mar 20, 2008 at 05:25:26PM +0100, Carsten Otte wrote: @@ -143,6 +143,10 @@ static noinline __init void detect_machi /* Running on a P/390 ? */ if (cp

Re: [kvm-devel] [RFC/PATCH 14/15] guest: detect when running on kvm

2008-03-20 Thread Heiko Carstens
On Thu, Mar 20, 2008 at 09:59:32PM +0100, Carsten Otte wrote: > Christoph Hellwig wrote: > > On Thu, Mar 20, 2008 at 09:37:19PM +0100, Carsten Otte wrote: > >> Christoph Hellwig wrote: > >>> On Thu, Mar 20, 2008 at 05:25:26PM +0100, Carsten Otte wrote: > @@ -143,6 +143,10 @@ static noinline __

Re: [kvm-devel] [RFC/PATCH 14/15] guest: detect when running on kvm

2008-03-21 Thread Carsten Otte
[EMAIL PROTECTED] wrote: > Since when do we have symbolic names for the bits? > It was always on my todo list to do a cleanup and replace the numbers > we use everywhere with names. Especially since we have clashes from time > to time... but that didn't hurt enough yet, obviously. > But now that yo

Re: [kvm-devel] [RFC/PATCH 14/15] guest: detect when running on kvm

2008-03-21 Thread Heiko Carstens
On Fri, Mar 21, 2008 at 12:12:04PM +0100, Carsten Otte wrote: > [EMAIL PROTECTED] wrote: >> Since when do we have symbolic names for the bits? >> It was always on my todo list to do a cleanup and replace the numbers >> we use everywhere with names. Especially since we have clashes from time >> to t

Re: [kvm-devel] [RFC/PATCH 14/15] guest: detect when running on kvm

2008-03-21 Thread Carsten Otte
Am Freitag, den 21.03.2008, 15:06 +0100 schrieb Heiko Carstens: > Just introduce something like MACHINE_FLAG_KVM. The rest can be converted > later. Unless you're bored and feel like fiddling around with assembly code :) I've done that patch this morning already, see below. I agree with HCH that we

Re: [kvm-devel] [RFC/PATCH 14/15] guest: detect when running on kvm

2008-03-22 Thread Heiko Carstens
On Fri, Mar 21, 2008 at 03:33:29PM +0100, Carsten Otte wrote: > Am Freitag, den 21.03.2008, 15:06 +0100 schrieb Heiko Carstens: > > Just introduce something like MACHINE_FLAG_KVM. The rest can be converted > > later. Unless you're bored and feel like fiddling around with assembly code > > :) > I'v