Re: PATCH: virtio_console: Fix poll blocking even though there is data to read

2010-09-16 Thread Amit Shah
On (Thu) Sep 16 2010 [11:52:01], Amit Shah wrote: > On (Thu) Sep 16 2010 [15:32:54], Rusty Russell wrote: > > On Wed, 15 Sep 2010 11:16:24 pm Amit Shah wrote: > > > On (Wed) Sep 15 2010 [15:37:21], Hans de Goede wrote: > > > > >>--- linux-2.6.35.x86_64/drivers/char/virtio_console.c~ > > > >

Re: PATCH: virtio_console: Fix poll blocking even though there is data to read

2010-09-15 Thread Amit Shah
On (Thu) Sep 16 2010 [15:32:54], Rusty Russell wrote: > On Wed, 15 Sep 2010 11:16:24 pm Amit Shah wrote: > > On (Wed) Sep 15 2010 [15:37:21], Hans de Goede wrote: > > > >>--- linux-2.6.35.x86_64/drivers/char/virtio_console.c~ 2010-08-02 > > > >>00:11:14.0 +0200 > > > >>+++ linux-2.6.35.x8

Re: PATCH: virtio_console: Fix poll blocking even though there is data to read

2010-09-15 Thread Rusty Russell
On Wed, 15 Sep 2010 11:16:24 pm Amit Shah wrote: > On (Wed) Sep 15 2010 [15:37:21], Hans de Goede wrote: > > >>--- linux-2.6.35.x86_64/drivers/char/virtio_console.c~2010-08-02 > > >>00:11:14.0 +0200 > > >>+++ linux-2.6.35.x86_64/drivers/char/virtio_console.c 2010-09-15 > > >>13:39

Re: PATCH: virtio_console: Fix poll blocking even though there is data to read (version 2)

2010-09-15 Thread Amit Shah
On (Wed) Sep 15 2010 [17:18:23], Hans de Goede wrote: > diff -up linux-2.6.35.x86_64/drivers/char/virtio_console.c~ > linux-2.6.35.x86_64/drivers/char/virtio_console.c > --- linux-2.6.35.x86_64/drivers/char/virtio_console.c~2010-08-02 > 00:11:14.0 +0200 > +++ linux-2.6.35.x86_64/d

Re: PATCH: virtio_console: Fix poll blocking even though there is data to read

2010-09-15 Thread Hans de Goede
Hi, On 09/15/2010 03:25 PM, Amit Shah wrote: > On (Wed) Sep 15 2010 [15:04:53], Hans de Goede wrote: >> Hi All, >> >> I found this while working on a Linux agent for spice, the symptom I was >> seeing was select blocking on the spice vdagent virtio serial port even >> though there were messages qu

Re: PATCH: virtio_console: Fix poll blocking even though there is data to read

2010-09-15 Thread Hans de Goede
Hi, On 09/15/2010 03:46 PM, Amit Shah wrote: > On (Wed) Sep 15 2010 [15:37:21], Hans de Goede wrote: --- linux-2.6.35.x86_64/drivers/char/virtio_console.c~ 2010-08-02 00:11:14.0 +0200 +++ linux-2.6.35.x86_64/drivers/char/virtio_console.c 2010-09-15 13:39:29.0

PATCH: virtio_console: Fix poll blocking even though there is data to read

2010-09-15 Thread Hans de Goede
Hi All, I found this while working on a Linux agent for spice, the symptom I was seeing was select blocking on the spice vdagent virtio serial port even though there were messages queued up there. I found this while working on a Linux agent for spice, the symptom I was seeing was select blocking

PATCH: virtio_console: Fix poll blocking even though there is data to read (version 2)

2010-09-15 Thread Hans de Goede
Hi All, I found this while working on a Linux agent for spice, the symptom I was seeing was select blocking on the spice vdagent virtio serial port even though there were messages queued up there. I found this while working on a Linux agent for spice, the symptom I was seeing was select blocking

Re: PATCH: virtio_console: Fix poll blocking even though there is data to read

2010-09-15 Thread Amit Shah
On (Wed) Sep 15 2010 [15:37:21], Hans de Goede wrote: > >>--- linux-2.6.35.x86_64/drivers/char/virtio_console.c~ 2010-08-02 > >>00:11:14.0 +0200 > >>+++ linux-2.6.35.x86_64/drivers/char/virtio_console.c 2010-09-15 > >>13:39:29.043505000 +0200 > >>@@ -642,7 +642,7 @@ static unsi

Re: PATCH: virtio_console: Fix poll blocking even though there is data to read

2010-09-15 Thread Amit Shah
On (Wed) Sep 15 2010 [15:04:53], Hans de Goede wrote: > Hi All, > > I found this while working on a Linux agent for spice, the symptom I was > seeing was select blocking on the spice vdagent virtio serial port even > though there were messages queued up there. > > I found this while working on a