RE: [PATCH 1/4] virtio: Improve vq->broken access to avoid any compiler optimization

2021-07-19 Thread Parav Pandit via Virtualization
> From: Michael S. Tsirkin > Sent: Monday, July 19, 2021 5:35 PM > > On Mon, Jul 19, 2021 at 05:26:22AM +, Parav Pandit wrote: > > > > > > > From: Michael S. Tsirkin > > > Sent: Sunday, July 18, 2021 2:09 AM > > > > > > On Sat, Jul 17, 2021 at 10:42:55AM +0300, Parav Pandit wrote: > > >

Re: [PATCH 1/4] virtio: Improve vq->broken access to avoid any compiler optimization

2021-07-19 Thread Michael S. Tsirkin
On Mon, Jul 19, 2021 at 05:26:22AM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Sunday, July 18, 2021 2:09 AM > > > > On Sat, Jul 17, 2021 at 10:42:55AM +0300, Parav Pandit wrote: > > > Currently vq->broken field is read by virtqueue_is_broken() in busy > > > loop in

RE: [PATCH 1/4] virtio: Improve vq->broken access to avoid any compiler optimization

2021-07-18 Thread Parav Pandit via Virtualization
> From: Michael S. Tsirkin > Sent: Sunday, July 18, 2021 2:09 AM > > On Sat, Jul 17, 2021 at 10:42:55AM +0300, Parav Pandit wrote: > > Currently vq->broken field is read by virtqueue_is_broken() in busy > > loop in one context by virtnet_send_command(). > > > > vq->broken is set to true in

Re: [PATCH 1/4] virtio: Improve vq->broken access to avoid any compiler optimization

2021-07-17 Thread Michael S. Tsirkin
On Sat, Jul 17, 2021 at 10:42:55AM +0300, Parav Pandit wrote: > Currently vq->broken field is read by virtqueue_is_broken() in busy > loop in one context by virtnet_send_command(). > > vq->broken is set to true in other process context by > virtio_break_device(). Reader and writer are accessing