Re: [PATCH 2.6.32-rc1] net: VMware virtual Ethernet NIC driver: vmxnet3

2009-10-01 Thread David Miller
From: Shreyas Bhatewara Date: Wed, 30 Sep 2009 14:34:57 -0700 (PDT) > +{ > + struct vmxnet3_adapter *adapter = netdev_priv(netdev); > + u8 *base; > + int i; > + > + VMXNET3_WRITE_BAR1_REG(adapter, VMXNET3_REG_CMD, > VMXNET3_CMD_GET_STATS); > + > + /* this does assume each counter

Re: [PATCH 2.6.32-rc1] net: VMware virtual Ethernet NIC driver: vmxnet3

2009-09-30 Thread David Miller
From: Stephen Hemminger Date: Wed, 30 Sep 2009 17:39:23 -0700 > Why not use NETIF_F_LRO and ethtool to control LRO support? In fact, you must, in order to handle bridging and routing correctly. Bridging and routing is illegal with LRO enabled, so the kernel automatically issues the necessary et

RE: [PATCH 2.6.32-rc1] net: VMware virtual Ethernet NIC driver: vmxnet3

2009-09-30 Thread Shreyas Bhatewara
ony Liguori; Chris Wright; Greg Kroah-Hartman; Andrew > Morton; virtualization; pv-drivers > Subject: Re: [PATCH 2.6.32-rc1] net: VMware virtual Ethernet NIC > driver: vmxnet3 > > On Wed, 30 Sep 2009 14:34:57 -0700 (PDT) > Shreyas Bhatewara wrote: > > Note: your patch

Re: [PATCH 2.6.32-rc1] net: VMware virtual Ethernet NIC driver: vmxnet3

2009-09-30 Thread Stephen Hemminger
On Wed, 30 Sep 2009 14:34:57 -0700 (PDT) Shreyas Bhatewara wrote: Note: your patch was linewrapped again > + > + > +static void > +vmxnet3_declare_features(struct vmxnet3_adapter *adapter, bool dma64) > +{ > + struct net_device *netdev = adapter->netdev; > + > + netdev->features = NETIF_