Re: req->nr_phys_segments > queue_max_segments (was Re: kernel BUG at drivers/block/virtio_blk.c:172!)

2015-10-01 Thread Thomas D.
Hi > seems like we have two problems: > > The first (origin) problem seems to be already fixed by Mike's patch. > > I applied the patch against linux-4.1.8, rebooted several times without > a problem. But I'll keep testing for sure. I already experienced one freeze with linux-4.1.8 and Mike's p

Re: req->nr_phys_segments > queue_max_segments (was Re: kernel BUG at drivers/block/virtio_blk.c:172!)

2015-10-01 Thread Thomas D.
Hi, seems like we have two problems: The first (origin) problem seems to be already fixed by Mike's patch. I applied the patch against linux-4.1.8, rebooted several times without a problem. But I'll keep testing for sure. The second problem is a new bug within linux-4.1.9: I experience the >

Re: req->nr_phys_segments > queue_max_segments (was Re: kernel BUG at drivers/block/virtio_blk.c:172!)

2015-10-01 Thread Thomas D.
Hi, Michael S. Tsirkin wrote: > To debug this, > maybe you can print out sg_elems at init time and when this fails, > to make sure some kind of memory corruption > does not change sg_elems after initialization? If that was addressed to me could you please tell me how to do that? -Thomas __

Re: req->nr_phys_segments > queue_max_segments (was Re: kernel BUG at drivers/block/virtio_blk.c:172!)

2015-10-01 Thread Thomas D.
Hi, Mike Snitzer wrote: > This particular dm-crypt on virtio-blk issue is fixed with this commit: > http://git.kernel.org/linus/586b286b110e94eb31840ac5afc0c24e0881fe34 > > Linus pulled this into v4.3-rc3. I have this patch applied to linux-4.1.9. This could be the reason why I don't see the iss

Re: req->nr_phys_segments > queue_max_segments (was Re: kernel BUG at drivers/block/virtio_blk.c:172!)

2015-10-01 Thread Thomas D.
Hi, Jens Axboe wrote: > Looking at the specific virtio_blk case, it does seem that it is > checking the segment count before mapping. Does the below fix the > problem, or does the BUG_ON() still trigger? Have I understood you correctly, that I should test your patch against linux-4.1.8? PS: I

kernel BUG at drivers/block/virtio_blk.c:172!

2015-10-01 Thread Thomas D.
Hi, I have a virtual machine which fails to boot linux-4.1.8 while mounting file systems: > * Mounting local filesystem ... > [ cut here ]---- > kernel BUG at drivers/block/virtio_blk.c:172! > invalid opcode: 000 [#1] SMP > Modules linked in: pcspkr psmouse d

Re: req->nr_phys_segments > queue_max_segments (was Re: kernel BUG at drivers/block/virtio_blk.c:172!)

2015-10-01 Thread Michael S. Tsirkin
.1.8 while mounting > >>file systems: > >> > >>>* Mounting local filesystem ... > >>>----[ cut here ] > >>>kernel BUG at drivers/block/virtio_blk.c:172! > >>>invalid opcode: 000 [#1] SMP > >>>Modules linked in: pcspkr

Re: req->nr_phys_segments > queue_max_segments (was Re: kernel BUG at drivers/block/virtio_blk.c:172!)

2015-10-01 Thread Mike Snitzer
gt;>> file systems: >>> >>>> * Mounting local filesystem ... >>>> ----[ cut here ] >>>> kernel BUG at drivers/block/virtio_blk.c:172! >>>> invalid opcode: 000 [#1] SMP >>>> Modules linked in: pcspkr

Re: req->nr_phys_segments > queue_max_segments (was Re: kernel BUG at drivers/block/virtio_blk.c:172!)

2015-10-01 Thread Jens Axboe
On 10/01/2015 11:00 AM, Michael S. Tsirkin wrote: On Thu, Oct 01, 2015 at 03:10:14AM +0200, Thomas D. wrote: Hi, I have a virtual machine which fails to boot linux-4.1.8 while mounting file systems: * Mounting local filesystem ... [ cut here ] kernel BUG at drivers

Re: req->nr_phys_segments > queue_max_segments (was Re: kernel BUG at drivers/block/virtio_blk.c:172!)

2015-10-01 Thread Hannes Reinecke
filesystem ... >>> --------[ cut here ]-------- >>> kernel BUG at drivers/block/virtio_blk.c:172! >>> invalid opcode: 000 [#1] SMP >>> Modules linked in: pcspkr psmouse dm_log_userspace virtio_net e1000 fuse >>> nfs lockd grace sunrpc fscache dm_snapshot dm_buf

req->nr_phys_segments > queue_max_segments (was Re: kernel BUG at drivers/block/virtio_blk.c:172!)

2015-10-01 Thread Michael S. Tsirkin
On Thu, Oct 01, 2015 at 03:10:14AM +0200, Thomas D. wrote: > Hi, > > I have a virtual machine which fails to boot linux-4.1.8 while mounting > file systems: > > > * Mounting local filesystem ... > > [ cut here ]-------- > > kernel BUG

Re: kernel BUG at drivers/block/virtio_blk.c:172!

2014-11-13 Thread Dongsu Park
On 12.11.2014 11:18, Jens Axboe wrote: > On 11/11/2014 09:42 AM, Ming Lei wrote: > > The attached patch should fix the problem, and hope it is the last one, :-) > > Dongsu and Jeff, any of you test this variant? I think this is the last > one, at least I hope so as well... Yes, I've just tested i

Re: kernel BUG at drivers/block/virtio_blk.c:172!

2014-11-12 Thread Jeff Layton
On Wed, 12 Nov 2014 11:18:32 -0700 Jens Axboe wrote: > On 11/11/2014 09:42 AM, Ming Lei wrote: > > The attached patch should fix the problem, and hope it is the last one, :-) > > Dongsu and Jeff, any of you test this variant? I think this is the last > one, at least I hope so as well... > Yes,

Re: kernel BUG at drivers/block/virtio_blk.c:172!

2014-11-12 Thread Jens Axboe
On 11/11/2014 09:42 AM, Ming Lei wrote: > The attached patch should fix the problem, and hope it is the last one, :-) Dongsu and Jeff, any of you test this variant? I think this is the last one, at least I hope so as well... -- Jens Axboe ___ Virtuali

Re: kernel BUG at drivers/block/virtio_blk.c:172!

2014-11-11 Thread Ming Lei
it runs with blk-mq, device mapper, and xfs. > The simplest way to reproduce this bug is to run xfstests/generic/034. > Note, test 034 requires dm-flakey to be turned on in the kernel config. > > See the kernel trace below: > [ cut here ] > kernel BUG at dr

Re: kernel BUG at drivers/block/virtio_blk.c:172!

2014-11-11 Thread Dongsu Park
t 034 requires dm-flakey to be turned on in the kernel config. See the kernel trace below: [ cut here ] kernel BUG at drivers/block/virtio_blk.c:172! invalid opcode: [#1] SMP CPU: 1 PID: 3343 Comm: mount Not tainted 3.18.0-rc4+ #55 RIP: 0010:[] [] vi

Re: kernel BUG at drivers/block/virtio_blk.c:172!

2014-11-10 Thread Ming Lei
rnels seem to be fine: >>> >>> [ 64.669633] --------[ cut here ]---- >>> [ 64.670008] kernel BUG at drivers/block/virtio_blk.c:172! >> >> >> Hmm, that's: >> >> BUG_ON(req->nr_phys_segments + 2 > vblk->sg_ele

Re: kernel BUG at drivers/block/virtio_blk.c:172!

2014-11-10 Thread Jens Axboe
On 2014-11-10 02:59, Rusty Russell wrote: Jeff Layton writes: In the latest Fedora rawhide kernel in the repos, I'm seeing the following oops when mounting xfs. rc2-ish kernels seem to be fine: [ 64.669633] [ cut here ] [ 64.670008] kernel BUG at drivers/

Re: kernel BUG at drivers/block/virtio_blk.c:172!

2014-11-10 Thread Rusty Russell
Jeff Layton writes: > In the latest Fedora rawhide kernel in the repos, I'm seeing the > following oops when mounting xfs. rc2-ish kernels seem to be fine: > > [ 64.669633] [ cut here ] > [ 64.670008] kernel BUG at drivers/block/virtio_blk

kernel BUG at drivers/block/virtio_blk.c:172!

2014-11-10 Thread Jeff Layton
In the latest Fedora rawhide kernel in the repos, I'm seeing the following oops when mounting xfs. rc2-ish kernels seem to be fine: [ 64.669633] [ cut here ] [ 64.670008] kernel BUG at drivers/block/virtio_blk.c:172! [ 64.670008] invalid opcode: [#1

Re: Re: kernel BUG at drivers/block/virtio_blk.c:172

2014-11-10 Thread Ming Lei
On Mon, Nov 10, 2014 at 9:05 PM, Lukáš Czerner wrote: > On Mon, 10 Nov 2014, Ming Lei wrote: > >> Date: Mon, 10 Nov 2014 20:18:32 +0800 >> From: Ming Lei >> To: Lukáš Czerner >> Cc: Jens Axboe , >> Linux Virtualization , >> Christoph Hellwig

Re: Re: kernel BUG at drivers/block/virtio_blk.c:172

2014-11-10 Thread Lukáš Czerner
On Mon, 10 Nov 2014, Ming Lei wrote: > Date: Mon, 10 Nov 2014 20:18:32 +0800 > From: Ming Lei > To: Lukáš Czerner > Cc: Jens Axboe , > Linux Virtualization , > Christoph Hellwig > Subject: Re: Re: kernel BUG at drivers/block/virtio_blk.c:172 > > On Mon, Nov

Re: Re: kernel BUG at drivers/block/virtio_blk.c:172

2014-11-10 Thread Ming Lei
On Mon, Nov 10, 2014 at 7:59 PM, Lukáš Czerner wrote: > > Hi, > > so I encountered it again on 3.17.0-rc4. This output is from the > run with your patch. > > I am using libvirt (virt-manager) to configure and run the virtual > machine, but looking at the xml, I do not think it's passing > 'scsi=of

Re: Re: kernel BUG at drivers/block/virtio_blk.c:172

2014-11-10 Thread Lukáš Czerner
On Fri, 31 Oct 2014, Ming Lei wrote: > Date: Fri, 31 Oct 2014 12:40:00 +0800 > From: Ming Lei > To: Jens Axboe > Cc: Lukáš Czerner , > Linux Virtualization , > Christoph Hellwig > Subject: Re: Re: kernel BUG at drivers/block/virtio_blk.c:172 > > On Thu, Oct

Re: Re: kernel BUG at drivers/block/virtio_blk.c:172

2014-10-30 Thread Ming Lei
On Thu, Oct 30, 2014 at 10:38 PM, Jens Axboe wrote: > Forgot to CC you... > > > Forwarded Message > Subject: Re: kernel BUG at drivers/block/virtio_blk.c:172 > Date: Thu, 30 Oct 2014 08:38:08 -0600 > From: Jens Axboe > To: Lukáš Czerner , >

kernel BUG at drivers/block/virtio_blk.c:172

2014-10-30 Thread Lukáš Czerner
2.807018] kernel BUG at drivers/block/virtio_blk.c:172! [2.807018] invalid opcode: [#1] SMP [2.807018] Modules linked in: xfs libcrc32c sd_mod qxl ata_generic pata_acpi drm_kms_helper ttm drm ata_piix virtio_net virtio_blk libata virtio_pci floppy virtio_ring i2c_core virtio

Re: kernel BUG at drivers/block/virtio_blk.c:172

2014-10-30 Thread Jens Axboe
n't really fixed. The above upstream commit has the latest fixup as well for the segments being wrong, so nothing else should be pending. Leaving trace below. [2.806242] [ cut here ] [2.807018] kernel BUG at drivers/block/virtio_blk.c:172! [2.807018]