Re: RFC: control virtqueue size by the vdpa tool

2022-08-31 Thread Si-Wei Liu
On 8/30/2022 10:22 PM, Eli Cohen wrote: From: Si-Wei Liu Sent: Wednesday, August 31, 2022 2:23 AM To: Michael S. Tsirkin Cc: Eli Cohen ; virtualization@lists.linux-foundation.org; Jason Wang ; epere...@redhat.com Subject: Re: RFC: control virtqueue size by the vdpa tool On 8/30/2022 3:01

Re: [PATCH] drm/virtio: set fb_modifiers_not_supported

2022-08-31 Thread Daniel Stone
On Wed, 31 Aug 2022 at 20:06, Chia-I Wu wrote: > Without this, the drm core advertises LINEAR modifier which is > incorrect. > > Also userspace virgl does not support modifiers. For example, it causes > chrome on ozone/drm to fail with "Failed to create scanout buffer". > > Fixes: 2af104290da5

[PATCH] drm/virtio: set fb_modifiers_not_supported

2022-08-31 Thread Chia-I Wu
Without this, the drm core advertises LINEAR modifier which is incorrect. Also userspace virgl does not support modifiers. For example, it causes chrome on ozone/drm to fail with "Failed to create scanout buffer". Fixes: 2af104290da5 ("drm: introduce fb_modifiers_not_supported flag in

[PATCH v3] vduse: prevent uninitialized memory accesses

2022-08-31 Thread Maxime Coquelin
If the VDUSE application provides a smaller config space than the driver expects, the driver may use uninitialized memory from the stack. This patch prevents it by initializing the buffer passed by the driver to store the config value. This fix addresses CVE-2022-2308. Cc:

Re: [PATCH v2] vduse: prevent uninitialized memory accesses

2022-08-31 Thread Maxime Coquelin
On 8/31/22 17:46, Michael S. Tsirkin wrote: On Wed, Aug 31, 2022 at 05:01:11PM +0200, Maxime Coquelin wrote: On 8/29/22 09:48, Greg KH wrote: On Mon, Aug 29, 2022 at 09:34:24AM +0200, Maxime Coquelin wrote: If the VDUSE application provides a smaller config space than the driver expects,

Re: [PATCH v2] vduse: prevent uninitialized memory accesses

2022-08-31 Thread Michael S. Tsirkin
On Wed, Aug 31, 2022 at 05:01:11PM +0200, Maxime Coquelin wrote: > On 8/29/22 09:48, Greg KH wrote: > > On Mon, Aug 29, 2022 at 09:34:24AM +0200, Maxime Coquelin wrote: > > > If the VDUSE application provides a smaller config space > > > than the driver expects, the driver may use uninitialized >

Re: [PATCH v4 12/21] xen/gntdev: Prepare to dynamic dma-buf locking specification

2022-08-31 Thread Juergen Gross via Virtualization
On 31.08.22 17:37, Dmitry Osipenko wrote: Prepare gntdev driver to the common dynamic dma-buf locking convention by starting to use the unlocked versions of dma-buf API functions. Signed-off-by: Dmitry Osipenko Acked-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description:

Re: [PATCH v2] vduse: prevent uninitialized memory accesses

2022-08-31 Thread Michael S. Tsirkin
On Wed, Aug 31, 2022 at 05:01:11PM +0200, Maxime Coquelin wrote: > On 8/29/22 09:48, Greg KH wrote: > > On Mon, Aug 29, 2022 at 09:34:24AM +0200, Maxime Coquelin wrote: > > > If the VDUSE application provides a smaller config space > > > than the driver expects, the driver may use uninitialized >

Re: [PATCH v2] vduse: prevent uninitialized memory accesses

2022-08-31 Thread Maxime Coquelin
On 8/29/22 09:48, Greg KH wrote: On Mon, Aug 29, 2022 at 09:34:24AM +0200, Maxime Coquelin wrote: If the VDUSE application provides a smaller config space than the driver expects, the driver may use uninitialized memory from the stack. This patch prevents it by initializing the buffer passed

Re: [PATCH RESEND v4 2/2] virtio-net: use mtu size as buffer length for big packets

2022-08-31 Thread Michael S. Tsirkin
On Wed, Aug 31, 2022 at 04:05:41PM +0300, Gavin Li wrote: > Currently add_recvbuf_big() allocates MAX_SKB_FRAGS segments for big > packets even when GUEST_* offloads are not present on the device. > However, if guest GSO is not supported, it would be sufficient to > allocate segments to cover just

Re: [PATCH RESEND v4 1/2] virtio-net: introduce and use helper function for guest gso support checks

2022-08-31 Thread Michael S. Tsirkin
On Wed, Aug 31, 2022 at 04:05:40PM +0300, Gavin Li wrote: > Probe routine is already several hundred lines. > Use helper function for guest gso support check. > > Signed-off-by: Gavin Li > Reviewed-by: Gavi Teitz > Reviewed-by: Parav Pandit > Reviewed-by: Xuan Zhuo > Reviewed-by: Si-Wei Liu

Re: [PATCH] virtio_net: Abort driver initialization if device fails

2022-08-31 Thread Michael S. Tsirkin
On Mon, Aug 29, 2022 at 04:49:02AM +, Eli Cohen wrote: > > From: Michael S. Tsirkin > > Sent: Sunday, August 28, 2022 11:08 PM > > To: Eli Cohen > > Cc: jasow...@redhat.com; epere...@redhat.com; si-wei@oracle.com; > > virtualization@lists.linux-foundation.org > > Subject: Re: [PATCH]

RE: [PATCH v4 1/2] virtio-net: introduce and use helper function for guest gso support checks

2022-08-31 Thread Parav Pandit via Virtualization
> From: Gavin Li > Sent: Wednesday, August 31, 2022 5:03 AM > > Probe routine is already several hundred lines. > Use helper function for guest gso support check. > > Signed-off-by: Gavin Li > Reviewed-by: Gavi Teitz > Reviewed-by: Parav Pandit You missed the review by and ack by entries

Re: [virtio-dev] [PATCH v3 2/2] virtio-net: use mtu size as buffer length for big packets

2022-08-31 Thread Si-Wei Liu
On 8/29/2022 7:26 PM, Gavin Li wrote: Currently add_recvbuf_big() allocates MAX_SKB_FRAGS segments for big packets even when GUEST_* offloads are not present on the device. However, if guest GSO is not supported, it would be sufficient to allocate segments to cover just up the MTU size and no

Re: [virtio-dev] [PATCH v3 1/2] virtio-net: introduce and use helper function for guest gso support checks

2022-08-31 Thread Si-Wei Liu
On 8/29/2022 7:26 PM, Gavin Li wrote: Probe routine is already several hundred lines. Use helper function for guest gso support check. Signed-off-by: Gavin Li Reviewed-by: Gavi Teitz Reviewed-by: Parav Pandit Reviewed-by: Si-Wei Liu --- changelog: v1->v2 - Add new patch ---

Re: [PATCH] virtio_net: Abort driver initialization if device fails

2022-08-31 Thread Jason Wang
On Mon, Aug 29, 2022 at 12:52 PM Eli Cohen wrote: > > > > > -Original Message- > > From: Jason Wang > > Sent: Monday, August 29, 2022 3:33 AM > > To: Michael S. Tsirkin > > Cc: Eli Cohen ; eperezma ; Si- > > Wei Liu ; virtualization > foundation.org> > > Subject: Re: [PATCH]