From: Jason Wang
Date: Tue, 15 Oct 2013 11:18:59 +0800
> We used to schedule the refill work unconditionally after changing the
> number of queues. This may lead an issue if the device is not
> up. Since we only try to cancel the work in ndo_stop(), this may cause
> the refill work still work aft
From: Jason Wang
Date: Tue, 15 Oct 2013 11:18:58 +0800
> We're trying to re-configure the affinity unconditionally in cpu hotplug
> callback. This may lead the issue during resuming from s3/s4 since
>
> - virt queues haven't been allocated at that time.
> - it's unnecessary since thaw method wil
From: Rusty Russell
Date: Fri, 18 Oct 2013 11:30:15 +1030
> Asking people to express 'CC: stable' in words is error-prone; if Dave
> wants to filter it, he's quite capable.
Filtering it one time is one thing.
Potentially acting on that filter 100 or so times a day...
That's completely another.
From: Rusty Russell
Date: Fri, 18 Oct 2013 16:47:14 +1030
> Do you want awk script to turn the latter into the former? Would that
> really help?
Rusty in the several years I've been operating this way, you're
the first person who seems to mind it.
To be honest I sometimes just silently deal wi
From: Eric Dumazet
Date: Mon, 28 Oct 2013 16:19:49 -0700
> On Mon, 2013-10-28 at 15:44 -0700, Michael Dalton wrote:
>> The virtio_net driver's mergeable receive buffer allocator
>> uses 4KB packet buffers. For MTU-sized traffic, SKB truesize
>> is > 4KB but only ~1500 bytes of the buffer is used
From: Jason Wang
Date: Tue, 29 Oct 2013 15:11:07 +0800
> commit 3ab098df35f8b98b6553edc2e40234af512ba877 (virtio-net: don't respond to
> cpu hotplug notifier if we're not ready) tries to bypass the cpu hotplug
> notifier by checking the config_enable and does nothing is it was false. So it
> need
From: Jason Wang
Date: Fri, 1 Nov 2013 14:07:48 +0800
> Commit 2613af0ed18a11d5c566a81f9a6510b73180660a (virtio_net: migrate mergeable
> rx buffers to page frag allocators) try to increase the payload/truesize for
> MTU-sized traffic. But this will introduce the extra overhead for GSO packets
>
From: Jason Wang
Date: Fri, 1 Nov 2013 14:07:47 +0800
> Sometimes we need to coalesce the rx frags to avoid frag list. One example is
> virtio-net driver which tries to use small frags for both MTU sized packet and
> GSO packet. So this patch introduce skb_coalesce_rx_frag() to do this.
>
> Cc:
From: Jason Wang
Date: Tue, 5 Nov 2013 18:19:45 +0800
> We used to use a percpu structure vq_index to record the cpu to queue
> mapping, this is suboptimal since it duplicates the work of XPS and
> loses all other XPS functionality such as allowing user to configure
> their own transmission stee
From: Michael Dalton
Date: Tue, 12 Nov 2013 14:21:22 -0800
> Commit 2613af0ed18a ("virtio_net: migrate mergeable rx buffers to page
> frag allocators") changed the mergeable receive buffer size from PAGE_SIZE
> to MTU-size. However, the merge buffer size does not take into account the
> size of t
From: Eric Dumazet
Date: Thu, 14 Nov 2013 10:59:12 -0800
> On Thu, 2013-11-14 at 10:41 -0800, Michael Dalton wrote:
>> Commit 2613af0ed18a ("virtio_net: migrate mergeable rx buffers to page
>> frag allocators") changed the mergeable receive buffer size from PAGE_SIZE
>> to MTU-size. However, the
From: Thomas Huth
Date: Fri, 29 Nov 2013 10:02:19 +0100
> "MAC filter" sounds more reasonable than "MAC fitler".
>
> Signed-off-by: Thomas Huth
Applied, thanks.
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.l
From: "Michael S. Tsirkin"
Date: Thu, 28 Nov 2013 13:30:55 +0200
> Eric Dumazet noticed that if we encounter an error
> when processing a mergeable buffer, we don't
> dequeue all of the buffers from this packet,
> the result is almost sure to be loss of networking.
>
> Jason Wang noticed that we
From: "Michael S. Tsirkin"
Date: Thu, 28 Nov 2013 13:30:59 +0200
> receive mergeable now handles errors internally.
> Do same for big and small packet paths, otherwise
> the logic is too hard to follow.
>
> Signed-off-by: Michael S. Tsirkin
> Acked-by: Jason Wang
Applied and I fixed the subje
From: Andrey Vagin
Date: Thu, 5 Dec 2013 18:36:20 +0400
> free_unused_bufs must check vi->mergeable_rx_bufs before
> vi->big_packets, because we use this sequence in other places.
> Otherwise we allocate buffer of one type, then free it as another
> type.
...
> Fixes: 2613af0ed18a (virtio_net:
From: Andrey Vagin
Date: Thu, 5 Dec 2013 18:36:21 +0400
> free_netdev calls netif_napi_del too, but it's too late, because napi
> structures are placed on vi->rq. netif_napi_add() is called from
> virtnet_alloc_queues.
...
> Fixes: 986a4f4d452d (virtio_net: multiqueue support)
> Cc: Rusty Russe
From: Michael Dalton
Date: Thu, 5 Dec 2013 13:14:05 -0800
> When a packet with invalid length arrives, ensure that the packet
> is freed correctly if mergeable packet buffers and big packets
> (GUEST_TSO4) are both enabled.
>
> Signed-off-by: Michael Dalton
Applied, is this needed for -stable
From: Stephen Hemminger
Date: Mon, 9 Dec 2013 16:18:45 -0800
> Signed-off-by: Stephen Hemminger
Applied.
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
From: Stephen Hemminger
Date: Mon, 9 Dec 2013 16:17:40 -0800
> All the code passes NULL for the last sg list (in).
> Simplify by just removing it.
>
> Signed-off-by: Stephen Hemminger
Applied.
___
Virtualization mailing list
Virtualization@lists.linu
From: Stephen Hemminger
Date: Mon, 9 Dec 2013 16:16:32 -0800
> The virtio_net driver never sends the multicast address list to
> the host. This is because send command takes a pointer to scatter list
> to send but only inserts that one entry into the outgoing scatter list.
>
> This bug has been
From: Stephen Hemminger
Date: Mon, 9 Dec 2013 16:16:32 -0800
> The virtio_net driver never sends the multicast address list to
> the host. This is because send command takes a pointer to scatter list
> to send but only inserts that one entry into the outgoing scatter list.
>
> This bug has been
Can I get some reviews of this series from virtio folks?
Thanks.
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
There is still feedback and/or minor adjustments being asked for wrt.
this series. These changes have been sitting for more than a week
which is a bit rediculous.
Please resubmit these changes once everything is resolved to
everyone's satisfaction, thanks.
__
From: Jason Wang
Date: Mon, 30 Dec 2013 11:34:40 +0800
> During restoring, try_fill_recv() was called with neither napi lock nor napi
> disabled. This can lead two try_fill_recv() was called in the same time. Fix
> this by refilling before trying to enable napi.
>
> Fixes 0741bcb5584f9e2390ae626
From: Eric Dumazet
Date: Wed, 08 Jan 2014 10:09:47 -0800
> A physical NIC do not use a workqueue to refill its RX queue but uses
> the following strategy :
>
> 0) Pre filling of RX ring buffer with N frames. This can use GFP_KERNEL
>allocations with all needed (sleep/retry/shout) logic...
>
From: "Michael S. Tsirkin"
Date: Sun, 12 Jan 2014 13:37:56 +0200
> Since virtio is an OASIS standard draft now, virtio implementation
> discussions are taking place on the virtio-dev OASIS mailing list.
> Update MAINTAINERS.
>
> Signed-off-by: Michael S. Tsirkin
Applied, thanks.
__
From: Rusty Russell
Date: Thu, 16 Jan 2014 10:25:26 +1030
> Rusty Russell writes:
>> Jason Wang writes:
>>> It looks like there's no need for those two fields:
>>>
>>> - Unless there's a failure for the first refill try, rq->max should be
>>> always
>>> equal to the vring size.
>>> - rq->num
All 6 patches applied.
Next time, PLEASE, give me a header email ala "[PATCH net-next v4 0/6]" giving
a broad overview of the series.
This serves several purposes.
First, it gives me a single top-level email to reply to when I want to let
you know that I've either applied or rejected this serie
From: David Miller
Date: Thu, 16 Jan 2014 15:28:00 -0800 (PST)
> All 6 patches applied.
Actually, I reverted, please resubmit this series with the following
build warning corrected:
net/core/net-sysfs.c: In function ‘rx_queue_add_kobject’:
net/core/net-sysfs.c:767:21: warning: ignoring ret
From: Jason Wang
Date: Thu, 16 Jan 2014 14:45:24 +0800
> It looks like there's no need for those two fields:
>
> - Unless there's a failure for the first refill try, rq->max should be always
> equal to the vring size.
> - rq->num is only used to determine the condition that we need to do the
This series does not apply cleanly to net-next.
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
From: Michael Dalton
Date: Thu, 16 Jan 2014 22:23:24 -0800
> The virtio-net device currently uses aligned MTU-sized mergeable receive
> packet buffers. Network throughput for workloads with large average
> packet size can be improved by posting larger receive packet buffers.
> However, due to SKB
From: Michael Dalton
Date: Fri, 17 Jan 2014 01:27:08 -0800
> Commit ab7db91705e9 ("virtio-net: auto-tune mergeable rx buffer size for
> improved performance") introduced a virtio-net dependency on EWMA.
> The inclusion of EWMA is controlled by CONFIG_AVERAGE. Fix build error
> when CONFIG_AVERAGE
From: Greg Kroah-Hartman
Date: Wed, 12 Feb 2014 08:56:30 -0800
> On Wed, Feb 12, 2014 at 06:38:21PM +0200, Michael S. Tsirkin wrote:
>> It is sometimes useful to get the value of the reference count after
>> decrement.
>> For example, vhost wants to execute some periodic cleanup operations
>> onc
From: Greg KH
Date: Wed, 12 Feb 2014 17:39:02 -0800
> Yes, that's horrible as well, but as was already pointed out in this
> thread, you can't rely on that value to really be "1" after reading it
> due to the way krefs work, what happened if someone else just grabbed
> it?
>
> If all they want i
From: David Miller
Date: Wed, 12 Feb 2014 23:05:06 -0500 (EST)
> From: Greg KH
> Date: Wed, 12 Feb 2014 17:39:02 -0800
>
>> Yes, that's horrible as well, but as was already pointed out in this
>> thread, you can't rely on that value to really be "1"
From: "Michael S. Tsirkin"
Date: Thu, 13 Feb 2014 11:45:11 +0200
> vhost_zerocopy_callback accesses VQ right after it drops a ubuf
> reference. In theory, this could race with device removal which waits
> on the ubuf kref, and crash on use after free.
>
> Do all accesses within rcu read side cr
From: "Michael S. Tsirkin"
Date: Thu, 13 Feb 2014 11:42:05 +0200
> vhost checked the counter within the refcnt before decrementing. It
> really wanted to know that it is the one that has the last reference, as
> a way to batch freeing resources a bit more efficiently.
>
> Note: we only let refc
From: Greg KH
Date: Thu, 13 Feb 2014 16:03:20 -0800
> So how about just "open coding" a kref for this structure, as it wants
> something that doesn't fit into the kref model, and should be pretty
> simple to do (you can ensure you get the locking right, unlike almost
> all users of krefs, as Al V
From: Jason Wang
Date: Fri, 21 Feb 2014 13:08:04 +0800
> We should alloc big buffers also when guest can receive UFO
> pakcets to let the big packets be fit into guest rx buffer.
>
> Fixes 5c5167515d80f78f6bb538492c423adcae31ad65
> (virtio-net: Allow UFO feature to be set and advertised.)
>
> C
From: Jason Wang
Date: Fri, 7 Mar 2014 13:28:27 +0800
> This is because the delay added by htb may lead the delay the finish
> of DMAs and cause the pending DMAs for tap0 exceeds the limit
> (VHOST_MAX_PEND). In this case vhost stop handling tx request until
> htb send some packets. The problem
From: Jason Wang
Date: Wed, 26 Mar 2014 13:03:00 +0800
> Current error handling of virtqueue_kick() was wrong in two places:
> - The skb were freed immediately when virtqueue_kick() fail during
> xmit. This may lead double free since the skb was not detached from
> the virtqueue.
> - try_fill
From: "Michael S. Tsirkin"
Date: Thu, 27 Mar 2014 12:00:26 +0200
> When mergeable buffers are disabled, and the
> incoming packet is too large for the rx buffer,
> get_rx_bufs returns success.
>
> This was intentional in order for make recvmsg
> truncate the packet and then handle_rx would
> det
From: "Michael S. Tsirkin"
Date: Thu, 27 Mar 2014 12:53:37 +0200
> vhost fails to validate negative error code
> from vhost_get_vq_desc causing
> a crash: we are using -EFAULT which is 0xfff2
> as vector size, which exceeds the allocated size.
>
> The code in question was introduced in commi
From: Amos Kong
Date: Fri, 18 Apr 2014 13:45:41 +0800
> Execute "ethtool -L eth0 combined 0" in guest, if multiqueue
> is enabled, virtnet_send_command() will return -EINVAL error,
> there is a validation in QEMU.
>
> But if multiqueue is disabled, virtnet_set_queues() will just
> return zero (s
From: Andy King
Date: Thu, 1 May 2014 15:20:43 -0700
> Right now the core vsock module is the owner of the proto family. This
> means there's nothing preventing the transport module from unloading if
> there are open sockets, which results in a panic. Fix that by allowing
> the transport to be t
From: Wilfried Klaebe
Date: Sun, 11 May 2014 00:12:32 +
> net: get rid of SET_ETHTOOL_OPS
>
> Dave Miller mentioned he'd like to see SET_ETHTOOL_OPS gone.
> This does that.
>
> Mostly done via coccinelle script:
> @@
> struct ethtool_ops *ops;
> struct net_device *dev;
> @@
> - SET_ET
From: "Michael S. Tsirkin"
Date: Mon, 2 Jun 2014 23:55:15 +0300
> The following changes since commit 96b2e73c5471542cb9c622c4360716684f8797ed:
>
> Revert "net/mlx4_en: Use affinity hint" (2014-06-02 00:18:48 -0700)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/sc
From: Jason Wang
Date: Wed, 16 Jul 2014 14:21:44 +0800
> Hi all:
>
> This series introduces the support for rx busy polling support. This
> was useful for reduing the latency for a kvm guest. Patch 1-2
> introduces helpers which is used for rx busy polling. Patch 3
> implement the main function.
From: Benoit Taine
Date: Fri, 18 Jul 2014 17:26:47 +0200
> We should prefer `const struct pci_device_id` over
> `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
> This issue was reported by checkpatch.
>
> A simplified version of the semantic patch that makes this change is as
>
From: Jason Wang
Date: Wed, 23 Jul 2014 16:33:53 +0800
> This series introduces the support for rx busy polling support. This
> was useful for reduing the latency for a kvm guest. Instead of
> introducing new states and spinlocks, this series re-uses NAPI state
> to synchonrize between NAPI and b
From: "Michael S. Tsirkin"
Date: Sun, 10 Aug 2014 21:45:59 +0200
> On Sun, Aug 10, 2014 at 11:30:35AM +0300, Razya Ladelsky wrote:
...
> And, did your tests actually produce 100% load on both host CPUs?
...
Michael, please do not quote an entire patch just to ask a one line
question.
I truly,
From: Andy King
Date: Tue, 2 Sep 2014 13:13:44 -0700
> We should check if the map of the table actually succeeds, and also free
> resources accordingly.
>
> Version bumped to 1.2.1.0
>
> Acked-by: Shelley Gong
> Acked-by: Bhavesh Davda
> Signed-off-by: Andy King
> Reported-by: Tetsuo Handa
From: Rusty Russell
Date: Wed, 3 Sep 2014 13:59:13 +0930
> I resurrected these patches after prompting from Andy Lutomirski's
> recent patches. I put them on the back-burner because vring_bench
> had a 15% slowdown on my laptop: pktgen testing revealed a speedup,
> if anything, so I've cleaned
From: "Michael S. Tsirkin"
Date: Sun, 5 Oct 2014 19:07:13 +0300
> Now that virtio core ensures config changes don't arrive during probing,
> drop config_enable flag in virtio net.
> On removal, flush is now sufficient to guarantee that no change work is
> queued.
>
> This help simplify the drive
From: "Michael S. Tsirkin"
Date: Tue, 7 Oct 2014 09:49:15 +0300
> On Mon, Oct 06, 2014 at 03:02:38PM -0400, David Miller wrote:
>> From: "Michael S. Tsirkin"
>> Date: Sun, 5 Oct 2014 19:07:13 +0300
>>
>> > Now that virtio core ensures con
From: Jason Wang
Date: Sat, 11 Oct 2014 15:16:43 +0800
> We free old transmitted packets in ndo_start_xmit() currently, so any
> packet must be orphaned also there. This was used to reduce the overhead of
> tx interrupt to achieve better performance. But this may not work for some
> protocols suc
From: "Michael S. Tsirkin"
Date: Wed, 15 Oct 2014 16:23:28 +0300
> You used __netif_subqueue_stopped but that seems to use
> a slightly more expensive test_bit internally.
More expensive in what sense? It should be roughly the same
as "x & y" sans the volatile.
Anyways I'm ambivalent and I wan
From: Ben Hutchings
Date: Thu, 30 Oct 2014 18:26:32 +
> The virtio net protocol supports UFO but does not provide for passing a
> fragment ID for fragmentation of IPv6 packets. We used to generate a
> fragment ID wherever such a packet was fragmented, but currently we
> always use ID=0!
>
>
From: "Michael S. Tsirkin"
Date: Tue, 11 Nov 2014 17:57:50 +0200
> Basically userspace assumed that features will only
> ever be added, never removed, so this change is
> breaking it.
I essentially agree.
We can't just toss feature bits like this which have been present for so
long.
"There is
From: Ben Hutchings
Date: Tue, 11 Nov 2014 17:12:58 +
> This reverts commit 88e0e0e5aa722b193c8758c8b45d041de5316924 for
> the tap drivers, but leaves UFO disabled in virtio_net.
>
> libvirt at least assumes that tap features will never be dropped
> in new kernel versions, and doing so preve
From: Jason Wang
Date: Wed, 19 Nov 2014 17:21:46 +0800
> More compact, looks good. Thanks
I am assuming there is therefore a V3 of this patch forthcoming.
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoun
From: Jason Wang
Date: Thu, 20 Nov 2014 17:03:05 +0800
> We currently trigger BUG when VIRTIO_NET_F_CTRL_VQ
> is not set but one of features depending on it is.
> That's not a friendly way to report errors to
> hypervisors.
> Let's check, and fail probe instead.
>
> Cc: Rusty Russell
> Cc: Corn
From: Jason Wang
Date: Thu, 27 Nov 2014 14:41:21 +0800
> Signed-off-by: Jason Wang
I don't think generic vhost patches should go via my tree.
If you disagree, let me know why, thanks :)
___
Virtualization mailing list
Virtualization@lists.linux-found
From: Jason Wang
Date: Wed, 24 Dec 2014 11:03:52 +0800
> There's no need to do header check for virtio-net since:
>
> - Host sets dodgy for all gso packets from guest and check the header.
> - Host should be prepared for all kinds of evil packets from guest, since
> malicious guest can send an
From: Ben Hutchings
Date: Tue, 27 Jan 2015 02:47:54 +
> On Mon, 2015-01-26 at 09:37 -0500, Vladislav Yasevich wrote:
>> If the IPv6 fragment id has not been set and we perform
>> fragmentation due to UFO, select a new fragment id.
>> When we store the fragment id into skb_shinfo, set the bit
From: Vladislav Yasevich
Date: Fri, 30 Jan 2015 14:27:24 -0500
> commit 3d0ad09412ffe00c9afa201d01effdb6023d09b4
> Author: Ben Hutchings
> Date: Thu Oct 30 18:27:12 2014 +
>
> drivers/net: Disable UFO through virtio
>
> Turned off UFO support to virtio-net based devices due to issues
From: David Miller
Date: Sun, 01 Feb 2015 22:19:35 -0800 (PST)
> Series applied and queued up for -stable.
I have to revert, this breaks the build.
net/built-in.o: In function `udp6_ufo_fragment':
udp_offload.c:(.text+0x103380): undefined reference to `ipv6_sele
Vlad, this still fails the same way.
[davem@dokdo net]$ make -s -j8
kernel/Makefile:132: *** No X.509 certificates found ***
kernel/Makefile:132: *** No X.509 certificates found ***
net/built-in.o: In function `udp6_ufo_fragment':
udp_offload.c:(.text+0x103514): undefined reference to `ipv6_selec
From: David Miller
Date: Mon, 02 Feb 2015 13:11:58 -0800 (PST)
> Vlad, this still fails the same way.
...
> Please build allmodconfig, that is the exact build I use to test your
> and everyone else's changes.
Oh, also, there is trailing whitespace in one of the comments add
From: Vladislav Yasevich
Date: Tue, 3 Feb 2015 16:36:15 -0500
> diff --git a/net/ipv6/output_core.c b/net/ipv6/output_core.c
> index 97f41a3..54520a0 100644
> --- a/net/ipv6/output_core.c
> +++ b/net/ipv6/output_core.c
> @@ -9,6 +9,24 @@
> #include
> #include
>
> +u32 __ipv6_select_ident(u
From: "Michael S. Tsirkin"
Date: Tue, 3 Feb 2015 11:07:06 +0200
> In virtio 1.0 mode, when mergeable buffers are enabled on a big-endian
> host, num_buffers wasn't byte-swapped correctly, so large incoming
> packets got corrupted.
>
> To fix, fill it in within hdr - this also makes sure it gets
From: Jason Wang
Date: Sun, 15 Feb 2015 16:35:17 +0800
> In commit ba7438aed924 ("vhost: don't bother copying iovecs in
> handle_rx(), kill memcpy_toiovecend()"), we advance iov iter fixup
> sizeof(struct virtio_net_hdr) bytes and fill the number of buffers
> after doing the socket recvmsg(). Thi
From: "Michael S. Tsirkin"
Date: Tue, 24 Feb 2015 17:31:10 +0100
> The 2 that we use for copy_to_iter comes from sizeof(u16),
> it used to be that way before the iov iter update.
> Fix it up, making it obvious the size of stack access
> is right.
>
> Signed-off-by: Michael S. Tsirkin
Michael,
From: "Michael S. Tsirkin"
Date: Tue, 24 Feb 2015 17:31:31 +0100
> Recent iterator-related changes in vhost made it
> harder to follow the logic fixing up the header.
> In fact, the fixup always happens at the same
> offset: sizeof(virtio_net_hdr): sometimes the
> fixup iterator is updated by cop
From: "Michael S. Tsirkin"
Date: Tue, 24 Feb 2015 17:31:10 +0100
> The 2 that we use for copy_to_iter comes from sizeof(u16),
> it used to be that way before the iov iter update.
> Fix it up, making it obvious the size of stack access
> is right.
>
> Signed-off-by: Michael S. Tsirkin
Applied.
From: "Michael S. Tsirkin"
Date: Thu, 12 Mar 2015 08:25:34 +0100
> On Thu, Mar 12, 2015 at 01:57:44PM +0800, Jason Wang wrote:
>> We don't delete napi from hash list during module exit. This will
>> cause the following panic when doing module load and unload:
...
>> This patch fixes this by doin
From: Stephen Hemminger
Date: Tue, 24 Mar 2015 16:22:07 -0700
> The original comment was not really informative or funny
> as well as sexist. Replace it with a better explanation of
> why the driver does stop and what the impacts are.
>
> Signed-off-by: Stephen Hemminger
Applied, but _only_ be
From: Rusty Russell
Date: Wed, 25 Mar 2015 14:29:38 +1030
> I note that there's still no comment saying "don't do this" in
> netdevice.h; I gather returning NETDEV_TX_BUSY is still considered a Bad
> Thing?
You're not supposed to do it still, that's right.
If the driver returns NETDEV_TX_BUSY i
From: Jason Wang
Date: Fri, 28 Dec 2018 15:55:37 +0800
> +static int vhost_invalidate_vmap(struct vhost_virtqueue *vq,
> + struct vhost_vmap *map,
> + unsigned long uaddr,
> + unsigned long start,
> +
From: "Michael S. Tsirkin"
Date: Mon, 14 Jan 2019 20:34:26 -0500
> Use napi_consume_skb() to get bulk free. Note that napi_consume_skb is
> safe to call in a non-napi context as long as the napi_budget flag is
> correct.
>
> Signed-off-by: Michael S. Tsirkin
> ---
>
> My perf testing setup is
From: Zha Bin
Date: Tue, 8 Jan 2019 16:07:03 +0800
> The vsock core only supports 32bit CID, but the Virtio-vsock spec define
> CID (dst_cid and src_cid) as u64 and the upper 32bits is reserved as
> zero. This inconsistency causes one bug in vhost vsock driver. The
> scenarios is:
>
> 0. A ha
From: Jason Wang
Date: Wed, 16 Jan 2019 16:54:42 +0800
> Vhost dirty page logging API is designed to sync through GPA. But we
> try to log GIOVA when device IOTLB is enabled. This is wrong and may
> lead to missing data after migration.
>
> To solve this issue, when logging with device IOTLB ena
From: Jason Wang
Date: Wed, 16 Jan 2019 16:54:42 +0800
> Vhost dirty page logging API is designed to sync through GPA. But we
> try to log GIOVA when device IOTLB is enabled. This is wrong and may
> lead to missing data after migration.
>
> To solve this issue, when logging with device IOTLB ena
From: "Michael S. Tsirkin"
Date: Thu, 17 Jan 2019 23:20:07 -0500
> Use napi_consume_skb() to get bulk free. Note that napi_consume_skb is
> safe to call in a non-napi context as long as the napi_budget flag is
> correct.
>
> Signed-off-by: Michael S. Tsirkin
Applied, thanks.
_
From: "Michael S. Tsirkin"
Date: Wed, 23 Jan 2019 08:58:07 -0500
> On Wed, Jan 23, 2019 at 05:55:52PM +0800, Jason Wang wrote:
>> This series tries to access virtqueue metadata through kernel virtual
>> address instead of copy_user() friends since they had too much
>> overheads like checks, spec
From: Jason Wang
Date: Wed, 23 Jan 2019 17:55:52 +0800
> This series tries to access virtqueue metadata through kernel virtual
> address instead of copy_user() friends since they had too much
> overheads like checks, spec barriers or even hardware feature
> toggling.
>
> Test shows about 24% imp
From: "Michael S. Tsirkin"
Date: Tue, 29 Jan 2019 17:54:44 -0500
> On Mon, Jan 28, 2019 at 10:54:44PM -0800, David Miller wrote:
>> From: Jason Wang
>> Date: Mon, 28 Jan 2019 15:05:05 +0800
>>
>> > After batched used ring updating was introduced in com
From: David Miller
Date: Tue, 29 Jan 2019 15:10:26 -0800 (PST)
> Yeah the CVE pushed my hand a little bit, and I knew I was going to
> send Linus a pull request today because David Watson needs some TLS
> changes in net-next.
I also want to make a general comment for the record.
From: Jason Wang
Date: Mon, 28 Jan 2019 15:05:05 +0800
> After batched used ring updating was introduced in commit e2b3b35eb989
> ("vhost_net: batch used ring update in rx"). We tend to batch heads in
> vq->heads for more than one packet. But the quota passed to
> get_rx_bufs() was not correctly
From: "Michael S. Tsirkin"
Date: Thu, 31 Jan 2019 10:25:17 -0500
> On Thu, Jan 31, 2019 at 08:40:30PM +0900, Toshiaki Makita wrote:
>> Previously virtnet_xdp_xmit() did not account for device tx counters,
>> which caused confusions.
>> To be consistent with SKBs, account them on freeing xdp_frame
From: "Michael S. Tsirkin"
Date: Tue, 29 Jan 2019 20:36:31 -0500
> If it helps I can include most virtio stuff in my pull requests instead.
> Or if that can't work since there's too often a dependency on net-next,
> maybe Jason wants to create a tree and send pull requests to you. Let
> us know
From: Toshiaki Makita
Date: Tue, 29 Jan 2019 09:45:52 +0900
> While I'm looking into how to account standard tx counters on XDP tx
> processing, I found several bugs around XDP tx and napi_tx.
>
> Patch1: Fix oops on error path. Patch2 depends on this.
> Patch2: Fix memory corruption on freeing
From: Stefano Garzarella
Date: Fri, 1 Feb 2019 12:42:05 +0100
> These patches try to handle the hot-unplug of vsock virtio transport device in
> a proper way.
>
> Maybe move the vsock_core_init()/vsock_core_exit() functions in the
> module_init
> and module_exit of vsock_virtio_transport modul
From: Toshiaki Makita
Date: Thu, 31 Jan 2019 20:40:30 +0900
> Previously virtnet_xdp_xmit() did not account for device tx counters,
> which caused confusions.
> To be consistent with SKBs, account them on freeing xdp_frames.
>
> Reported-by: David Ahern
> Signed-off-by: Toshiaki Makita
Applie
From: Jason Wang
Date: Fri, 15 Feb 2019 15:53:24 +0800
> When fail, translate_desc() returns negative value, otherwise the
> number of iovs. So we should fail when the return value is negative
> instead of a blindly check against zero.
>
> Reported-by: Stephen Hemminger
> Fixes: cc5e71075947 ("
From: Jason Wang
Date: Tue, 19 Feb 2019 14:53:44 +0800
> When fail, translate_desc() returns negative value, otherwise the
> number of iovs. So we should fail when the return value is negative
> instead of a blindly check against zero.
>
> Detected by CoverityScan, CID# 1442593: Control flow is
Why did you send this three times?
What's different in each of these copies?
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
From: "Michael S. Tsirkin"
Date: Mon, 11 Mar 2019 09:59:28 -0400
> On Mon, Mar 11, 2019 at 03:13:17PM +0800, Jason Wang wrote:
>>
>> On 2019/3/8 下午10:12, Christoph Hellwig wrote:
>> > On Wed, Mar 06, 2019 at 02:18:07AM -0500, Jason Wang wrote:
>> > > This series tries to access virtqueue metadat
From: Peter Xu
Date: Mon, 18 Mar 2019 14:56:06 +0800
> The variable is never used.
>
> CC: Michael S. Tsirkin
> CC: Jason Wang
> CC: virtualization@lists.linux-foundation.org
> CC: net...@vger.kernel.org
> CC: linux-ker...@vger.kernel.org
> Signed-off-by: Peter Xu
This looks rather uncontrov
101 - 200 of 536 matches
Mail list logo
