Re: [PATCH 2/2] virtio-fs: add multi-queue support

2024-05-28 Thread Jingbo Xu
On 5/28/24 10:21 PM, Peter-Jan Gootzen wrote: > On Tue, 2024-05-28 at 21:35 +0800, Jingbo Xu wrote: >> External email: Use caution opening links or attachments >> >> >> On 5/28/24 7:59 PM, Miklos Szeredi wrote: >>> On Tue, 28 May 2024 at 10:52, Jingbo Xu >>> wrote: Hi Peter-Jan,

Re: [PATCH 2/2] virtio-fs: add multi-queue support

2024-05-28 Thread Peter-Jan Gootzen
On Tue, 2024-05-28 at 21:35 +0800, Jingbo Xu wrote: > External email: Use caution opening links or attachments > > > On 5/28/24 7:59 PM, Miklos Szeredi wrote: > > On Tue, 28 May 2024 at 10:52, Jingbo Xu > > wrote: > > > > > > Hi Peter-Jan, > > > > > > Thanks for the amazing work. > > > > > >

Re: [PATCH 2/2] virtio-fs: add multi-queue support

2024-05-28 Thread Jingbo Xu
On 5/28/24 7:59 PM, Miklos Szeredi wrote: > On Tue, 28 May 2024 at 10:52, Jingbo Xu wrote: >> >> Hi Peter-Jan, >> >> Thanks for the amazing work. >> >> I'd just like to know if you have any plan of making fiq and fiq->lock >> more scalable, e.g. make fiq a per-CPU software queue? > > Doing a p

Re: [PATCH 2/2] virtio-fs: add multi-queue support

2024-05-28 Thread Miklos Szeredi
On Tue, 28 May 2024 at 14:39, Peter-Jan Gootzen wrote: > I am not that familiar yet with the FUSE driver. What are these > listeners you are referring to? If I follow a FUSE file system operation > like fuse_statfs, I see a single-threaded path towards the > wake_pending_and_unlock of virtio-fs v

Re: [PATCH 2/2] virtio-fs: add multi-queue support

2024-05-28 Thread Peter-Jan Gootzen
On Tue, 2024-05-28 at 13:59 +0200, Miklos Szeredi wrote: > External email: Use caution opening links or attachments > > > On Tue, 28 May 2024 at 10:52, Jingbo Xu > wrote: > > > > Hi Peter-Jan, > > > > Thanks for the amazing work. > > > > I'd just like to know if you have any plan of making fi

Re: [PATCH 2/2] virtio-fs: add multi-queue support

2024-05-28 Thread Miklos Szeredi
On Tue, 28 May 2024 at 10:52, Jingbo Xu wrote: > > Hi Peter-Jan, > > Thanks for the amazing work. > > I'd just like to know if you have any plan of making fiq and fiq->lock > more scalable, e.g. make fiq a per-CPU software queue? Doing a per-CPU queue is not necessarily a good idea: async request

Re: [PATCH 1/2] virtio-fs: limit number of request queues

2024-05-28 Thread Jingbo Xu
On 5/28/24 5:05 PM, Peter-Jan Gootzen wrote: > Hi Jingbo, > > On Tue, 2024-05-28 at 16:40 +0800, Jingbo Xu wrote: >> External email: Use caution opening links or attachments >> >> >> Hi Peter-Jan, >> >> Thanks for the amazing work! Glad to see it is upstreamed.  We are >> also >> planning distr

Re: [PATCH 1/2] virtio-fs: limit number of request queues

2024-05-28 Thread Peter-Jan Gootzen
Hi Jingbo, On Tue, 2024-05-28 at 16:40 +0800, Jingbo Xu wrote: > External email: Use caution opening links or attachments > > > Hi Peter-Jan, > > Thanks for the amazing work! Glad to see it is upstreamed.  We are > also > planning distribute virtiofs on DPU. Great to hear that virtio-fs is gett

Re: [PATCH 2/2] virtio-fs: add multi-queue support

2024-05-28 Thread Jingbo Xu
Hi Peter-Jan, Thanks for the amazing work. I'd just like to know if you have any plan of making fiq and fiq->lock more scalable, e.g. make fiq a per-CPU software queue? I think the global fiq and fiq->lock can be a performance bottleneck after we have supported mq. -- Thanks, Jingbo

Re: [PATCH 1/2] virtio-fs: limit number of request queues

2024-05-28 Thread Jingbo Xu
Hi Peter-Jan, Thanks for the amazing work! Glad to see it is upstreamed. We are also planning distribute virtiofs on DPU. BTW I have some questions when reading the patch, appreciate if you could give a hint. On 5/1/24 11:38 PM, Peter-Jan Gootzen wrote: > Virtio-fs devices might allocate signi