Re: [PATCH v2 19/37] mm/gup: remove record_subpages()

2025-09-06 Thread John Hubbard
On 9/5/25 11:56 PM, David Hildenbrand wrote: On 06.09.25 03:05, John Hubbard wrote: On 9/1/25 8:03 AM, David Hildenbrand wrote: ...> Well, there is a lot I dislike about record_subpages() to go back there. Starting with "as Willy keeps explaining, the concept of subpages do not exist and endin

Re: [PATCH v2 19/37] mm/gup: remove record_subpages()

2025-09-06 Thread David Hildenbrand
pmdp = pmd_offset_lockless(pudp, pud, addr); @@ -3046,23 +3041,21 @@ static int gup_fast_pmd_range(pud_t *pudp, pud_t pud, unsigned long addr, next = pmd_addr_end(addr, end); if (!pmd_present(pmd)) - return 0; + brea

Re: [PATCH v2 19/37] mm/gup: remove record_subpages()

2025-09-06 Thread David Hildenbrand
On 06.09.25 03:05, John Hubbard wrote: On 9/1/25 8:03 AM, David Hildenbrand wrote: We can just cleanup the code by calculating the #refs earlier, so we can just inline what remains of record_subpages(). Calculate the number of references/pages ahead of times, and record them only once all our t