vlc | branch: master | Lyndon Brown <jnq...@gmail.com> | Sat Apr 6 19:01:08 2019 +0100| [1ca5bfaa1901551618ccac5fa97ac40babde7ab3] | committer: Jean-Baptiste Kempf
core: fix some option misplacement in preferences the Qt GUI builds its tree based upon cats/subcats used specifically within the core option set only; if one is not used in the core set, then any plugins with options belonging to such cats/subcats are mishandled. it is necessary (for the time being) to ensure that entries exist for all cats/subcats in the core set, even if there are no options in the core set beneath them, in order to fix this issue. a refactor of certain aspects of preference category handling (already complete) will be submitted later. three entries were missing: - video splitter (since 5c18cff8d8cdba5784ca4bdb641fb483499117ed) - audio misc (since 2005: 2e3847698a715d877bf4506f4d100ba927ca0696) - advanced network (since 2012: e3c92d77d4eb45ac5029f656217b713a1f11685f) the missing use of the splitter video subcat entry caused entries for splitter plugins (wall; clone; panoramix) to be misplaced, appearing directly under the videos cat. no in-tree plugins currently use the audio-misc subcat. the missing advanced-network subcat entry caused the gnu-tls plugin (on my system) to be misplaced directly under the main 'advanced' category. Signed-off-by: Jean-Baptiste Kempf <j...@videolan.org> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=1ca5bfaa1901551618ccac5fa97ac40babde7ab3 --- src/libvlc-module.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/libvlc-module.c b/src/libvlc-module.c index 01eef61a3b..6f2e48778f 100644 --- a/src/libvlc-module.c +++ b/src/libvlc-module.c @@ -1603,6 +1603,7 @@ vlc_module_begin () add_module("audio-resampler", "audio resampler", NULL, AUDIO_RESAMPLER_TEXT, AUDIO_RESAMPLER_LONGTEXT) + set_subcategory( SUBCAT_AUDIO_MISC ) /* Video options */ set_category( CAT_VIDEO ) @@ -1720,6 +1721,8 @@ vlc_module_begin () add_module_list("video-filter", "video filter", NULL, VIDEO_FILTER_TEXT, VIDEO_FILTER_LONGTEXT) + set_subcategory( SUBCAT_VIDEO_SPLITTER ) + #if 0 add_string( "pixel-ratio", "1", PIXEL_RATIO_TEXT, PIXEL_RATIO_TEXT ) #endif @@ -2141,6 +2144,8 @@ vlc_module_begin () change_string_list( clock_sources, clock_sources_text ) #endif + set_subcategory( SUBCAT_ADVANCED_NETWORK ) + /* Playlist options */ set_category( CAT_PLAYLIST ) set_subcategory( SUBCAT_PLAYLIST_GENERAL ) _______________________________________________ vlc-commits mailing list vlc-commits@videolan.org https://mailman.videolan.org/listinfo/vlc-commits