Hi Damjan/Dave.
> You will end up with layering violation and bloatig driver code. Please dont
> go there.
Ok. My motivation is the error packet should be dropped at the earliest. i.e
- In device-input node, if interface is not in L2 brdge or in L2XC config then
drop all error packets in
The only thing worth considering is to teach the ip4/6 input paths to skip work
which the h/w and driver can do. As in: make a variant of ip4-input-no-checksum
["ip4-input-no-checksum-no-ttl-no-fragment-no-"] by adding additional
compile-time-constant arguments to the ip4-input inline and
—
Damjan
> On 22 Sep 2018, at 16:10, Nitin Saxena wrote:
>
> Thanks Dave for the detailed answers.
>
>> Patches which skip ANY of the work described above will not be merged.
> Understood. Intention is not to break functionality/security at all.
>
>> You would have to pull a bunch of work
Thanks Dave for the detailed answers.
> Patches which skip ANY of the work described above will not be merged.
Understood. Intention is not to break functionality/security at all.
> You would have to pull a bunch of work back into the device driver: counting
> IP packet errors, head of ip4/6
You would have to pull a bunch of work back into the device driver: counting IP
packet errors, head of ip4/6 unicast/multicast input feature arcs, and
mandatory input checks (expired TTL, ip header length, fragment).
Hardware offload will NOT accomplish all of these tasks. If by chance you can
Dear vpp
Patch 14848 is verified, Please review and give me some comments.
Cheers
On Mon, Sep 17, 2018 at 12:10 PM khers wrote:
> Dear vpp
>
> we set speed and duplex In function dpdk_update_link_state, although
> When link_status is down, speed and duplex is unknown.
> So I commit my
