Re: [vpp-dev] Packet processing time.

2020-04-18 Thread Dave Barach via lists.fd.io
If you turn on the main loop dispatch event logs and look at the results in the g2 viewer [or dump them in ascii] you can make pretty accurate lap time estimates for any workload. Roughly speaking, packets take 1 lap time to arrive and then leave. The “circuit-node ” game produces one elog even

[vpp-dev] Packet processing time.

2020-04-18 Thread Christian Hopps
The recent discussion on reference counting and barrier timing has got me interested in packet processing time. I realize there's a way to use "show runtime" along with knowledge of the arc a packet follows, but I'm curious if something more straight-forward has been attempted where packets are

Re: [vpp-dev] Iperf3 throughtput with vcl on vpp-20.05-rc0 is only half of vpp-20.01

2020-04-18 Thread Florin Coras
Hi, >From your vcl configs it seems your fifo sizes are only 32kB. You should >probably increase those, for instance, try with 1MB. If that’s not the issue, other suggestions: - try to pin with taskset iperf to a cpu on the same numa as your nic (check that with sh hardware) - dump the state

Re: [vpp-dev] Checkstyle script not work in ubuntu

2020-04-18 Thread Klement Sekera via lists.fd.io
If you have a more-indent-like config, feel free to update .clang_format in tree … > On 18 Apr 2020, at 18:05, Christian Hopps wrote: > > +1 for clang format. > > Regarding the in tree .clang-format, I had to use my own .clang_format > settings though as the VPP/C++ version has different tab

Re: [vpp-dev] Checkstyle script not work in ubuntu

2020-04-18 Thread Christian Hopps
+1 for clang format. Regarding the in tree .clang-format, I had to use my own .clang_format settings though as the VPP/C++ version has different tab defaults from the indent default currently used in VPP (never use and 4 space vs always use and 8 space). Thanks, Chris. > On Apr 18, 2020, at 7:

Re: [vpp-dev] worker barrier state

2020-04-18 Thread Christian Hopps
Perhaps useful noting that our meeting was about a month ago, and had focused on the similar "4" like approach (albeit using the generation number) independently as well. I'd still like to get some more timing information on barrier timings vs ref-counting though. Are a few clocks for reference

[vpp-dev] perftest stuck: "do_not_use_dut2_ssd_failure"

2020-04-18 Thread Dave Barach via lists.fd.io
Folks, I kicked off a "perftest-3n-skx" run for https://gerrit.fd.io/r/c/vpp/+/26549. 24 hours later, the job is still stuck: 07:58:00 +++ python3 /w/workspace/vpp-csit-verify-perf-master-3n-skx/csit/resources/tools/scripts/topo_reservation.py -t /w/workspace/vpp-csit-verify-perf-master-3n-sk

Re: [vpp-dev] Checkstyle script not work in ubuntu

2020-04-18 Thread Klement Sekera via lists.fd.io
clang-format can be tuned to emulate indent - it’s not 100% perfect match, but I’ve been using it for some time to format multi-line macros, e.g. pool_foreach and it’s been doing a pretty good job. Config file for that is already in vpp source tree (vpp/.clang-format) and used as default for cpp

Re: [vpp-dev] Checkstyle script not work in ubuntu

2020-04-18 Thread Dave Barach via lists.fd.io
+1, this seems like a viable scheme to me. We’ll need to configure the underlying indent engine so that newly-indented code looks as much like the rest of the code as possible. The result below wouldn’t preclude automatic cherry-picking, but it would make everyone’s head explode, particularly i

[vpp-dev] Iperf3 throughtput with vcl on vpp-20.05-rc0 is only half of vpp-20.01

2020-04-18 Thread jiangxiaoming
[Edited Message Follows] Iperf3 throughtput with vcl on vpp-20.05-rc0 is only half of vpp-20.01. Below is the test topology: +-+  +-+ |iperf3/Server|  |iperf3/client| +-+  +-+ |

[vpp-dev] Iperf3 throughtput with vcl on vpp-20.05-rc0 is only half of vpp-20.01

2020-04-18 Thread jiangxiaoming
Iperf3 throughtput with vcl on vpp-20.05-rc0 is only half of vpp-20.01. Below is the test topology: +-+  +-+ |iperf3/Server| |iperf3/client| +-+  +-+ | | +-+ 

Re: [vpp-dev] Checkstyle script not work in ubuntu

2020-04-18 Thread Damjan Marion via lists.fd.io
And this is example of script, which just formats modified lines, instead of re-formating whole file, as we do today. With something like this, we can introduce new indent or even move to clang-format without the need to reformat old code…. https://github.com/llvm-mirror/clang/blob/master/tools

Re: [vpp-dev] Checkstyle script not work in ubuntu

2020-04-18 Thread Damjan Marion via lists.fd.io
If we decided to stick with old indent, which i still disagree that is right thing to do, can you just compile indent all the time and modify path so /opt/vpp/…/bin/ comes first. I really don’t like one more option in the top level Makefile. — Damjan > On 18 Apr 2020, at 10:29, Andrew Yourt

Re: [vpp-dev] Checkstyle script not work in ubuntu

2020-04-18 Thread Andrew Yourtchenko
I made https://gerrit.fd.io/r/#/c/vpp/+/22963/ that you can try and see how it works for you. It allows to install the “correct” version of indent into the build tree, so the rest of the system is unaffected. --a > On 11 Apr 2020, at 14:04, Dave Barach via lists.fd.io > wrote: > >  > The s