Re: [vpp-dev] Is the tcp connection timestamp updated too early

2021-03-31 Thread Florin Coras
Hi Yacan, Ah, I’m assuming subsequent packets are dropped with paws errors? Question then is, if an attacker manages to pass all segment validation checks, including tstamp, should we ignore tsval if the ack is not valid, although tsval is only used to validate segments (not acks)? As far as

Re: [vpp-dev] Is the tcp connection timestamp updated too early

2021-03-31 Thread liuyacan
Hi Florin,   when we use packetdrill to inject a bad packet with high tsval which ACK sequence is above SNDNXT,  we found that subsequent normal packet are not accepted. BR,yacan On 4/1/2021 11:29,Florin Coras wrote: Hi Yacan, We only update tc->tsval_recent if the

Re: [vpp-dev] Is the tcp connection timestamp updated too early

2021-03-31 Thread Florin Coras
Hi Yacan, We only update tc->tsval_recent if the segment is fine and tc->tsval_recent is less than rcv_opts.tsval, i.e., the new tsval moves forward. Even if the ack is dropped, we only use tsval_recent in paws check. On the other hand rcv_opts.tsecr is not used unless the ack is valid. Did

[vpp-dev] Is the tcp connection timestamp updated too early

2021-03-31 Thread liuyacan
Hi,     For ESTABLISHED tcp connection, its timestamp is updated in tcp_segment_validate()->tcp_options_parse(),     but if after this , the ACK field check failed,  then the packet  would be dropped.     Do we need to restore the timestamp of the connection ?Thanks,Yacan

Re: [vpp-dev] New Committer Proposal

2021-03-31 Thread Paul Vinciguerra
+1 > On Mar 31, 2021, at 1:58 PM, Damjan Marion via lists.fd.io > wrote: > >  > Dear VPP Committers, > > I would like to propose Roy Fan Zhang from Intel as a new VPP committer. > Fan made significant contributions to the VPP including the async crypto > infrastructure and crypto scheduler.

Re: [vpp-dev] New Committer Proposal

2021-03-31 Thread Ole Troan
+1 Ole > On 31 Mar 2021, at 19:58, Damjan Marion via lists.fd.io > wrote: > >  > Dear VPP Committers, > > I would like to propose Roy Fan Zhang from Intel as a new VPP committer. > Fan made significant contributions to the VPP including the async crypto > infrastructure and crypto

Re: [vpp-dev] New Committer Proposal

2021-03-31 Thread Matthew Smith via lists.fd.io
+1 -Matt On Wed, Mar 31, 2021 at 12:58 PM Damjan Marion via lists.fd.io wrote: > > Dear VPP Committers, > > I would like to propose Roy Fan Zhang from Intel as a new VPP committer. > Fan made significant contributions to the VPP including the async crypto > infrastructure and crypto

Re: [vpp-dev] New Committer Proposal

2021-03-31 Thread Andrew Yourtchenko
+1 --a > On 31 Mar 2021, at 19:58, Damjan Marion via lists.fd.io > wrote: > >  > Dear VPP Committers, > > I would like to propose Roy Fan Zhang from Intel as a new VPP committer. > Fan made significant contributions to the VPP including the async crypto > infrastructure and crypto

Re: [EXTERNAL] [vpp-dev] New Committer Proposal

2021-03-31 Thread Chris Luke via lists.fd.io
+1 -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Damjan Marion via lists.fd.io Sent: Wednesday, March 31, 2021 13:58 To: vpp-dev Cc: Zhang, Roy Fan Subject: [EXTERNAL] [vpp-dev] New Committer Proposal Dear VPP Committers, I would like to propose Roy Fan Zhang from Intel

Re: [vpp-dev] FDIO Maintenance - 2021-03-31 1700 UTC to 2200 UTC

2021-03-31 Thread Vanessa Valderrama
Maintenance is complete. All services are available. Thank you, Anton & Vanessa On 3/31/21 12:10 PM, Vanessa Valderrama wrote: > > Starting maintenance > > On 3/31/21 11:07 AM, Vanessa Valderrama wrote: >> >> Jenkins has been placed in shutdown mode in preparation for >> maintenance. Job will

Re: [vpp-dev] New Committer Proposal

2021-03-31 Thread Edward Warnicke
+1 On Wed, Mar 31, 2021 at 1:50 PM Florin Coras wrote: > +1 > > Florin > > > On Mar 31, 2021, at 10:58 AM, Damjan Marion via lists.fd.io me@lists.fd.io> wrote: > > > > > > Dear VPP Committers, > > > > I would like to propose Roy Fan Zhang from Intel as a new VPP committer. > > Fan made

Re: [vpp-dev] New Committer Proposal

2021-03-31 Thread Florin Coras
+1 Florin > On Mar 31, 2021, at 10:58 AM, Damjan Marion via lists.fd.io > wrote: > > > Dear VPP Committers, > > I would like to propose Roy Fan Zhang from Intel as a new VPP committer. > Fan made significant contributions to the VPP including the async crypto > infrastructure and crypto

Re: [vpp-dev] vppcom epoll half-closed tcp session

2021-03-31 Thread Florin Coras
Hi Vadim, Do you need to close rx and keep tx open, close tx and keep rx open, or both? Either way, you’re right that we don’t explicitly support tcp half-closes. Since tx close is equivalent to your app not sending more data, I guess you’re looking for a way to force the peer to stop

Re: [vpp-dev] New Committer Proposal

2021-03-31 Thread Dave Barach
+1... Dave -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Damjan Marion via lists.fd.io Sent: Wednesday, March 31, 2021 1:58 PM To: vpp-dev Cc: Zhang, Roy Fan Subject: [vpp-dev] New Committer Proposal Dear VPP Committers, I would like to propose Roy Fan Zhang from Intel

Re: [vpp-dev] New Committer Proposal

2021-03-31 Thread Dave Wallace
+1 On 3/31/2021 1:58 PM, Damjan Marion via lists.fd.io wrote: Dear VPP Committers, I would like to propose Roy Fan Zhang from Intel as a new VPP committer. Fan made significant contributions to the VPP including the async crypto infrastructure and crypto scheduler. Beside that I found that Fan

[vpp-dev] New Committer Proposal

2021-03-31 Thread Damjan Marion via lists.fd.io
Dear VPP Committers, I would like to propose Roy Fan Zhang from Intel as a new VPP committer. Fan made significant contributions to the VPP including the async crypto infrastructure and crypto scheduler. Beside that I found that Fan is active in the community, and willing to help. Please let me

Re: [vpp-dev] FDIO Maintenance - 2021-03-31 1700 UTC to 2200 UTC

2021-03-31 Thread Vanessa Valderrama
Starting maintenance On 3/31/21 11:07 AM, Vanessa Valderrama wrote: > > Jenkins has been placed in shutdown mode in preparation for > maintenance. Job will be terminated at 1700 UTC. > > Thank you, > > Vanessa > > > On 3/25/21 11:07 AM, Vanessa Valderrama wrote: >> >> *What:* >> >> * Jenkins

Re: [vpp-dev] vppcom epoll half-closed tcp session

2021-03-31 Thread Vadim Platonov via lists.fd.io
Hi Florin, I need to implement a tcp proxy based on vpp vcl and we want to support half-closed tcp sessions scenario. But as I can suggest by vpp source code there is no support for half-closed tcp sessions. Is there any plans for supporting half-closed tcp sessions? Regards, Vadim

Re: [vpp-dev] FDIO Maintenance - 2021-03-31 1700 UTC to 2200 UTC

2021-03-31 Thread Vanessa Valderrama
Jenkins has been placed in shutdown mode in preparation for maintenance. Job will be terminated at 1700 UTC. Thank you, Vanessa On 3/25/21 11:07 AM, Vanessa Valderrama wrote: > > *What:* > > * Jenkins (sandbox and production) > o OS and security updates > o Upgrade to 2.277.1 >