[vpp-dev] Memif can't link up after admin down

2021-11-09 Thread Daniel Béreš
Hello there, I pushed the patch for VPP-1959 and I would be grateful for a review.(The patch contains fix and test.) https://gerrit.fd.io/r/c/vpp/+/34320 Long story short: After command #set interface state memif0/0 down is called vnet_sw_interface_set_flags_helper() where on the end of functio

[vpp-dev] Fixing nat44ed vrf api handlers

2023-03-22 Thread Daniel Béreš
Hello Guys, I wrote a short patch to fix a couple api handlers for nat44ed [1] . ( https://gerrit.fd.io/r/c/vpp/+/38459 ) It was probably forgotten, so I'm reminding myself. I still have a question about whether it is possible to cherry-pick the patch to vpp v23.02 and 22.10. [1] https://gerr

Re: [vpp-dev] Fixing nat44ed vrf api handlers

2023-03-22 Thread Daniel Béreš
Thanks for the reasonable explanations. So the option could be splitting it into two patches. The first could fix replies and the second could contain a new experimental API nat44_ed_vrf_tables_send_details_v2. I think it might be okay after that. Daniel -=-=-=-=-=-=-=-=-=-=-=- Links: You rec

Re: [vpp-dev] Fixing nat44ed vrf api handlers

2023-03-27 Thread Daniel Béreš
I split it up and it's ready for review: https://gerrit.fd.io/r/c/vpp/+/38459 https://gerrit.fd.io/r/c/vpp/+/38551 I have last one question: In case API doesn't return all data (e.g nat44_ed_vrf_tables_send_details missing  table_vrf_id assign of value) and if I decide to add it. Is it consid

Re: [vpp-dev] Help needed in bringing up memif with shm_open.

2022-05-25 Thread Daniel Béreš via lists . fd . io
Hi, To sync up, can you run loopback example? I tried to reproduce your problem on 3.10.0-229.1.2.rt56.141.2.el7_1.x86_64 but I got different result. diff --git a/extras/libmemif/src/CMakeLists.txt b/extras/libmemif/src/CMakeLists.txt index ddb8a52..a11a65f 100644 --- a/extras/libmemif/src/CMa

Re: [vpp-dev] Memif performance

2022-11-14 Thread Daniel Béreš via lists . fd . io
Hi Praveen, >From what I heard in the past. Gomemif does not reach such a throughput as >libmemif. If I may give you advice, use Go-libmemif ( >https://github.com/FDio/govpp/tree/master/extras/libmemif ) instead of >Gomemif. Anyway I will look into it if there is something wrong with the >gome