Re: [vpp-dev] Running multiple VPP processes causing VAPI API failures

2022-12-14 Thread Klement Sekera
Hi, if you have two vpp instances running with same shm prefix, conflicts are to be expected. It’s possible that the second instance mangled file system entries for the first one. When running more than one vpp instance, you need to ensure that every one of those has a unique shared memory pref

Re: [vpp-dev] Replacing pycodestyle with black

2022-05-02 Thread Klement Sekera
e-python') that runs black against all of the '*.py' files in the repo and deprecate the 'test-checkstyle' target. Any objections? Thanks, -daw- On 5/2/22 4:08 PM, Ole Troan wrote: I’d be happy to have formatting consistency across the project. Cheers Ole On 2 May 2022

Re: [vpp-dev] Replacing pycodestyle with black

2022-05-02 Thread Klement Sekera
+Real Ole. On 2 May 2022, at 19:15, Klement Sekera via lists.fd.io<http://lists.fd.io> mailto:klement=graphiant@lists.fd.io>> wrote: Hi Dave, good catch about requirements.txt. Should be fixed now. I’m not sure how to proceed with rest of code, seems to be mostly Ole’s domai

Re: [vpp-dev] Replacing pycodestyle with black

2022-05-02 Thread Klement Sekera
t about the rest of the python code in the repo? Thanks, -daw- On 5/2/22 6:56 AM, Klement Sekera wrote: Hey vpp-dev, looking at our current code style and its PEP8 compliance I see a couple of issues 1.) it’s not really PEP8 compliant 2.) we have no test-fixstyle I decided to make it more PEP

[vpp-dev] Replacing pycodestyle with black

2022-05-02 Thread Klement Sekera
Hey vpp-dev, looking at our current code style and its PEP8 compliance I see a couple of issues 1.) it’s not really PEP8 compliant 2.) we have no test-fixstyle I decided to make it more PEP8 compliant and found out that to just fix W503 to W504 (per https://peps.python.org/pep-0008/#should-a-

Re: [vpp-dev] VPP build breaks if one directory contains @

2022-04-27 Thread Klement Sekera
Hi Renato, I see that some special char conversion cases are already covered in vapi_c_gen.py: 713 include_guard = "__included_%s" % ( 714 j.replace(".", "_").replace("/", "_").replace("-", "_").replace( 715 "+", "_")) 716 print("#ifndef %s" % include_guard) would yo

Re: [vpp-dev] NAT44-ed state machine

2022-03-18 Thread Klement Sekera
On 18 Mar 2022, at 18:46, Klement Sekera mailto:klem...@graphiant.com>> wrote: On 18 Mar 2022, at 18:43, Ole Troan mailto:otr...@employees.org>> wrote: On 18 Mar 2022, at 17:40, Klement Sekera mailto:klem...@graphiant.com>> wrote: I like the idea of VPP sending RST f

Re: [vpp-dev] NAT44-ed state machine

2022-03-18 Thread Klement Sekera
> On 18 Mar 2022, at 18:43, Ole Troan wrote: > > > >> On 18 Mar 2022, at 17:40, Klement Sekera wrote: >> >> I like the idea of VPP sending RST for cases where the session doesn’t exist >> or for some reason the state is invalid. >> >> It mi

Re: [vpp-dev] NAT44-ed state machine

2022-03-18 Thread Klement Sekera
On 18 Mar 2022, at 17:28, Miklós Tirpák mailto:miklos.tir...@emnify.com>> wrote: Getting back to some of the topics, The main concern about RST was to recover from a 3rd party sending RSTs into the session. This would require the sender to spoof the src IP, right? Are you aware of any scenar

Re: [vpp-dev] NAT44-ed state machine

2022-03-18 Thread Klement Sekera
> On 18 Mar 2022, at 12:18, otr...@employees.org wrote: > > Klement, > >>> Following up on this thread. >>> The changes in 34877 led to some undesired behaviour in the "real >>> world(tm)". >>> In the close pattern below it left sessions in established state, and >>> with

Re: [vpp-dev] NAT44-ed state machine

2022-03-18 Thread Klement Sekera
On 18 Mar 2022, at 11:46, otr...@employees.org wrote: Klement, Following up on this thread. The changes in 34877 led to some undesired behaviour in the "real world(tm)". In the close pattern below it left sessions in established state, and with a relatively low c

Re: [vpp-dev] NAT44-ed state machine

2022-03-18 Thread Klement Sekera
> On 18 Mar 2022, at 11:22, otr...@employees.org wrote: > > Thanks for quick replies Klement! > >>> Following up on this thread. >>> The changes in 34877 led to some undesired behaviour in the "real >>> world(tm)". >>> In the close pattern below it left sessions in established state, and with

Re: [vpp-dev] NAT44-ed state machine

2022-03-18 Thread Klement Sekera
st cut it off. Not sure how often this occurs in real world... Best regards, Ole > On 12 Jan 2022, at 21:38, Klement Sekera via lists.fd.io<http://lists.fd.io> > mailto:ksekera=cisco@lists.fd.io>> wrote: > > Dear vpp-dev, > > Based on below and after disc

Re: [vpp-dev] Meanings of different vector rates and questions about NAT44 handoff queue size

2022-03-17 Thread Klement Sekera
ongestion drop would increase after some queue size even if the packets pile up in the handoff queue. Could you please elaborate more on this? Best Wishes Pan ____ 发件人: Klement Sekera mailto:klem...@graphiant.com>> 发送时间: 2022年3月17日 14:59:58 收件人: Pan

Re: [vpp-dev] Meanings of different vector rates and questions about NAT44 handoff queue size

2022-03-17 Thread Klement Sekera
Hey, I can provide insight into the NAT bit. On 17 Mar 2022, at 06:06, Yueyang Pan via lists.fd.io mailto:yueyang.pan=epfl...@lists.fd.io>> wrote: Also I noticed size of handoff queue is very much important to the performance of NAT44 but I was wondering why the congestion

Re: [vpp-dev]: Unable to run make test

2022-02-04 Thread Klement Sekera
Also, running under root is a bad idea and not supported. Cheers, Klement On 4 Feb 2022, at 13:27, Ole Troan via lists.fd.io mailto:otroan=employees@lists.fd.io>> wrote: Rajith, Have you tried: make test-debug TEST=ip4 Cheers, Ole > On 4 Feb 2022, at 13:18, Rajith

Re: [vpp-dev] NAT44-ed state machine

2022-01-12 Thread Klement Sekera via lists.fd.io
Dear vpp-dev, Based on below and after discussion with both Miklos and Andrew I have implemented new TCP state tracking for endpoint-dependent NAT44. Most of the behavior is in line with RFC 7857 and 6146 except for VPP supporting session reopening while an old session is closed (meaning, both

Re: [vpp-dev] NAT44-ed state machine

2022-01-10 Thread Klement Sekera via lists.fd.io
Hi Miklos, I agree with your points and I think the whole tracking is non-rfc compliant. I’m implementing a better state machine and hoping to push a patch later today which would make it rfc compliant. For now I would not attempt to fix the bit flags … Thanks, Klement From: vpp-dev@lists.fd.

Re: [vpp-dev] Struggling with low vector size ( < 5-10) seeking expert advice

2021-11-22 Thread Klement Sekera via lists.fd.io
could > increase the vector size. > > Thank you > > - Pranab K Das > > On Fri, Nov 19, 2021 at 5:07 AM Klement Sekera -X (ksekera - PANTHEON TECH > SRO at Cisco) wrote: > Hey, > > Efficiency increases (a lot) with vector size, so pondering packet rates

Re: [vpp-dev] Struggling with low vector size ( < 5-10) seeking expert advice

2021-11-19 Thread Klement Sekera via lists.fd.io
Hey, Efficiency increases (a lot) with vector size, so pondering packet rates at low sizes doesn’t make much sense. Looking at vector size, you can tell how loaded VPP is. At your vector size, VPP is slacking off and efficiency is thus low, but it doesn’t matter, because you are not processing

[vpp-dev] upcoming change in nat44-ed static mapping API

2021-09-28 Thread Klement Sekera via lists.fd.io
Hi Matt/vpp-dev, I’m reaching out after discussion with Andrew regarding an upcoming change in behaviour of an API. Currently, when nat44_ed_add_del_static_mapping[_v2] is called, the supplied u8 protocol value is taken and silently converted into NAT_PROTOCOL_(TCP|UDP|ICMP|OTHER). Part of upco

Re: [vpp-dev] VPP C++ Plugin API

2021-06-21 Thread Klement Sekera via lists.fd.io
Hi James, On vpp master branch running vpp like this: env STARTUP_CONF=/home/ksekera/startup.conf make debug with ksekera@c984e4769eef ~> cat startup.conf unix { interactive cli-listen /run/vpp/cli.sock gid 1000 } plugins { plugin dpdk_plugin.so { disable } } and your code ksekera@c984e47

Re: [vpp-dev] vpp hangs with bfd configuration

2021-06-10 Thread Klement Sekera via lists.fd.io
Hi Sudhir, this looks like a FIB code issue, even though it manifests when using BFD. Last I knew, Neale was the FIB guy, not sure who is now… Thanks, Klement > On 10 Jun 2021, at 08:50, Sudhir CR via lists.fd.io > wrote: > > Hi All, > when we are trying to establish a BFD session between tw

Re: [vpp-dev] Make test help

2021-04-26 Thread Klement Sekera via lists.fd.io
Hi Govind, there is no explicit startup.conf used by test framework. All arguments are passed using VPP command line built setUpConstants() function of VppTestCase. Regards, Klement > On 23 Apr 2021, at 18:13, Govindarajan Mohandoss > wrote: > > Dear Maintainers, > I would like to enable a

Re: [vpp-dev] Thread safety issue in NAT plugin regarding counter for busy ports

2021-04-01 Thread Klement Sekera via lists.fd.io
Hi Elias, it’s spot on. I think all of it. Would you like to push an atomic-increment patch or should I? Thanks for spotting this!!! Klement > On 1 Apr 2021, at 13:39, Elias Rudberg wrote: > > Hello VPP experts, > > I think there is a thread safety issue in the NAT plugin regarding the > cou

[vpp-dev] make test-checkstyle-diff

2021-03-25 Thread Klement Sekera via lists.fd.io
Hi all, I’ve introduced a new checkstyle target, which should ease development. This one does a similar thing as test-checkstyle, but only on changed files. This is useful for local verification as it’s a bit faster and doesn’t pollute your screen with messages about checking unchanged files.

Re: [vpp-dev] tests - attach debug option available

2021-03-18 Thread Klement Sekera via lists.fd.io
papi executor class. The test > cases depend on the vppapiclient and the stats client. They should be the > only dependencies in the base class, anything else is a concrete > implementation detail. > > Paul > > > > On Tue, Mar 16, 2021 at 12:35 PM Klement Sekera via

[vpp-dev] tests - attach debug option available

2021-03-16 Thread Klement Sekera via lists.fd.io
Hi all, I implemented a new debug option for make test called ‘attach’. This has been requested a couple of times over the last few months and while it has some drawbacks, it also has advantages. It’s not merged yet. https://gerrit.fd.io/r/c/vpp/+/31663 As always make test-help is full of clu

Re: [vpp-dev] NAT44 how to control external address assignment from pool?

2021-02-23 Thread Klement Sekera via lists.fd.io
hanks for reply. > Looks like I shold craft this idea by myself ;-) > > The main problem for me - I'm network engeneer for past few years and do not > program much for this time on C, but I try to try craft new patch. > > Thanks in advance. > > От: Klement Sek

Re: [vpp-dev] NAT44 how to control external address assignment from pool?

2021-02-16 Thread Klement Sekera via lists.fd.io
an random address from the > pool) and preserve it for all new connections until the end of the session, > second client 10.0.0.5 -> next random address etc. > > Thanks in advance. > От: Klement Sekera -X (ksekera - PANTHEON TECH SRO at Cisco) > > Отправлено: 16 февраля 20

Re: [vpp-dev] NAT44 how to control external address assignment from pool?

2021-02-16 Thread Klement Sekera via lists.fd.io
Hi, let me chime in and explain a bit more. DET NAT also known as CGNAT (as in carrier-grade NAT) is designed to conform to LI (lawful intercept) requirements. So, if you, as an internet provider are required by law to be able to provide a user identification based on outside address + port mad

Re: [vpp-dev] VPP hanging and running out of memory due to infinite loop related to nat44-hairpinning

2020-12-03 Thread Klement Sekera via lists.fd.io
I can’t see how that could help as this is not a fragmented packet … ? Thanks, Klement > On 2 Dec 2020, at 23:57, Mrityunjay Kumar wrote: > > Guys, I am not sure , my input is helpful or not but the same issue was > triggered to me and we concluded it in a different way. > In your packet trac

Re: [vpp-dev] VPP hanging and running out of memory due to infinite loop related to nat44-hairpinning

2020-12-02 Thread Klement Sekera via lists.fd.io
Hi Elias, so there are two ways of solving this: 1. don’t support such a static mapping (i.e. refuse to create it) 2. make it work for #2 your snat_hairpinning fix might be the right idea. If there is really no change then there is no point doing an extra lookup right? Would you mind pushing i

Re: [vpp-dev] VPP hanging and running out of memory due to infinite loop related to nat44-hairpinning

2020-12-02 Thread Klement Sekera via lists.fd.io
Hi Elias, what is the point of such static mapping? What is the use case here? Thanks, Klement > On 2 Dec 2020, at 16:39, Elias Rudberg wrote: > > One scenario when this happens is when a UDP (or TCP) packet is sent > from a client on the inside with a destination IP address that matches > an

Re: [vpp-dev] replacing make test-checkstyle with black

2020-12-02 Thread Klement Sekera via lists.fd.io
I like the idea. Regarding maintainer pain: Q: are we now stuck forever with what we have because there will always be somebody facing some difficulties adopting? Thanks, Klement > On 2 Dec 2020, at 10:30, Andrew Yourtchenko wrote: > >> >> On 2 Dec 2020, at 10:27, Neale Ranns via lists.fd.

Re: RES: RES: RES: [vpp-dev] NAT memory usage problem for VPP 20.09 compared to 20.05 due to larger translation_buckets value

2020-11-30 Thread Klement Sekera via lists.fd.io
t; > Best regards > > -Mensagem original- > De: vpp-dev@lists.fd.io Em nome de Klement Sekera via > lists.fd.io > Enviada em: quinta-feira, 26 de novembro de 2020 18:16 > Para: Marcos - Mgiga > Cc: Elias Rudberg ; vpp-dev@lists.fd.io; > dmar...@me.com > Assunto: Re:

Re: RES: RES: [vpp-dev] NAT memory usage problem for VPP 20.09 compared to 20.05 due to larger translation_buckets value

2020-11-26 Thread Klement Sekera via lists.fd.io
Hi, memory settings are gone from startup.conf. As I already mentioned, those were pointless anyway as the tables now reside in main heap. Translation hash buckets are calculated automatically based on max sessions and max users parameters. Thanks, Klement > On 26 Nov 2020, at 21:50, Damjan M

Re: [vpp-dev] NAT memory usage problem for VPP 20.09 compared to 20.05 due to larger translation_buckets value

2020-11-26 Thread Klement Sekera via lists.fd.io
Hi Elias, mentioned formula was updated per guidance from Damjan: optimal number of bihash buckets is number of expected entries divided by 2.5 rounded to closest pow2 (might he higher or lower). Regarding memory usage: bihash code has been changed and now uses main heap. Consequently, it igno

Re: [vpp-dev] Increasing NAT worker handoff frame queue size NAT_FQ_NELTS to avoid congestion drops?

2020-11-16 Thread Klement Sekera via lists.fd.io
re strong reasons for keeping the queue short, > reasons I don't know about, that's why I'm asking. > > Best regards, > Elias > > > On Fri, 2020-11-13 at 15:14 +, Klement Sekera -X (ksekera - > PANTHEON TECH SRO at Cisco) wrote: >> Hi Elias, >> &

Re: Handoff design issues [Re: RES: RES: [vpp-dev] Increasing NAT worker handoff frame queue size NAT_FQ_NELTS to avoid congestion drops?]

2020-11-16 Thread Klement Sekera via lists.fd.io
ates around 255, I did see packet drops, but no congestion drops. >> >> HTH, >> Klement >> >>> On 13 Nov 2020, at 17:51, Marcos - Mgiga wrote: >>> >>> So you mean that this situation ( congestion drops) is most likely to occur >>> when t

Re: RES: RES: RES: [vpp-dev] Increasing NAT worker handoff frame queue size NAT_FQ_NELTS to avoid congestion drops?

2020-11-16 Thread Klement Sekera via lists.fd.io
ucing the number of VPP threads as an option to work this > issue around, since you would probably increase the vector rate per thread? > > Best Regards > > -Mensagem original- > De: vpp-dev@lists.fd.io Em nome de Klement Sekera via > lists.fd.io > Enviada em: se

Re: RES: RES: [vpp-dev] Increasing NAT worker handoff frame queue size NAT_FQ_NELTS to avoid congestion drops?

2020-11-13 Thread Klement Sekera via lists.fd.io
7:51, Marcos - Mgiga wrote: >> >> So you mean that this situation ( congestion drops) is most likely to occur >> when the system in general is idle than when it is processing a large amount >> of traffic? >> >> Best Regards >> >> Marcos >> >

Re: [vpp-dev] Increasing NAT worker handoff frame queue size NAT_FQ_NELTS to avoid congestion drops?

2020-11-13 Thread Klement Sekera via lists.fd.io
Hi Elias, I’ve already debugged this and came to the conclusion that it’s the infra which is the weak link. I was seeing congestion drops at mild load, but not at full load. Issue is that with handoff, there is uneven workload. For simplicity’s sake, just consider thread 1 handing off all the t

Re: [vpp-dev] ip full reassembly - is_custom_app field broken ?

2020-11-09 Thread Klement Sekera via lists.fd.io
Hi, I don’t. I can eventually write one of course. Or maybe you’d like to give it a try? It should be almost 1:1 to ip4 change … Thanks, Klement > On 9 Nov 2020, at 11:18, Satya Murthy wrote: > > Hi Klement, > > Do you have the similar changes for ip6_full_reassembly.c as well. > If so, Ca

Re: [vpp-dev] ip full reassembly - is_custom_app field broken ?

2020-09-10 Thread Klement Sekera via lists.fd.io
Hi, can you please check out/try out this patch to see if it suits your needs? https://gerrit.fd.io/r/c/vpp/+/28739 Currently there is no easy way to write a unit test for it, would be nice to have it confirmed that it works. Thanks, Klement > On 8 Sep 2020, at 19:34, Satya Murthy wrote:

Re: [vpp-dev] Q about VPP NAT

2020-09-10 Thread Klement Sekera via lists.fd.io
Hi Nick, NAT doesn’t do any periodic cleanups, relying on a LRU list to reap stale sessions. This is by design, as it avoids hickups in traffic rate. Observed behaviour with session moving to WAIT-CLOSED and then CLOSED state is based on RFC, there is no assumption whether FIN/ACK was actually

Re: [vpp-dev] ip full reassembly - is_custom_app field broken ?

2020-09-08 Thread Klement Sekera via lists.fd.io
That’s a very good point. Looking at vnet_buffer, there seems to be some space left in it for this case … 190 struct 191 {

Re: [vpp-dev] ip full reassembly - is_custom_app field broken ?

2020-09-08 Thread Klement Sekera via lists.fd.io
Hi Satya, so this is obviously unfinished. Would you mind writing the code for that? You just need to steal a piece of code from ip4_sv_reass.c to do that ;-) and then steer your packets at custom node. 986 /* *INDENT-OFF* */ 987 VLIB_REGIS

Re: [vpp-dev] Query on ip4-local / ip4-unicast Feature Arc sequence

2020-09-08 Thread Klement Sekera via lists.fd.io
Hi Satya, it’s also necessary to enable full reassembly feature along with your feature by calling ip4_full_reass_enable_disable_with_refcnt(). You can take a look at NAT code which already does that - snat_interface_add_del(). Regards, Klement > On 4 Sep 2020, at 14:48, Satya Murthy wrote:

Re: [vpp-dev] Query on Inner packet Fragmentation and Reassembly

2020-07-01 Thread Klement Sekera via lists.fd.io
Hi Murthy, yes it does. Code is in ip4_sv_reass.c or ip4_full_reass.c. First one is shallow reassembly (as in, know 5 tuple for all fragments with having to actually reassemble them), second one is full reassembly. Regards, Klement > On 1 Jul 2020, at 14:41, Satya Murthy wrote: > > Hi , > >

Re: [vpp-dev] Issue while pushing code for gerrit review

2020-06-24 Thread Klement Sekera via lists.fd.io
Type: fix needs to be on a separate line. Take a look at other commit messages for examples. > On 24 Jun 2020, at 10:42, Chinmaya Aggarwal wrote: > > Still not working for me. I executed > git commit -s --amend -m 'Type: fix sr: fix for SID index across segment > lists within a sr policy' >

Re: [vpp-dev] Issue while pushing code for gerrit review

2020-06-24 Thread Klement Sekera via lists.fd.io
Hi, just amend the commit message and add it by hand. Commit message must contain a line like Type: fix or Type: improvement or whatever is applicable. Regards, Klement > On 24 Jun 2020, at 10:31, Chinmaya Aggarwal wrote: > > After i commit my fix, i run the script ./extras/scripts/check

Re: [vpp-dev] Vapi causes vpp to crash #vapi

2020-06-09 Thread Klement Sekera via lists.fd.io
Hi, the issue was caused by a missing memset in shared memory allocation routine. After a few runs, newly allocated message in shared memory would no longer be zero, but random garbage as left over by previous messages, this was then used by vapi_c_test leading to crash. https://gerrit.fd.io/r

Re: [vpp-dev] NAT44 UDP sessions are not clearing

2020-06-03 Thread Klement Sekera via lists.fd.io
d out sessions: 0 > total sessions: 2904 > total tcp sessions: 2901 > total tcp established sessions: 1800 > total tcp transitory sessions: 1101 > total tcp transitory (WAIT-CLOSED) sessions: 0 > total tcp transitory (CLOSED) sessions: 0 > total udp sessions: 3 > total icmp ses

Re: [vpp-dev] NAT44 UDP sessions are not clearing

2020-06-02 Thread Klement Sekera via lists.fd.io
translations: 400 > max translations per user: 500 > > From my tests, each ip address can form as many sessions as needed as long as > the overall/total sessions stay under "max translations". > > Thanks! > > On Mon, Jun 1, 2020 at 12:47 AM Klement Sekera

Re: [vpp-dev] NAT44 UDP sessions are not clearing

2020-06-01 Thread Klement Sekera via lists.fd.io
Hi, as you can see almost all of NAT sessions are timed out. NAT will automatically free and reuse them when needed again. this line: > udp LRU min session timeout 5175 (now 161589) hints whether immediate reuse is possible. Minimum session timeout in the LRU list for UDP sessions is 5175, whil

Re: [vpp-dev] Segfault in 'vapi_type_msg_header1_t_ntoh()' with a C++ api client #vpp #vapi

2020-05-28 Thread Klement Sekera via lists.fd.io
Hey, swapping context makes no sense since context is for client - client generates whatever context it wants and vpp just copies it from request to response, so that client can match response with request. So there is no reason for client to swap it when sending the message and then swap it ba

Re: [vpp-dev] NAT44 does not work with fragmented ICMP packets

2020-05-26 Thread Klement Sekera via lists.fd.io
Thanks! I’ll push a patch. Regards, Klement > On 26 May 2020, at 12:33, Miklos Tirpak wrote: > > Yes, it works with ip0: > > vnet_buffer (b0)->ip.reass.is_non_first_fragment = >! !ip4_get_fragment_offset (ip0); > > Thanks, > Miklos > From: Klement Seker

Re: [vpp-dev] NAT44 does not work with fragmented ICMP packets

2020-05-26 Thread Klement Sekera via lists.fd.io
I think it’s enough if instead of vlib_buffer_get_current(b0) we just use ip0 (that already takes save_rewrite_length into consideration). Can you please test with this modification? Thanks, Klement > On 26 May 2020, at 11:51, Miklos Tirpak wrote: > > Hi, > > I think there is a problem in ip

Re: [vpp-dev] NAT44 does not work with fragmented ICMP packets

2020-05-26 Thread Klement Sekera via lists.fd.io
Hi Miklos, thanks for your message. If is_non_first_fragment is set to true then rewrite will not happen. Can you take a look at what happens in ip4_sv_reass_inline for the first packet/fragment? Setting that flag should be pretty fool-proof 498 const u32 fragment_first = ip4_get_

Re: [vpp-dev] NAT ED empty users dump #nat #nat44

2020-05-12 Thread Klement Sekera via lists.fd.io
ED NAT no longer has “user” concept and it doesn’t differentiate one session from another. (So technically the API works just fine). Even if we wanted to recreate that information it means to build a hash of “users” on the fly for API purpose, do the dump and then throw it away. I don’t see any

Re: [vpp-dev] NAT ED empty users dump #nat #nat44

2020-05-12 Thread Klement Sekera via lists.fd.io
Alexander, It seems that fixing existing API is a huge pain. What we could do is implement an API which dumps all the sessions and the client app could sort it out. How many sessions do you typically have? As by default APIs run in a stop-the-world state, having millions of sessions will stop a

Re: [vpp-dev] NAT ED empty users dump #nat #nat44

2020-05-12 Thread Klement Sekera via lists.fd.io
Hi Alexander, Understood. So when you get those sessions, what do you do with them? Thanks, Klement > On 12 May 2020, at 13:45, Alexander Chernavin via lists.fd.io > wrote: > > Hello Klement, > > I want to list all NAT sessions. In order to do that I used to call > VL_API_NAT44_USER_DUMP.

Re: [vpp-dev] NAT ED empty users dump #nat #nat44

2020-05-12 Thread Klement Sekera via lists.fd.io
Hi Alexander, thanks for your feedback. The concept of user was really used for quickly re-using existing sessions in NAT. With port-overloading, ports are no longer a precious resource and dropping “users” means not having to maintain an extra hash table. To better understand your problem, ca

Re: [vpp-dev] Checkstyle script not work in ubuntu

2020-04-18 Thread Klement Sekera via lists.fd.io
sion has different tab defaults from the > indent default currently used in VPP (never use and 4 space vs always use and > 8 space). > > Thanks, > Chris. > >> On Apr 18, 2020, at 7:55 AM, Klement Sekera via lists.fd.io >> wrote: >> >> clang-format

Re: [vpp-dev] Checkstyle script not work in ubuntu

2020-04-18 Thread Klement Sekera via lists.fd.io
clang-format can be tuned to emulate indent - it’s not 100% perfect match, but I’ve been using it for some time to format multi-line macros, e.g. pool_foreach and it’s been doing a pretty good job. Config file for that is already in vpp source tree (vpp/.clang-format) and used as default for cpp

Re: [vpp-dev] Storing vlib buffer index for later processing

2020-04-17 Thread Klement Sekera via lists.fd.io
You can reference reassembly code, which does something similar. e.g. ip4_sv_reass.c HTH, Klement > On 17 Apr 2020, at 18:03, Satya Murthy wrote: > > Hi , > > We are having a scenario to support as below and we would like to know what > we are doing here is correct or not. > > 1. Our graph

Re: [vpp-dev] Unit Test Results in Random directories

2020-03-17 Thread Klement Sekera via Lists.Fd.Io
Hi Neale, When originally designing this, I opted in for `mktemp` as that’s the usual way to avoid clashes as at that time I assumed that this might be used on boxes where there are multiple users and they might like to run tests in parallel. At that time I didn’t expect issues like multiple vp

Re: [vpp-dev] VRRP Unit Tests failing on Master Ubuntu

2020-03-12 Thread Klement Sekera via Lists.Fd.Io
There is also test/scripts/test-loop.sh which might some users better. Regards, Klement > On 12 Mar 2020, at 19:08, Dave Wallace wrote: > > Hi Matt, > > Your patch [0] verified, Ray +1'd it, and I merged it. > > In my investigation on Naginator retries, I found an unrelated gerrit change > [

Re: [vpp-dev] Build jobs failure with No problems were identified. If you know why this problem occurred, please add a suitable Cause for it.

2020-02-03 Thread Klement Sekera via Lists.Fd.Io
Hi Click the first link -> console output -> show all You’ll see test failures. You can run locally these tests by invoking “make test”. Once fixed, reupload your change. HTH..Klement > On 3 Feb 2020, at 14:44, Shiva Shankar wrote: > > Hi everyone, > I am seeing below error messages during

Re: [vpp-dev] BFD sends old remote discriminator in its control packet after session goes to DOWN state #vpp

2020-01-17 Thread Klement Sekera via Lists.Fd.Io
Hi, thank you for your report. Can you please apply this fix and verify that the behaviour is now correct? https://gerrit.fd.io/r/c/vpp/+/24388 Thanks, Klement > On 17 Jan 2020, at 07:04, sont...@gmail.com wrote: > > Hi, > > I have observed an incorrect behavior in BFD code of VPP. > I have

Re: [vpp-dev] Add test framework to pythonpath ?

2019-09-26 Thread Klement Sekera via Lists.Fd.Io
What IDE? Have you tried running it from make test-shell-debug? From: vpp-dev@lists.fd.io On Behalf Of Keith Burns Sent: Thursday, September 26, 2019 3:12 PM To: vpp-dev@lists.fd.io Subject: [vpp-dev] Add test framework to pythonpath ? Issue: IDE doesn't know what to do with: "from framework imp

Re: [vpp-dev] FD.io - Gerrit 2.16 Changes

2019-07-31 Thread Klement Sekera via Lists.Fd.Io
Hi Vanessa, I pushed a couple of changes via your suggested git push origin HEAD:refs/for/master%wip and I noticed that on all of these the verify jobs were (attempted to) run. One of the advantages of draft changes is that it doesn’t eat resources for pointless verify jobs. Thanks, Klement

[vpp-dev] false verified + 1 for gerrit jobs

2019-05-06 Thread Klement Sekera via Lists.Fd.Io
Hi all, I noticed a job getting a +1 even though some of the builds failed ... https://gerrit.fd.io/r/#/c/18444/ please note patch set 9 fd.io JJB Patch Set 9: Verified-1 Build Failed https://jenkins.fd.io/job/vpp-arm-verify-master-ubuntu1804/2459/ : FAILURE No problems were identified. I

Re: [vpp-dev] VPP unit test with multiple workers

2019-03-12 Thread Klement Sekera via Lists.Fd.Io
Hi, there was an attempt at this some time ago, but the patch was never merged and the infra has changed a lot in meanwhile so I don't think it's worth it to rebase it. The patch was to run every existing test in both single and multi worker scenarios. You could probably extend the concept of ext

[vpp-dev] osleap job failing

2019-02-26 Thread Klement Sekera via Lists.Fd.Io
Hello, I'm facing an issue with osleap job, it very frequently fails with 12:56:59 'indent' is already installed. 12:56:59 No update candidate for 'indent-2.2.11-lp150.1.5.x86_64'. The highest available version is already installed. 12:56:59 'python3-rpm-macros' not found in package names. Trying

Re: [vpp-dev] vapi msg send

2019-02-13 Thread Klement Sekera via Lists.Fd.Io
Your outlined procedure looks okay.. Maybe share some code? Quoting mhemmatp via Lists.Fd.Io (2019-02-12 22:30:34) >Klement,  thanks for your reply, our conversation was invisible to group I >posted it here. > >In general, in the procedure that I sent do you see a missing part to send

Re: [vpp-dev] vapi msg send

2019-02-12 Thread Klement Sekera via Lists.Fd.Io
What kind of message are you sending? You can take a look at /test/ext/vapi_c_test.c (or cpp) for example code. Quoting mhemmatp via Lists.Fd.Io (2019-02-12 15:07:12) > Hello all, > > I am going to use vapi to connect to a plugin in vpp. I am following this >instruction: > > 1- c

Re: [vpp-dev] IPsec doesn't work with aes-gcm ciphering

2019-01-30 Thread Klement Sekera via Lists.Fd.Io
Can you please try this patch and let me know if it fixes things for you? https://gerrit.fd.io/r/17163 Thanks, Klement Quoting Klement Sekera via Lists.Fd.Io (2019-01-30 11:08:12) > Hi, > > I see the issue, will come up with a patch shortly. > > Thanks, > Klement > >

Re: [vpp-dev] IPsec doesn't work with aes-gcm ciphering

2019-01-30 Thread Klement Sekera via Lists.Fd.Io
Hi, I see the issue, will come up with a patch shortly. Thanks, Klement Quoting Jan Gelety via Lists.Fd.Io (2019-01-30 10:22:18) >Hello vpp-dev team, > >  > >Our csit performance tests for Ipsec using aes-gcm ciphering started to >fail because created ipsec interface cannot get

Re: [vpp-dev] Python Tests

2019-01-04 Thread Klement Sekera via Lists.Fd.Io
Hi Paul, I believe it's okay to just add people as reviewers afterwards. Thanks, Klement Quoting Paul Vinciguerra (2019-01-03 18:16:42) >I am working on a change to cleanup some anti-patterns in the test >framework code, but the scope is significantly larger.   >[1]https://gerrit.fd.

Re: [vpp-dev] Ipv4 random reassembly failure on x86 and ARM

2018-12-20 Thread Klement Sekera via Lists.Fd.Io
Is this with https://gerrit.fd.io/r/#/c/16548/ merged? Quoting Juraj Linkeš (2018-12-20 12:09:12) >Hi Klement and vpp-dev, > >  > >[1]https://jira.fd.io/browse/VPP-1522 fixed the issue with an assert we've >been seeing with random reassembly, however, there's still some other >

Re: [vpp-dev] Any tricks in IP reassembly ?

2018-12-13 Thread Klement Sekera via Lists.Fd.Io
The test framework spawns vpp with only one main thread and no workers. I had a patch which uses also worker threads but it never made it to git. It's grossly outdated by now. Anyhow, I don't think that's really possible with the current packet geneator implementation. Quoting pvi...@vinciconsult

Re: [vpp-dev] Any tricks in IP reassembly ?

2018-12-12 Thread Klement Sekera via Lists.Fd.Io
ound efficient .. > >-- > >mik...@yeah.net > >   > From: [1]Klement Sekera > Date: 2018-12-11 20:39 > To: [2]Mikado; [3]vpp-dev > Subject: Re: [vpp-dev] An

Re: [vpp-dev] Any tricks in IP reassembly ?

2018-12-11 Thread Klement Sekera via Lists.Fd.Io
Hi Mikado, if the fragments get split between multiple workers, then eventually they'll get dropped after timing out ... Regards, Klement Quoting Mikado (2018-12-11 08:52:28) >Hi, > >   I have noticed that  “ip4-reassembly-feature” node  only >reassembles packets stored in the l

Re: [vpp-dev] ikev2-ipsec-tunnel && NAT-T ?

2018-12-06 Thread Klement Sekera via Lists.Fd.Io
the ipsec tunnel negotiated out by ikev2 to be udp-encaped >using this api? >can you give me some tips? >thanks! > >-- > >wangchuan...@163.com > >   > 发件人: [1]Klement Seke

Re: [vpp-dev] ikev2-ipsec-tunnel && NAT-T ?

2018-12-06 Thread Klement Sekera via Lists.Fd.Io
ngchuan...@163.com > >   > 发件人: [1]Klement Sekera > 发送时间: 2018-12-04 18:09 > 收件人: [2]wangchuan...@163.com > 主题: Re: [vpp-dev] ikev2-ipsec-tunnel && NAT-T ? > There is an API to enable udp encap, but unless this is called > ext

Re: [vpp-dev] how can i del the ipsec Node that generated by ikev2?

2018-12-04 Thread Klement Sekera via Lists.Fd.Io
ev2 profile del pr1 >but ipsec0 still exists > >-- > >wangchuan...@163.com > >   > From: [1]Klement Sekera > Date: 2018-12-03 18:06 > To: [2]wangchuan...@163.com; [3]vpp-dev > Subject: Re: [vpp-dev] how can i del the ipsec Node that generated by >

Re: [vpp-dev] how can i del the ipsec Node that generated by ikev2?

2018-12-03 Thread Klement Sekera via Lists.Fd.Io
Can you please post the CLI commands which result in such state? Thanks, Klement Quoting wangchuan...@163.com (2018-12-03 04:12:55) >hi all, >    The ipsec Node generated by Ikev2 still existing after deleting the >ikev2 profile, how can I delete it? >Thanks! > >-

Re: [vpp-dev] test-ext failures seen on master

2018-11-19 Thread Klement Sekera via Lists.Fd.Io
that although it shouldn’t be different from the vcl test > apps which seem to be properly killed on test failure. Anyway, it’s on my > todo list, if nobody beats me to it. > > Florin > > > On Nov 16, 2018, at 5:27 AM, Klement Sekera [1] wrote: > > I've also

Re: [vpp-dev] test-ext failures seen on master

2018-11-16 Thread Klement Sekera via Lists.Fd.Io
lures. However this: > > make test-ext TEST=vcl.VCLCutThruTestCase.test_vcl_cut_thru_uni_dir_nsock > > runs just fine. After the latest test framework changes, are we running > multiple tests/vpps in parallel? I suspect that may be a source of issues. > > Florin > >

Re: [vpp-dev] Using clang-format ForEachMacros?

2018-11-16 Thread Klement Sekera via Lists.Fd.Io
clang can format the macros just fine as they are. I added clang for checking the style of c++ code (mainly vapi code). C files are still checked using indent, which doesn't understand the macros ... Also I wasn't able to come up with a clang-format which matches the current indent style 1:1 so I d

Re: [vpp-dev] test-ext failures seen on master

2018-11-16 Thread Klement Sekera via Lists.Fd.Io
latest test framework changes, are we running > multiple tests/vpps in parallel? I suspect that may be a source of issues. > > Florin > > > On Nov 15, 2018, at 12:11 PM, Klement Sekera via Lists.Fd.Io > > wrote: > > > > I'm seeing timeouts and coredumps

Re: [vpp-dev] test-ext failures seen on master

2018-11-15 Thread Klement Sekera via Lists.Fd.Io
>VCL IPv6 Thru Host Stack Extended D Tests > > ====== > run VCL thru host stack uni-directional (multiple sockets) test  >OK > >Ran 28 tests in 250.800s > >OK > > > ==

[vpp-dev] test-ext failures seen on master

2018-11-15 Thread Klement Sekera via Lists.Fd.Io
Hi all, I'm seeing failures on master branch on ubuntu 18.04 when invoking `make test-ext` FAILURES AND ERRORS IN TESTS: Testcase name: VCL Cut Thru Tests FAILURE: run VCL cut thru uni-directional (multiple sockets) test Testcase name: L2BD Test Case ERROR: L2BD MAC learning dual

Re: [vpp-dev] how to set cb for keepalive of vapi-connection @ 18.10

2018-11-14 Thread Klement Sekera via Lists.Fd.Io
ht break. > >-- > >wangchuan...@163.com > >   > From: [1]Klement Sekera > Date: 2018-11-13 18:04 > To: [2]wangchuan...@163.com; [3]vpp-dev > Subject: Re: [vpp-dev] how to set cb for keepalive of vapi-connection @ >

Re: [vpp-dev] how to set cb for keepalive of vapi-connection @ 18.10

2018-11-13 Thread Klement Sekera via Lists.Fd.Io
Hi, if you ask vapi to handle keepalives for you, why would you want to get callbacks for them? Regards, Klement Quoting wangchuan...@163.com (2018-11-13 07:27:33) >Hi�� >    At vpp stable/18.10, using vapi_connect to connect vpp and set the >"bool handle_keepalives " to true, >Bu

Re: [vpp-dev] ipsec support for chained buffers.

2018-11-12 Thread Klement Sekera via Lists.Fd.Io
Hi Vijay, yes, it's planned. Regards, Klement Quoting Vijayabhaskar Katamreddy via Lists.Fd.Io (2018-11-11 23:56:37) >Hi > >  > >Is there any plans or any work in progress to extend the support for ipsec >encrypt nodes to support the chained buffers? > >  > >Thanks >

Re: [vpp-dev] Can program have more than 1 VAPI connection?

2018-11-07 Thread Klement Sekera via Lists.Fd.Io
Hi, sadly, no, because the underlying low-level library uses global variables. Regards, Klement Quoting wangchuan...@163.com (2018-11-07 13:52:39) >Hi all, >    Can i create more than 1 connection using vapi_connect in my program ? >ctx was defined at .so (more than 1)  > >-

vpp-dev@lists.fd.io

2018-10-17 Thread Klement Sekera via Lists.Fd.Io
was no vapi_send, I can get 0 from vapi_recv after sometime. > why? > sometime,vapi_vxlan_add_del'reply,retvalue=0,but the tunnel_if_index=0 which > should be 6(got by cmd:show int) > > > > -- > 发自我的网易邮箱手机智能版 > > > 在 2018-10-15 19:03:52,"Klement Seke

  1   2   3   >