Re: [vpp-dev] A bug in IP reassembly?

2018-09-25 Thread Kingwel Xie
Ok. I'll find some time tomorrow to push a patch fixing both v4 and v6. -Original Message- From: Klement Sekera Sent: Tuesday, September 25, 2018 6:02 PM To: Kingwel Xie ; vpp-dev@lists.fd.io Subject: Re: [vpp-dev] A bug in IP reassembly? Hi Kingwel, thanks for finding this bug.

Re: [vpp-dev] A bug in IP reassembly?

2018-09-25 Thread Klement Sekera via Lists.Fd.Io
Hi Kingwel, thanks for finding this bug. Your patch looks fine - would you mind making a similar fix in ip4_reassembly.c? The logic suffers from the same flaw there. Thanks, Klement Quoting Kingwel Xie (2018-09-25 11:06:49) >Hi, > >  > >I worked on testing IP reassembly recently, t

[vpp-dev] A bug in IP reassembly?

2018-09-25 Thread Kingwel Xie
Hi, I worked on testing IP reassembly recently, the hit a crash when testing IP reassembly with IPSec. It took me some time to figure out why. The crash only happens when there are >1 feature node enabled under ip-unicast and ip reassembly is working, like below. ip4-unicast: ip4-reassembly-