Re: [vpp-dev] ACL Plugin: tagged interface

Khers, Thanks! Just after I sent you the reply Dave had pointed out coverity was unhappy with some of the code, including that particular line. So I got rid of memcpy altogether and while at it fixed the values for both this place and the other one I told you about - in change 9611. --a > On

Re: [vpp-dev] ACL Plugin: tagged interface

Dear Andrew Thanks for your attention, Yes of course I pushed to gerrit with id 9615. Regards, Khers On Tue, Nov 28, 2017 at 8:37 PM, Andrew Yourtchenko wrote: > Dear Khers, > > I believe you are right. That might not be all though... “dot1q”/“dot1ad” > mask value constant

Re: [vpp-dev] ACL Plugin: tagged interface

Dear Khers, I believe you are right. That might not be all though... “dot1q”/“dot1ad” mask value constant does not appear to make sense to me now. They should be “XX XX” to mask out the bits and also should be set accordingly to the proper values during the addition of the sessions. (I suppose