Re: [vpp-dev] Assertion failure on half-open connection pending cleanup

2021-01-16 Thread Florin Coras
The vpp-debug-verify-master-ubuntu2004 job is non voting, but one of the csit jobs is and it apparently failed. There are no tcp tests there so let’s see if the recheck passes. Regards, Florin > On Jan 16, 2021, at 3:28 AM, Ivan Shvedunov wrote: > > Looks like there are some CI failures in u

Re: [vpp-dev] Assertion failure on half-open connection pending cleanup

2021-01-16 Thread Ivan Shvedunov
Looks like there are some CI failures in unrelated test cases ... https://jenkins.fd.io/job/vpp-debug-verify-master-ubuntu2004-x86_64/696/console On Sat, Jan 16, 2021 at 3:58 AM Florin Coras wrote: > Thanks! > > Cheers, > Florin > > On Jan 15, 2021, at 4:49 PM, Ivan Shvedunov wrote: > > https:/

Re: [vpp-dev] Assertion failure on half-open connection pending cleanup

2021-01-15 Thread Florin Coras
Thanks! Cheers, Florin > On Jan 15, 2021, at 4:49 PM, Ivan Shvedunov wrote: > > https://gerrit.fd.io/r/c/vpp/+/30791 > > On Sat, Jan 16, 2021 at 3:22 AM Florin Coras > wrote: > Hi Ivan, > > You’re right that the assert w

Re: [vpp-dev] Assertion failure on half-open connection pending cleanup

2021-01-15 Thread Ivan Shvedunov
https://gerrit.fd.io/r/c/vpp/+/30791 On Sat, Jan 16, 2021 at 3:22 AM Florin Coras wrote: > Hi Ivan, > > You’re right that the assert wrongly assumes the connection must’ve been > established. I’m guessing you’re only sporadically hitting it because > typically the peer should not retransmit the

Re: [vpp-dev] Assertion failure on half-open connection pending cleanup

2021-01-15 Thread Ivan Shvedunov
Hi, thanks, I’ll prepare the patch in a moment On Sat, 16 Jan 2021 at 03:22, Florin Coras wrote: > Hi Ivan, > > You’re right that the assert wrongly assumes the connection must’ve been > established. I’m guessing you’re only sporadically hitting it because > typically the peer should not retrans

Re: [vpp-dev] Assertion failure on half-open connection pending cleanup

2021-01-15 Thread Florin Coras
Hi Ivan, You’re right that the assert wrongly assumes the connection must’ve been established. I’m guessing you’re only sporadically hitting it because typically the peer should not retransmit the syn after our reset (but probably the packet is lost). Want to push a patch to remove it or shou

[vpp-dev] Assertion failure on half-open connection pending cleanup

2021-01-15 Thread Ivan Shvedunov
Hi, in our UPG project[1] I'm sometimes hitting the following assertion in tcp[46]-syn-sent when trying to use at least 1 worker thread: https://github.com/FDio/vpp/blob/35ef865678d82b5a6fd3936716de8afb2fd49e60/src/vnet/tcp/tcp_input.c#L1820-L1821 We're using the host stack in a rather non-standar