[vpp-dev] Dependency on libsubunit ? (and failing to run tests)

2017-10-10 Thread Marco Varlese
Hi all, As of last week I could happily run tests (e.g. make test) on my distribution (openSUSE). When I tried again today - with latest master - I couldn't anymore: make[2]: Entering directory '/home/mvarlese/repo/vpp/test/ext' cc -o /home/mvarlese/repo/vpp/build-root/vapi_test/vapi_c_test -std

Re: [vpp-dev] Dependency on libsubunit ? (and failing to run tests)

2017-10-10 Thread Klement Sekera -X (ksekera - PANTHEON TECHNOLOGIES at Cisco)
Hi Marco, this issue is already being investigated by Tom Herbert. Strange thing is that check requires subunit. I wonder if it works if you install check only. Could you try removing -lsubunit from test/ext/Makefile? Thanks, Klement Quoting Marco Varlese (2017-10-10 16:00:00) > Hi all, > > As

Re: [vpp-dev] Dependency on libsubunit ? (and failing to run tests)

2017-10-10 Thread Marco Varlese
Hi Klement, Yes, once check-devel is in place, then we can remove -lsubunit from test/ext/Makefile. Things would still work (at least on openSUSE). Cheers, Marco On Tue, 2017-10-10 at 14:03 +, Klement Sekera -X (ksekera - PANTHEON TECHNOLOGIES at Cisco) wrote: > Hi Marco, > > this issue is

Re: [vpp-dev] Dependency on libsubunit ? (and failing to run tests)

2017-10-10 Thread Marco Varlese
Hi Klement, Yes, once check-devel is in place, then we can remove -lsubunit from test/ext/Makefile. Things would still work (at least on openSUSE). I submitted a patch for review: https://gerrit.fd.io/r/#/c/8736/ Cheers, Marco On Tue, 2017-10-10 at 14:03 +, Klement Sekera -X (ksekera - PAN

Re: [vpp-dev] Dependency on libsubunit ? (and failing to run tests)

2017-10-10 Thread Thomas F Herbert
On 10/10/2017 10:03 AM, Klement Sekera -X (ksekera - PANTHEON TECHNOLOGIES at Cisco) wrote: Hi Marco, this issue is already being investigated by Tom Herbert. Strange thing is that check requires subunit. I wonder if it works if you install check only. Could you try removing -lsubunit from te

Re: [vpp-dev] Dependency on libsubunit ? (and failing to run tests)

2017-10-10 Thread Thomas F Herbert
On 10/10/2017 10:46 AM, Marco Varlese wrote: Hi Klement, Yes, once check-devel is in place, then we can remove -lsubunit from test/ext/Makefile. Things would still work (at least on openSUSE). I submitted a patch for review: https://gerrit.fd.io/r/#/c/8736 Subunit is a prerequisite for check

Re: [vpp-dev] Dependency on libsubunit ? (and failing to run tests)

2017-10-10 Thread Klement Sekera -X (ksekera - PANTHEON TECHNOLOGIES at Cisco)
Hi Marco, as you can see in your review build failure, removing -lsubunit breaks existing stuff... Thanks, Klement Quoting Marco Varlese (2017-10-10 16:46:13) > Hi Klement, > > Yes, once check-devel is in place, then we can remove -lsubunit from > test/ext/Makefile. Things would still work (at

Re: [vpp-dev] Dependency on libsubunit ? (and failing to run tests)

2017-10-10 Thread Marco Varlese
Well, as I said, it worked on SUSE distro... I'm modifying the patch to have a OS check so to remove this dependency for SUSE since the "check" version we ship does not have that dependency (and we don't have subunit at all as previously mentioned). - Marco On Wed, 2017-10-11 at 06:35 +, Kle

Re: [vpp-dev] Dependency on libsubunit ? (and failing to run tests)

2017-10-11 Thread Marco Varlese
On Tue, 2017-10-10 at 12:11 -0400, Thomas F Herbert wrote: > > > > > > On 10/10/2017 10:03 AM, Klement Sekera > -X (ksekera - PANTHEON TECHNOLOGIES at Cisco) wrote: > > > > > Hi Marco, > > > > this issue is already being investigated by Tom Herbert. Stra

Re: [vpp-dev] Dependency on libsubunit ? (and failing to run tests)

2017-10-11 Thread Klement Sekera -X (ksekera - PANTHEON TECHNOLOGIES at Cisco)
Is SUSE supported? If so, maybe we should add it to the verify job to prevent future headaches... Klement Quoting Marco Varlese (2017-10-11 08:49:01) > Well, as I said, it worked on SUSE distro... > > I'm modifying the patch to have a OS check so to remove this dependency for > SUSE > since the

Re: [vpp-dev] Dependency on libsubunit ? (and failing to run tests)

2017-10-11 Thread Marco Varlese
On Wed, 2017-10-11 at 08:04 +, Klement Sekera -X (ksekera - PANTHEON TECHNOLOGIES at Cisco) wrote: > Is SUSE supported? If so, maybe we should add it to the verify job to > prevent future headaches... As of yesterday, I finally managed to clean-up the Jenkins job and have it building fine. For