Re: [vpp-dev] Is it too late for Wireguard patches getting in for VPP22.02?

2022-01-21 Thread Andrew Yourtchenko
ndrew 👽 Yourtchenko > Cc: Zhang, Roy Fan ; vpp-dev ; > Andrew Yourtchenko (ayourtch) ; Kinsella, Ray > ; Oginski, GabrielX > Subject: Re: [vpp-dev] Is it too late for Wireguard patches getting in for > VPP22.02? > Asdfasd > Hi Andrew, > > The change in crypto.h

Re: [vpp-dev] Is it too late for Wireguard patches getting in for VPP22.02?

2022-01-19 Thread Fan Zhang
Yourtchenko Cc: Zhang, Roy Fan ; vpp-dev ; Andrew Yourtchenko (ayourtch) ; Kinsella, Ray ; Oginski, GabrielX Subject: Re: [vpp-dev] Is it too late for Wireguard patches getting in for VPP22.02? Asdfasd Hi Andrew, The change in crypto.h that you called out as being whitespace-only actually changes

Re: [vpp-dev] Is it too late for Wireguard patches getting in for VPP22.02?

2022-01-19 Thread Matthew Smith via lists.fd.io
Hi Andrew, The change in crypto.h that you called out as being whitespace-only actually changes more than whitespace... It also appends '_ (CHACHA20_POLY1305, "chacha20-poly1305", 32, 16, 0)' to foreach_crypto_aead_async_alg. -Matt On Wed, Jan 19, 2022 at 10:21 AM Andrew 👽 Yourtchenko wrote:

Re: [vpp-dev] Is it too late for Wireguard patches getting in for VPP22.02?

2022-01-19 Thread Fan Zhang
nsella, Ray ; Oginski, > GabrielX ; Smith, Matthew > > Subject: Re: [vpp-dev] Is it too late for Wireguard patches getting in for > VPP22.02? > > Hi Fan, > > With my release manager hat on: > > the first three patches are solely contained (minus seemingly > w

Re: [vpp-dev] Is it too late for Wireguard patches getting in for VPP22.02?

2022-01-19 Thread Andrew Yourtchenko
Hi Fan, With my release manager hat on: the first three patches are solely contained (minus seemingly whitespace change in 34660? can it be avoided ?) within wireguard plugin, which has "experimental" status, with which I would be happy to err on the side of keeping the velocity - so once the nit

[vpp-dev] Is it too late for Wireguard patches getting in for VPP22.02?

2022-01-19 Thread Fan Zhang
Hi, Sorry for the late notice, but we have a bunch of patches waiting to be reviewed/merged if possible for VPP22.02. The patches do 2 things * Optimizing wireguard performance by introducing burst processing of packets and chacha-poly encryption/decryption. * Adding async mode to wire