Re: [vpp-dev] Multiple patch validation failures: yamllint AWOL

2019-11-14 Thread Vratko Polak -X (vrpolak - PANTHEON TECHNOLOGIES at Cisco) via Lists.Fd.Io
dev] Multiple patch validation failures: yamllint AWOL How do people feel about managing the CI where possible via the Makefile by testing for JENKINS_URL? On Wed, Nov 13, 2019 at 10:11 AM Dave Wallace mailto:dwallac...@gmail.com>> wrote: Status update: Florin fixed 'make check

Re: [vpp-dev] Multiple patch validation failures: yamllint AWOL

2019-11-13 Thread Paul Vinciguerra
How do people feel about managing the CI where possible via the Makefile by testing for JENKINS_URL? On Wed, Nov 13, 2019 at 10:11 AM Dave Wallace wrote: > Status update: > > Florin fixed 'make checkstyle' with [1] (Thanks Florin! :) > > Ed Kern has added 'make install-dep' to the checkstyle ve

Re: [vpp-dev] Multiple patch validation failures: yamllint AWOL

2019-11-13 Thread Dave Wallace
Status update: Florin fixed 'make checkstyle' with [1]  (Thanks Florin! :) Ed Kern has added 'make install-dep' to the checkstyle verify build executors. The revert of my ci-management patch [2] will be abandoned. Florin's patch will be reverted once the new build executors are available an

Re: [vpp-dev] Multiple patch validation failures: yamllint AWOL

2019-11-13 Thread Paul Vinciguerra
Can you leave it? The change in the makefile was backed out. Can we work on automating new containers when the makefile is updated? On Wed, Nov 13, 2019 at 8:58 AM Dave Wallace wrote: > Dave, > > My bad. I had Vanessa merge a patch to ci-management [0] which I tested > locally, but forgot that

Re: [vpp-dev] Multiple patch validation failures: yamllint AWOL

2019-11-13 Thread Dave Wallace
Dave, My bad.  I had Vanessa merge a patch to ci-management [0] which I tested locally, but forgot that the build executors don't run 'make install-dep'. Unfortunately the ci-management verify jobs don't actually run any of the CI jobs to ensure that the system still works with the patch bein

[vpp-dev] Multiple patch validation failures: yamllint AWOL

2019-11-13 Thread Dave Barach via Lists.Fd.Io
I wonder where "yamllint" went? Multiple patches affected... 07:28:23 clang-format version 6.0.0-1ubuntu2 (tags/RELEASE_600/final) 07:28:24 HEAD detached at dce8b380a 07:28:24 nothing to commit, working tree clean 07:28:24 *** 07:28:2