Re: [vpp-dev] Please include Fixes: tag for regression fix

2021-11-02 Thread Mohsin Kazmi via lists.fd.io
br Mohsin From: on behalf of "Damjan Marion via lists.fd.io" Reply-To: "dmar...@me.com" Date: Tuesday, November 2, 2021 at 5:44 PM To: "Steven Luong (sluong)" Cc: "vpp-dev@lists.fd.io" Subject: Re: [vpp-dev] Please include Fixes: tag for regression fix We sh

Re: [vpp-dev] Please include Fixes: tag for regression fix

2021-11-02 Thread Damjan Marion via lists.fd.io
We should probably extend checkstyle to reject patch if there is “Type: fix” and there is no “Fixes: *”. We can have special case “Fixes: unknown” to willingly bypass this check…. — Damjan > On 02.11.2021., at 18:17, steven luong via lists.fd.io > wrote: > > Folks, > > In case you don’t

[vpp-dev] Please include Fixes: tag for regression fix

2021-11-02 Thread steven luong via lists.fd.io
Folks, In case you don’t already know, there is a tag called Fixes in the commit message which allows one to specify if the current patch fixes a regression. See an example usage in https://gerrit.fd.io/r/c/vpp/+/34212 When you commit a patch which fixes a known regression, please make use of t