Re: [vpp-dev] Query regarding packet validation checks in ip6_local

2021-11-05 Thread pankajmalhotra83
Hi Ole, The problem I am facing is a bit different. It is not that it is failing for me in any scenario, but the implementation seems a little confusing and hence I posted this query for clarification. I'll try explaining my test scenario. The documentation for VPP Configuration File -

Re: [vpp-dev] Query regarding packet validation checks in ip6_local

2021-11-03 Thread Ole Troan
Pankaj, > In file vnet/ip/ip6_forward.c(VPP 21.01), function ip6_local_inline(), > the node's packet processing has the following check: > > if (PREDICT_FALSE (need_csum)) > { > flags = ip6_tcp_udp_icmp_validate_checksum (vm, b[0]); >

Re: [vpp-dev] Query regarding packet validation checks in ip6_local

2021-11-02 Thread Florin Coras
Hi Pankaj, I’ll leave the hop-by-hop questions to others that are more familiar with the code. As for the length check being done only on the else branch, ip6_tcp_udp_icmp_validate_checksum needs to compute the length so I’m guessing the expectation is that the checksum validation will fail

[vpp-dev] Query regarding packet validation checks in ip6_local

2021-11-02 Thread pankajmalhotra83
Hi, In file vnet/ip/ip6_forward.c(VPP 21.01), function ip6_local_inline(), the node's packet processing has the following check: if (PREDICT_FALSE (need_csum)) { flags = ip6_tcp_udp_icmp_validate_checksum (vm, b[0]); good_l4_csum = flags & VNET_BUFFER_F_L4_CHECKSUM_CORRECT; error =