Re: [vpp-dev] Semantics of field 'link_speed' in 'sw_interface_details' API.

2018-03-30 Thread Dmitry Vakhrushev
Ok. Thank you. Seems 1kbps steps looks fine for me too. Regards, --Dmitry On Thu, Mar 29, 2018 at 10:46 PM, Damjan Marion wrote: > > Yes, but too late for 18.04. We can do that change later after rc1 is out. > I personally prefer that we simply keep speed as numeric

Re: [vpp-dev] Semantics of field 'link_speed' in 'sw_interface_details' API.

2018-03-29 Thread Chris Luke
io" <vpp-dev@lists.fd.io> Subject: Re: [vpp-dev] Semantics of field 'link_speed' in 'sw_interface_details' API. Yes, but too late for 18.04. We can do that change later after rc1 is out. I personally prefer that we simply keep speed as numeric value in 1kbps steps. That should be fine

Re: [vpp-dev] Semantics of field 'link_speed' in 'sw_interface_details' API.

2018-03-29 Thread Damjan Marion
Yes, but too late for 18.04. We can do that change later after rc1 is out. I personally prefer that we simply keep speed as numeric value in 1kbps steps. That should be fine for up to 4Tbps. > On 27 Mar 2018, at 14:58, Dmitry Vakhrushev wrote: > > Hi, > > Changes in

[vpp-dev] Semantics of field 'link_speed' in 'sw_interface_details' API.

2018-03-27 Thread Dmitry Vakhrushev
Hi, Changes in commit: 03f47f1e738051db1412a93c2b90a7426f81f648 This commit provided new ethernet speeds which store as speed bit in a variable. And the current version of API for 'sw_interface_details' is not correct for that changes. Current variable in sw_interface_details API interface