Re: [vpp-dev] VPP API CRC compatibility check process in checkstyle merged and active

2020-06-22 Thread Andrew Yourtchenko
On 6/22/20, Neale Ranns (nranns) wrote: > Doing only new functionality that the point of introducing the new API is > good because it ensures no-harm-done to all tested functionality of the v1 > API. However, users of the new API will [likely?] use the v2 API for old and > new functions, but

Re: [vpp-dev] VPP API CRC compatibility check process in checkstyle merged and active

2020-06-22 Thread Neale Ranns via lists.fd.io
From: on behalf of Andrew Yourtchenko Date: Thursday 18 June 2020 at 17:58 To: "Neale Ranns (nranns)" Cc: vpp-dev Subject: Re: [vpp-dev] VPP API CRC compatibility check process in checkstyle merged and active Hi Neale, On 18 Jun 2020, at 17:11, Neale Ranns (nranns) wrote:

Re: [vpp-dev] VPP API CRC compatibility check process in checkstyle merged and active

2020-06-18 Thread Andrew Yourtchenko
> Cc: Neale Ranns (nranns) ; vpp-dev > Subject: Re: [vpp-dev] VPP API CRC compatibility check process in checkstyle > merged and active > > Hi Balaji, > > Yeah that was what I was thinking, though weekly ain’t good enough - one > would have to run coverage report before and af

Re: [vpp-dev] VPP API CRC compatibility check process in checkstyle merged and active

2020-06-18 Thread Dave Barach via lists.fd.io
pp-dev@lists.fd.io>> on behalf of Andrew Yourtchenko mailto:ayour...@gmail.com>> Date: Thursday, June 18, 2020 at 8:58 AM To: "Neale Ranns (nranns)" mailto:nra...@cisco.com>> Cc: vpp-dev mailto:vpp-dev@lists.fd.io>> Subject: Re: [vpp-dev] VPP API CRC compatibi

Re: [vpp-dev] VPP API CRC compatibility check process in checkstyle merged and active

2020-06-18 Thread Andrew Yourtchenko
> > From: on behalf of Andrew Yourtchenko > > Date: Thursday, June 18, 2020 at 8:58 AM > To: "Neale Ranns (nranns)" > Cc: vpp-dev > Subject: Re: [vpp-dev] VPP API CRC compatibility check process in checkstyle > merged and active > > Hi Neale,

Re: [vpp-dev] VPP API CRC compatibility check process in checkstyle merged and active

2020-06-18 Thread Balaji Venkatraman via lists.fd.io
: Thursday, June 18, 2020 at 8:58 AM To: "Neale Ranns (nranns)" Cc: vpp-dev Subject: Re: [vpp-dev] VPP API CRC compatibility check process in checkstyle merged and active Hi Neale, On 18 Jun 2020, at 17:11, Neale Ranns (nranns) wrote: Hi Andrew, A couple of questions? Absolutely!

Re: [vpp-dev] VPP API CRC compatibility check process in checkstyle merged and active

2020-06-18 Thread Andrew Yourtchenko
Hi Neale, > On 18 Jun 2020, at 17:11, Neale Ranns (nranns) wrote: > >  > Hi Andrew, > > A couple of questions? Absolutely! That’s how we improve it! Thanks a lot for the questions ! Replies inline: > > Firstly, about unit testing aka make test. This is the salient passage in > your

Re: [vpp-dev] VPP API CRC compatibility check process in checkstyle merged and active

2020-06-18 Thread Neale Ranns via lists.fd.io
Hi Andrew, A couple of questions? Firstly, about unit testing aka make test. This is the salient passage in your guide: "foo_message_v2 is tested in "make test" to the same extent as the foo_message" IMHO "to the same extent" implies everywhere v1 is used v2 should now be used in its place.

[vpp-dev] VPP API CRC compatibility check process in checkstyle merged and active

2020-06-18 Thread Andrew Yourtchenko
Resending with the address that is subscribed to the list, as i didn’t notice my MUA using the wrong one. Begin forwarded message: > From: "Andrew Yourtchenko (ayourtch)" > Date: 17 June 2020 at 20:47:51 CEST > To: vpp-dev > Cc: Ole Troan , "Vratko Polak -X (vrpolak - PANTHEON > TECH SRO at