Re: [Vserver] Proposed patch (was bug with reiserfs and patch-2.6.8-rc4-vs1.9.2.17.diff)

2004-08-15 Thread Herbert Poetzl
On Fri, Aug 13, 2004 at 04:21:14PM +0200, Luc Dumaine wrote: > Just to say explicitely what was implicited by the last message: the > patched kernel doesn't exhibit the bug. thanks, yeah, you are right, the actual issue is a wrongly placed parenthesis, it should be ( (oldflags & REISERFS_IMM

Re: [Vserver] Proposed patch (was bug with reiserfs and patch-2.6.8-rc4-vs1.9.2.17.diff)

2004-08-13 Thread Luc Dumaine
Just to say explicitely what was implicited by the last message: the patched kernel doesn't exhibit the bug. More that a problem of logic I think that this could be a problem with operators prority: it would have worked if "||" had a higher priority than "&&". Regards.

[Vserver] Proposed patch (was bug with reiserfs and patch-2.6.8-rc4-vs1.9.2.17.diff)

2004-08-13 Thread Luc Dumaine
Hi, Maybe I found a solution. This could be just some bogus logic in capabilities verification, see the patch below. Regards. --- linux-2.6.8-rc4-vs1.9.2.17.orig/fs/reiserfs/ioctl.c 2004-08-13 15:52:02.0 +0200 +++ linux-2.6.8-rc4-vs1.9.2.17/fs/reiserfs/ioctl.c 2004-08-13 15:58:36.000