Re: [waffle] [PATCH v2 2/3] wcore: rework non-compatible mutex initialization

2015-03-26 Thread Emil Velikov
On 26 March 2015 at 14:50, Chad Versace wrote: > Quoting Emil Velikov (2015-03-25 07:30:00) >> On 24 March 2015 at 17:37, Jose Fonseca wrote: >> > Is wcore_display_teardown called only once, or when destroying each >> > display? >> > >> > If the latter, then it's not safe to call `mtx_destroy(&m

Re: [waffle] [PATCH v3 4/4] wayland: resolve wayland-client symbols at runtime (via libdl)

2015-03-26 Thread Emil Velikov
On 26 March 2015 at 16:20, Chad Versace wrote: > Quoting Emil Velikov (2015-03-18 13:03:08) >> On 17 March 2015 at 19:54, Chad Versace wrote: >> > Hey Emil, >> > >> > The patches look good to me, though I haven't tested them yet. >> > I'm going to run the patches through a Piglit run and, if I >>

Re: [waffle] [PATCH v2 04/10] nacl: rework nacl_dl functions

2015-03-26 Thread Emil Velikov
On 26 March 2015 at 05:56, Tapani Pälli wrote: > On 03/25/2015 04:22 PM, Emil Velikov wrote: >> >> This is a direct copy from cgl with the following tweaks >> - s/cgl/nacl/ >> - s/cgl_dl_gl_path/NACL_GLES2_LIBRARY/ >> - Add move the nacl_prefix function from nacl_platform.c >> >> Doing this

Re: [waffle] [PATCH v2 2/3] wcore: rework non-compatible mutex initialization

2015-03-26 Thread Chad Versace
Quoting Jose Fonseca (2015-03-26 09:01:41) > The approach we use to statically initialize critical sections on > windows is unofficial. Read > http://locklessinc.com/articles/pthreads_on_windows/ for the gritty details. From the page: #define PTHREAD_MUTEX_INITIALIZER {(void*)-1,-1,0,0,0,0}

Re: [waffle] [PATCH v3 4/4] wayland: resolve wayland-client symbols at runtime (via libdl)

2015-03-26 Thread Chad Versace
Quoting Emil Velikov (2015-03-18 13:03:08) > On 17 March 2015 at 19:54, Chad Versace wrote: > > Hey Emil, > > > > The patches look good to me, though I haven't tested them yet. > > I'm going to run the patches through a Piglit run and, if I > > find no regressions, I'll push them. > Great thanks.

Re: [waffle] [PATCH v2 2/3] wcore: rework non-compatible mutex initialization

2015-03-26 Thread Jose Fonseca
On 26/03/15 14:50, Chad Versace wrote: Quoting Emil Velikov (2015-03-25 07:30:00) On 24 March 2015 at 17:37, Jose Fonseca wrote: Is wcore_display_teardown called only once, or when destroying each display? If the latter, then it's not safe to call `mtx_destroy(&mutex)` on `wcore_display_teard

Re: [waffle] [PATCH 1/3] third_party/threads: Use PTHREAD_MUTEX_RECURSIVE by default

2015-03-26 Thread Chad Versace
Quoting Emil Velikov (2015-03-19 15:26:11) > PTHREAD_MUTEX_RECURSIVE_NP was used for compatibility with old glibc. > Although due to the_GNU_SOURCES define the portable, > PTHREAD_MUTEX_RECURSIVE will be available for Linuxes since at least > 1998. Simplify things giving us compatibility with musl

Re: [waffle] [PATCH v2 2/3] wcore: rework non-compatible mutex initialization

2015-03-26 Thread Chad Versace
Quoting Emil Velikov (2015-03-25 07:30:00) > On 24 March 2015 at 17:37, Jose Fonseca wrote: > > Is wcore_display_teardown called only once, or when destroying each display? > > > > If the latter, then it's not safe to call `mtx_destroy(&mutex)` on > > `wcore_display_teardown`. Otherwise when wco

Re: [waffle] [PATCH] gl_basic: request alpha planes

2015-03-26 Thread Chad Versace
Thanks. I'll merge this to stable branches and master. Quoting Frank Henigman (2015-03-23 18:34:44) > Alpha planes are written and read, so we should ask for them in the config. > > Signed-off-by: Frank Henigman > --- > examples/gl_basic.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --g