Re: Code clean up: Removal of IndexWave and ConsoleClient

2011-08-21 Thread Thomas Wrobel
Once a new c/s is established it would make sense to have a simplist as possible example client, and that could possibly take the form of a console one. When that stage comes will there be much advantage in reusing the old console client code? or is the bulk of the tricky stuff just in the c/s its

Re: Code clean up: Removal of IndexWave and ConsoleClient

2011-08-21 Thread David Hearnden
Option 3 gets a +1 from me. It would be great to restore the ConsoleClient at some stage - it's a nice lightweight client, it helps to ensure a sound protocol, and it should be a useful reference implementation. But if nobody has the time to maintain it right now, then it's better to focus on the

Re: Code clean up: Removal of IndexWave and ConsoleClient

2011-08-21 Thread Lennard de Rijk
I like option 3 as well. Greetings, Lennard On Sun, Aug 21, 2011 at 06:50, Yuri Z wrote: > Oops, I forgot to mention option 3 which is also preferred and the easiest > one: > Option 3: To remove the whole IndexWave and ConsoleClient related code > without fixing it. > The suggested patch is act

Re: Code clean up: Removal of IndexWave and ConsoleClient

2011-08-21 Thread Soren Lassen
I'm in strong support of option 3 to remove the whole IndexWave and ConsoleClient related code. They served us well in the early days of experimentation with federation but now it's holding us back. The IndexWave design doesn't work and it will require a major investment, which we cannot afford, to

Re: Code clean up: Removal of IndexWave and ConsoleClient

2011-08-21 Thread Thomas Wrobel
Option 3 sounds good. Cleaner the core code is the better for understanding. Id guess as a new client/server protocol is implemented it might be tempting to build a really basic (code-independent) client for testing though. On 21 August 2011 16:54, Michael MacFadden wrote: > +1 for option 3.  T

Re: Code clean up: Removal of IndexWave and ConsoleClient

2011-08-21 Thread Michael MacFadden
+1 for option 3. The source code will remain available for historical reference. I think the large amount of dead code in the project is confusing and should be trimmed when possible. The console client is not on anyones radar, so as we made changes I see it just falling more and more behind.

Re: Code clean up: Removal of IndexWave and ConsoleClient

2011-08-21 Thread Yuri Z
Oops, I forgot to mention option 3 which is also preferred and the easiest one: Option 3: To remove the whole IndexWave and ConsoleClient related code without fixing it. The suggested patch is actually related to the option 3, not to the option 2. 2011/8/21 Yuri Z > Hello > The WIAB code current

Re: Code clean up: Removal of IndexWave and ConsoleClient

2011-08-21 Thread Lennard de Rijk
On Sun, Aug 21, 2011 at 06:32, Yuri Z wrote: > Hello > The WIAB code currently contains a lot of deprecated and broken code: the > IndexWave functionality in Web client was replaced by an RPC calls to a > search service. The change was also dictated by the need to get rid of > legacy client-serve