Re: [PATCH weston 3/6] xwm: set appropriate cursors for the frame window

2012-07-11 Thread Scott Moreau
> We don't need to set the cursor on leave, whatever window the cursor > moves into will set it. But we do need to set it on enter. > > What if the surface the cursor moves to is the background image? Could the desktop surface set the cursor to a default pointer? Scott __

[weston PATCH 2/2] toytoolkit: Remove obsolete function window_set_custom().

2012-07-11 Thread Scott Moreau
--- clients/tablet-shell.c |9 +++-- clients/window.c |6 -- clients/window.h |3 --- clients/wscreensaver.c |1 - 4 files changed, 3 insertions(+), 16 deletions(-) diff --git a/clients/tablet-shell.c b/clients/tablet-shell.c index 5a2bd34..0a66950 100644 --- a

[weston PATCH 1/2] wscreensaver: Fix --demo mode.

2012-07-11 Thread Scott Moreau
--- clients/wscreensaver.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/clients/wscreensaver.c b/clients/wscreensaver.c index 2b0ea46..f1461f8 100644 --- a/clients/wscreensaver.c +++ b/clients/wscreensaver.c @@ -181,7 +181,11 @@ create_wscreensaver_instance(struct

Re: [PATCH weston 5/6] xwayland: set cursor size for libXcursor

2012-07-11 Thread Kristian Høgsberg
On Thu, Jul 12, 2012 at 12:46:14AM +0300, Tiago Vignatti wrote: > 32 is consistent with toytoolkit. Why don't we just hardcode this to 32 in xcb-cursor.c for now (like we already do in window.c), and if we feel like making it configurable, we can read it from weston.ini later? Kristian > Signed-

Re: [PATCH weston 4/6] xwm: set the root window pointer to left_ptr

2012-07-11 Thread Kristian Høgsberg
On Thu, Jul 12, 2012 at 12:46:13AM +0300, Tiago Vignatti wrote: > More pretty and also consistent with toytoolkit. Looks good, just one comment below. Kristian > Signed-off-by: Tiago Vignatti > --- > src/xwayland/window-manager.c | 18 -- > 1 file changed, 8 insertions(+), 10

Re: [PATCH weston 3/6] xwm: set appropriate cursors for the frame window

2012-07-11 Thread Kristian Høgsberg
On Thu, Jul 12, 2012 at 12:46:12AM +0300, Tiago Vignatti wrote: > based on xcb-cursor. Looks good, but there's a couple of comments below. Kristian > Signed-off-by: Tiago Vignatti > --- > src/xwayland/window-manager.c | 132 > + > src/xwayland/xwayland

Re: [PATCH weston 1/6] compositor: remove useless weston_compositor_repick call

2012-07-11 Thread Kristian Høgsberg
On Thu, Jul 12, 2012 at 12:46:10AM +0300, Tiago Vignatti wrote: > compositor->focus was just unset, and weston_compositor_repick() has no > effect. I've committed the patch and the call to repick doesn't do anything anymore, but it used to take away pointer focus for all seats when focus was 0. T

Re: A barebone version of Weston?

2012-07-11 Thread Christopher James Halse Rogers
On Tue, 2012-07-10 at 18:53 -0700, Mikalai Kisialiou wrote: > There is an article on http://www.phoronix.com that there is a new > feature of sliding desktop support in Weston. I am wondering if it > would make sense to split Weston implemention into 2 distinct ones: a > barebone implementation wit

[PATCH weston 6/6] xwm: set grabbing cursor for the frame grab

2012-07-11 Thread Tiago Vignatti
This patch sets the cursor for the frame window only. The other case left is when the client itself performs a grab instead the titlebar drag. E.g. google-chrome without decoration does move a window (when click-n-drag the bar on the side of the tabs) but the cursor doesn't set back to the default

[PATCH weston 5/6] xwayland: set cursor size for libXcursor

2012-07-11 Thread Tiago Vignatti
32 is consistent with toytoolkit. Signed-off-by: Tiago Vignatti --- src/xwayland/launcher.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/src/xwayland/launcher.c b/src/xwayland/launcher.c index 035c8e3..37b1d54 100644 --- a/src/xwayland/launcher.c +++ b/src/xwayland/launcher.c @@ -36

[PATCH weston 4/6] xwm: set the root window pointer to left_ptr

2012-07-11 Thread Tiago Vignatti
More pretty and also consistent with toytoolkit. Signed-off-by: Tiago Vignatti --- src/xwayland/window-manager.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/src/xwayland/window-manager.c b/src/xwayland/window-manager.c index 0f2b24d..ec5ae0a 100644 -

[PATCH weston 3/6] xwm: set appropriate cursors for the frame window

2012-07-11 Thread Tiago Vignatti
based on xcb-cursor. Signed-off-by: Tiago Vignatti --- src/xwayland/window-manager.c | 132 + src/xwayland/xwayland.h |2 + 2 files changed, 134 insertions(+) diff --git a/src/xwayland/window-manager.c b/src/xwayland/window-manager.c index 6e03

[PATCH weston 2/6] xwayland: add simple xcb-cursor hook based on libXcursor

2012-07-11 Thread Tiago Vignatti
It's in fact based on the core of libXcursor, which doesn't bring any Xlib dependency. Signed-off-by: Tiago Vignatti --- configure.ac |2 +- src/xwayland/Makefile.am |1 + src/xwayland/xcb-cursor.c | 140 + src/xwayland/xwayland.

[PATCH weston 1/6] compositor: remove useless weston_compositor_repick call

2012-07-11 Thread Tiago Vignatti
compositor->focus was just unset, and weston_compositor_repick() has no effect. Signed-off-by: Tiago Vignatti --- src/compositor.c |1 - 1 file changed, 1 deletion(-) diff --git a/src/compositor.c b/src/compositor.c index 5626517..95fcf2a 100644 --- a/src/compositor.c +++ b/src/compositor.c

[PATCH 6/6] text: add a composing input method demo

2012-07-11 Thread Philipp Brüschweiler
--- clients/.gitignore | 1 + clients/Makefile.am| 9 ++ clients/hiragana-ime.c | 381 + 3 Dateien geändert, 391 Zeilen hinzugefügt(+) create mode 100644 clients/hiragana-ime.c diff --git a/clients/.gitignore b/clients/.gitignore index

[PATCH 5/6] Add the keymap event to input_method

2012-07-11 Thread Philipp Brüschweiler
--- protocol/text.xml | 14 +- src/text-backend.c | 12 +++- 2 Dateien geändert, 24 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/protocol/text.xml b/protocol/text.xml index e51057a..54df12e 100644 --- a/protocol/text.xml +++ b/protocol/text.xml @@ -1,5 +1,5 @@ -

[PATCH 4/6] text: start support for keyboard events

2012-07-11 Thread Philipp Brüschweiler
* add the request_keyboard_input request to signal that the input method wants to receive keyboard events * add key and modifier events * keyboard events are grabbed with wl_keyboard_grab and relayed to the input method --- protocol/text.xml | 28 +++ src/compositor.c | 15 +++---

[PATCH 3/6] Extract the text_model_manager interface from input_method

2012-07-11 Thread Philipp Brüschweiler
This is necessary because all clients need a way to create text_models, but only one client at a time can be bound to the input_method global (else we don't know to whom we are supposed to send events). --- clients/editor.c | 9 +++--- protocol/text.xml | 4 ++- src/text-backend.c | 85 ++

[PATCH 2/6] text-backend: minor fixes

2012-07-11 Thread Philipp Brüschweiler
* make sure deactivation is done consistently when a text_model is destroyed * zero out allocated objects --- src/text-backend.c | 29 + 1 Datei geändert, 17 Zeilen hinzugefügt(+), 12 Zeilen entfernt(-) diff --git a/src/text-backend.c b/src/text-backend.c index 1d2c2

[PATCH 1/6] editor: deactivate old text model before activating the new one

2012-07-11 Thread Philipp Brüschweiler
--- clients/editor.c | 36 ++-- 1 Datei geändert, 22 Zeilen hinzugefügt(+), 14 Zeilen entfernt(-) diff --git a/clients/editor.c b/clients/editor.c index 145ba20..9498d53 100644 --- a/clients/editor.c +++ b/clients/editor.c @@ -20,6 +20,7 @@ * CONNECTION WITH THE

Re: [PATCH] Remove some dead code

2012-07-11 Thread Kristian Høgsberg
On Wed, Jul 11, 2012 at 03:24:06PM +0200, Philipp Brüschweiler wrote: > Hi everyone, > > Patch is attached. Thanks, applied. It's easier to review and discuss patches if you send them using git send-email, which will put the patch inline. Kristian > Cheers > Philipp > ___

Re: [PATCH 1/2] clipboard: add seat destroy signal handler

2012-07-11 Thread Kristian Høgsberg
On Wed, Jul 11, 2012 at 06:48:12PM +0200, Rafal Mielniczuk wrote: > --- > src/clipboard.c | 14 ++ > 1 file changed, 14 insertions(+) Thanks, applied. > diff --git a/src/clipboard.c b/src/clipboard.c > index 22d4b26..689e563 100644 > --- a/src/clipboard.c > +++ b/src/clipboard.c > @@

[PATCH 2/2] image-loader: don't leak pixman_image bits data

2012-07-11 Thread Rafal Mielniczuk
Set the pixman_image destroy function to free bits data --- shared/image-loader.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/shared/image-loader.c b/shared/image-loader.c index b47c1a7..6a5c85c 100644 --- a/shared/image-loader.c +++ b/shared/image

[PATCH 1/2] clipboard: add seat destroy signal handler

2012-07-11 Thread Rafal Mielniczuk
--- src/clipboard.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/clipboard.c b/src/clipboard.c index 22d4b26..689e563 100644 --- a/src/clipboard.c +++ b/src/clipboard.c @@ -243,6 +243,17 @@ clipboard_set_selection(struct wl_listener *listener, void *data)

[PATCH] Remove some dead code

2012-07-11 Thread Philipp Brüschweiler
Hi everyone, Patch is attached. Cheers Philipp 0001-Remove-dead-code.patch Description: Binary data ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: Input Methods

2012-07-11 Thread Philipp Brüschweiler
Hi Jan, I'm still slowly getting the hang of how wayland works, but I think I've spotted a problem: only one client at a time should bind to the input_method global. Else we don't know who we send events to. This has the consequence that the create_text_model request has to be moved somewhere els

[PATCH v1] shell: avoid endless sending event when meeting hanged-not-exited client

2012-07-11 Thread juan . j . zhao
From: Juan Zhao When the client was hanged and not responsible for a long time, the server will generate endless and useless "set_busy_cursor" related events. And finally, weston crashed, with error message:" read error from connection 0x823b560: Connection reset by peer (104) read error: C

Re: [PATCH] shell: avoid endless sending event when meeting hanged-not-exited client

2012-07-11 Thread Juan Zhao
On Tue, 2012-07-10 at 08:52 -0400, Kristian Høgsberg wrote: > On Tue, Jul 10, 2012 at 01:20:24AM -0700, > juan.j.z...@linux.intel.com wrote: > > From: Juan Zhao > > > > When the client was hanged and not responsible for a long time, the > server will generate > > endless and useless "set_busy_cu