[PATCH weston] wcap: Fix up --help.

2012-07-22 Thread Scott Moreau
--- wcap/main.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/wcap/main.c b/wcap/main.c index 09e0aa7..757aadb 100644 --- a/wcap/main.c +++ b/wcap/main.c @@ -147,15 +147,18 @@ output_yuv_frame(struct wcap_decoder *decoder) static void usage(int exit_code) { -

[PATCH weston 2/2] desktop-shell: Declare grab_cursor as enum cursor_type.

2012-07-22 Thread Scott Moreau
--- clients/desktop-shell.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/desktop-shell.c b/clients/desktop-shell.c index cf28246..61599c3 100644 --- a/clients/desktop-shell.c +++ b/clients/desktop-shell.c @@ -53,7 +53,7 @@ struct desktop { struct window *g

[PATCH weston 1/2] wcap: Declare variable with same sign as convert_to_yv12() expects.

2012-07-22 Thread Scott Moreau
--- wcap/main.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wcap/main.c b/wcap/main.c index bdbc8cb..09e0aa7 100644 --- a/wcap/main.c +++ b/wcap/main.c @@ -132,7 +132,7 @@ convert_to_yv12(struct wcap_decoder *decoder, unsigned char *out) static void output_yuv_frame(s

Silence a few hidden warnings.

2012-07-22 Thread Scott Moreau
Since we're gearing up for 0.95 release, I decided to build the code with clang. With these patches, wayland and weston build without warning. ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinf

[PATCH 3/3] text: add a composing input method demo

2012-07-22 Thread Philipp Brüschweiler
--- clients/.gitignore | 1 + clients/Makefile.am| 7 + clients/hiragana-ime.c | 546 + 3 Dateien geändert, 554 Zeilen hinzugefügt(+) create mode 100644 clients/hiragana-ime.c diff --git a/clients/.gitignore b/clients/.gitignore index b

[PATCH 2/3] text: add preedit_string and a reset event

2012-07-22 Thread Philipp Brüschweiler
--- clients/editor.c | 77 +++--- protocol/text.xml | 6 + src/text-backend.c | 23 ++-- 3 Dateien geändert, 95 Zeilen hinzugefügt(+), 11 Zeilen entfernt(-) diff --git a/clients/editor.c b/clients/editor.c index 19f7073..ba235bc

[PATCH 1/3] text: add keyboard events

2012-07-22 Thread Philipp Brüschweiler
* add request_keyboard so input methods can signal that they want to receive keyboard events * keyboard events are grabbed with wl_keyboard_grab and relayed to the input method using the created wl_keyboard interface --- protocol/text.xml | 5 +- src/compositor.c | 2 +- src/compositor.

Re: [PATCH 4/6] text: start support for keyboard events

2012-07-22 Thread Kristian Høgsberg
On Sun, Jul 22, 2012 at 07:58:34PM +0200, Philipp Brüschweiler wrote: > Hi Kristian, > > Thank you for including my patches. I'll try to follow the style > guidelines from now on :) Heh, sounds good. It was mostly all good though, just a few nit-picks. > On Sun, Jul 22, 2012 at 6:24 PM, Kristia

Re: [PATCH weston] Fix a crash when a client disconnects.

2012-07-22 Thread Kristian Høgsberg
On Sun, Jul 22, 2012 at 09:27:33AM -0700, Dima Ryazanov wrote: > Oh, sorry, I wasn't sure how to reproduce the other case. (Did you see my > last email? I don't know if I should write a new client, or if I can test > it with existing ones.) > I have some time, I'm just not familiar with the code :)

Re: [PATCH weston 1/3] xwm: Initialize window decoration always as !override

2012-07-22 Thread Kristian Høgsberg
On Fri, Jul 20, 2012 at 11:09:53PM +0300, Tiago Vignatti wrote: I grabbed these three patches, and overall it works much better than before. There's still a bit too much duct-tape involved and some corner cases are still broken though. Mainly, the problem is that X apps look at their main window

Re: [PATCH weston] weston.ini: Move binding-modifier to shell section.

2012-07-22 Thread Kristian Høgsberg
On Thu, Jul 19, 2012 at 12:49:06AM -0600, Scott Moreau wrote: > The variable has no effect as part of the screensaver section. Oops. Committed. Kristian > --- > weston.ini |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/weston.ini b/weston.ini > index f0736df..3c98e

Re: [PATCH] wayland util: Handle malloc failure in wl_array_copy()

2012-07-22 Thread Kristian Høgsberg
On Thu, Jul 19, 2012 at 03:45:57AM +0200, Martin Minarik wrote: > If the malloc in wl_array_add() fails, we are memcpy-ing to bad memory. > This can happen only when copying array to smaller array. > --- > src/wayland-util.c | 11 --- > src/wayland-util.h |2 +- > tests/array-test.c

Re: [PATCH 1/6] editor: deactivate old text model before activating the new one

2012-07-22 Thread Kristian Høgsberg
On Wed, Jul 18, 2012 at 08:07:46PM +0200, Philipp Brüschweiler wrote: > Ping. > > With these patches (and some others) I managed to get a basic ibus > client working. > (https://github.com/Blei/ibus/tree/ibus-wayland/client/wayland) That is cool... I would recommend not using toytoolkit for this

Re: Patches for resource id allocation

2012-07-22 Thread Kristian Høgsberg
On Wed, Jul 18, 2012 at 02:12:23PM +, Fiedler, Mathias wrote: > Hi Kristian, > > here are some patches for > - sending out an error on invalid new_ids > - creating new id entry implicitly in wl_connection_demarshal > > I'm not 100% sure if i understood the id management correctly, but i > hop

Re: [PATCH 4/6] text: start support for keyboard events

2012-07-22 Thread Philipp Brüschweiler
Hi Kristian, Thank you for including my patches. I'll try to follow the style guidelines from now on :) On Sun, Jul 22, 2012 at 6:24 PM, Kristian Høgsberg wrote: > On Wed, Jul 11, 2012 at 10:25:32PM +0200, Philipp Brüschweiler wrote: >> * add the request_keyboard_input request to signal that the

Re: [PATCH 2/3] shell: add panel height limiation when moving a window

2012-07-22 Thread Kristian Høgsberg
On Wed, Jul 18, 2012 at 01:37:59PM +0800, Juan Zhao wrote: > attach file: This patch resolved problem like this. Right, I see. I think we just need the moving code to restrict the motion so that the point we're dragging (maybe +/- a couple of pixels) can't end up under the panel for that. Kristi

Re: [PATCH 2/3] shell: add panel height limiation when moving a window

2012-07-22 Thread Kristian Høgsberg
On Tue, Jul 17, 2012 at 10:25:14PM -0700, juan.j.z...@linux.intel.com wrote: > From: Juan Zhao > > When applications not directly based on toytoolkit, like simple-egl, efl > applications is grabbed and moved, they may be moved to the place under > the panel. Then they could not be grabbed again.

Re: [PATCH weston] Fix a crash when a client disconnects.

2012-07-22 Thread Dima Ryazanov
Oh, sorry, I wasn't sure how to reproduce the other case. (Did you see my last email? I don't know if I should write a new client, or if I can test it with existing ones.) I have some time, I'm just not familiar with the code :) On Sun, Jul 22, 2012 at 8:45 AM, Kristian Høgsberg wrote: > On Tue,

Re: [PATCH 4/6] text: start support for keyboard events

2012-07-22 Thread Kristian Høgsberg
On Wed, Jul 11, 2012 at 10:25:32PM +0200, Philipp Brüschweiler wrote: > * add the request_keyboard_input request to signal that the > input method wants to receive keyboard events > * add key and modifier events > * keyboard events are grabbed with wl_keyboard_grab and relayed > to the input me

Re: [PATCH 3/6] Extract the text_model_manager interface from input_method

2012-07-22 Thread Kristian Høgsberg
On Wed, Jul 11, 2012 at 10:25:31PM +0200, Philipp Brüschweiler wrote: > This is necessary because all clients need a way to create > text_models, but only one client at a time can be bound to > the input_method global (else we don't know to whom we are > supposed to send events). Thanks, yeah, tha

Re: [PATCH 2/6] text-backend: minor fixes

2012-07-22 Thread Kristian Høgsberg
On Wed, Jul 11, 2012 at 10:25:30PM +0200, Philipp Brüschweiler wrote: > * make sure deactivation is done consistently when a text_model > is destroyed > * zero out allocated objects Sure. I followed up with a few whitespace fixes to keep lines under 80 characters. For stuff like

Re: [PATCH 1/6] editor: deactivate old text model before activating the new one

2012-07-22 Thread Kristian Høgsberg
On Wed, Jul 11, 2012 at 10:25:29PM +0200, Philipp Brüschweiler wrote: > --- > clients/editor.c | 36 ++-- > 1 Datei geändert, 22 Zeilen hinzugefügt(+), 14 Zeilen entfernt(-) Thanks, applied. Kristian > diff --git a/clients/editor.c b/clients/editor.c > index 145b

Re: [PATCH weston] Fix a crash when a client disconnects.

2012-07-22 Thread Kristian Høgsberg
On Tue, Jul 10, 2012 at 02:35:10PM -0400, Kristian Høgsberg wrote: > On Tue, Jul 10, 2012 at 09:28:11AM -0700, Dima Ryazanov wrote: > > I see the following use-after-free when a client disconnects: > > > > ==21822== Invalid write of size 8 > > ==21822==at 0x54A8F74: wl_list_remove (wayland-uti

Re: Can't compile newest wayland due to mesa changes?

2012-07-22 Thread Juan Zhao
On Sat, 2012-07-21 at 18:58 +0300, Pekka Paalanen wrote: > On Fri, 20 Jul 2012 22:40:50 -0700 > Bill Spitzak wrote: > > > However (sigh) now it fails with: > > > > compositor.c: In function ‘weston_surface_attach’: > > compositor.c:788:8: error: ‘EGL_TEXTURE_Y_UV_WL’ undeclared (first use > >

Re: Can't compile newest wayland due to mesa changes?

2012-07-22 Thread Juan Zhao
On Fri, 2012-07-20 at 22:30 -0700, Bill Spitzak wrote: > On 07/16/2012 11:48 PM, Juan Zhao wrote: > > >> CC libgbm_dri_la-gbm_dri.lo > >> In file included from backends/dri/gbm_dri.c:48:0: > >> backends/dri/../../../egl/wayland/wayland-drm/wayland-drm.h:5:41: fatal > >> error: wayland-drm